[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

2017-07-31 Thread milleruntime
Github user milleruntime commented on the issue: https://github.com/apache/accumulo/pull/286 Just curious but why open a PR for only a few hours? Even if the change is minor, seems like hardly enough time for review. --- If your project is set up for it, you can reply to this email

[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

2017-07-31 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/286 Read the JIRA issue, please. And, for the record, there is no obligation of review before commit. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

2017-07-31 Thread milleruntime
Github user milleruntime commented on the issue: https://github.com/apache/accumulo/pull/286 > there is no obligation of review before commit. Right, that's why I was wondering why you bothered with the PR. I see your comments on JIRA, thanks. --- If your project i

[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

2017-07-31 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/286 > >there is no obligation of review before commit. > Right, that's why I was wondering why you bothered with the PR. Personal preference. If someone wants to make time to revi