[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/82#issuecomment-204388925 @joshelser I can help merge this forward... we can coordinate on IRC --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/82#issuecomment-203961544 Don't worry about the squash and final changes, @mjwall, I already have them fixed locally (but thanks for offering). I already have 1.6 and 1.7 good. If you want to

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on the pull request: https://github.com/apache/accumulo/pull/82#issuecomment-203904254 I'll make another branch where I change those constants final and squash the commits to one. Then I'll try to merge to 1.6 locally. If that works, I'll close this PR a

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/82#issuecomment-203248708 I started merging this tonight, but am going to have to pick it up again later. The changes in 17b4b3c were bad because they weren't `final`. I've fixed those locally

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/82#issuecomment-202892585 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57590769 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java --- @@ -202,10 +203,26 @@ public InMemoryMap(Map> lggroups, boolean us

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57590803 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57590495 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java --- @@ -202,10 +203,26 @@ public InMemoryMap(Map> lggroups, boolean useNa

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57590440 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57590404 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57589046 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57588655 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java --- @@ -519,36 +520,25 @@ protected void finalize() throws Throwable {

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/82#issuecomment-202430768 Left a few minor comments (only one real request for a change). The number of new tests is very nice. I think I'd like to make sure I can get through a full run of th

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57575112 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57574973 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,319 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57574776 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java --- @@ -202,10 +203,26 @@ public InMemoryMap(Map> lggroups, boolean us

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57574698 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java --- @@ -519,36 +520,25 @@ protected void finalize() throws Throwable {

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on the pull request: https://github.com/apache/accumulo/pull/82#issuecomment-202183412 Thanks @keith-turner, let me know if there is anything else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56998062 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57000272 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r57000165 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56999430 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56999000 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56997783 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56998269 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56997973 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56997899 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] accumulo pull request: 4148 inmemorymap counter

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/82#discussion_r56996932 --- Diff: test/src/test/java/org/apache/accumulo/test/InMemoryMapIT.java --- @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request: 4148 inmemorymap counter

GitHub user mjwall opened a pull request: https://github.com/apache/accumulo/pull/82 4148 inmemorymap counter Tests and fixes for ACCUMULO-4148 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjwall/accumulo 4148-inmemorymap-count