Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76920911
--- Diff: pom.xml ---
@@ -1399,5 +1407,19 @@
+
--- End diff --
I understand the use case here. But,
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76920731
--- Diff: pom.xml ---
@@ -1399,5 +1407,19 @@
+
--- End diff --
Both Dima and I came into this chan
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76920439
--- Diff: pom.xml ---
@@ -1399,5 +1407,19 @@
+
--- End diff --
I don't follow that reasoning. Could
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76919910
--- Diff: pom.xml ---
@@ -1399,5 +1407,19 @@
+
--- End diff --
> If there's a good reason why thes
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76919835
--- Diff: TESTING.md ---
@@ -47,23 +47,27 @@ but are checking for regressions that were previously
seen in the codebase. Thes
resources, at least ano
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76919706
--- Diff: TESTING.md ---
@@ -47,23 +47,27 @@ but are checking for regressions that were previously
seen in the codebase. Thes
resources, at least anot
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76919553
--- Diff: pom.xml ---
@@ -1006,6 +1010,10 @@
integration-test
verify
+
+
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76919395
--- Diff: pom.xml ---
@@ -115,6 +115,10 @@
https://builds.apache.org/view/A-D/view/Accumulo/
+
org.apache.accumulo.test.cat
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76919026
--- Diff: pom.xml ---
@@ -115,6 +115,10 @@
https://builds.apache.org/view/A-D/view/Accumulo/
+
org.apache.accumulo.test.cat
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76918677
--- Diff: pom.xml ---
@@ -1399,5 +1407,19 @@
+
--- End diff --
Not a particular burden. It's just a
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76918667
--- Diff: TESTING.md ---
@@ -47,23 +47,27 @@ but are checking for regressions that were previously
seen in the codebase. Thes
resources, at least ano
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76918410
--- Diff: pom.xml ---
@@ -1006,6 +1010,10 @@
integration-test
verify
+
+
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76918438
--- Diff: TESTING.md ---
@@ -47,23 +47,27 @@ but are checking for regressions that were previously
seen in the codebase. Thes
resources, at least anot
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76918298
--- Diff: pom.xml ---
@@ -1006,6 +1010,10 @@
integration-test
verify
+
+
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76918156
--- Diff:
test/src/test/java/org/apache/accumulo/harness/SharedMiniClusterIT.java ---
@@ -48,6 +50,7 @@
* a method annotated with the {@link org.juni
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76916527
--- Diff: TESTING.md ---
@@ -47,23 +47,27 @@ but are checking for regressions that were previously
seen in the codebase. Thes
resources, at least ano
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76916481
--- Diff: pom.xml ---
@@ -115,6 +115,10 @@
https://builds.apache.org/view/A-D/view/Accumulo/
+
org.apache.accumulo.test.ca
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76916368
--- Diff: pom.xml ---
@@ -115,6 +115,10 @@
https://builds.apache.org/view/A-D/view/Accumulo/
+
org.apache.accumulo.test.ca
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76916358
--- Diff: pom.xml ---
@@ -115,6 +115,10 @@
https://builds.apache.org/view/A-D/view/Accumulo/
+
org.apache.accumulo.test.ca
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76916290
--- Diff: pom.xml ---
@@ -1006,6 +1010,10 @@
integration-test
verify
+
+
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76916170
--- Diff: pom.xml ---
@@ -1399,5 +1407,19 @@
+
--- End diff --
I think it is important to have the
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76916062
--- Diff:
test/src/test/java/org/apache/accumulo/harness/SharedMiniClusterIT.java ---
@@ -48,6 +50,7 @@
* a method annotated with the {@link org.jun
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76906134
--- Diff: TESTING.md ---
@@ -47,23 +47,27 @@ but are checking for regressions that were previously
seen in the codebase. Thes
resources, at least anot
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76905938
--- Diff: pom.xml ---
@@ -1006,6 +1010,10 @@
integration-test
verify
+
+
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76905452
--- Diff:
test/src/test/java/org/apache/accumulo/harness/SharedMiniClusterIT.java ---
@@ -48,6 +50,7 @@
* a method annotated with the {@link org.juni
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76905333
--- Diff: pom.xml ---
@@ -1399,5 +1407,19 @@
+
--- End diff --
These convenience profiles are great
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76905175
--- Diff: pom.xml ---
@@ -115,6 +115,10 @@
https://builds.apache.org/view/A-D/view/Accumulo/
+
org.apache.accumulo.test.cat
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76904810
--- Diff: pom.xml ---
@@ -115,6 +115,10 @@
https://builds.apache.org/view/A-D/view/Accumulo/
+
org.apache.accumulo.test.cat
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76893649
--- Diff: pom.xml ---
@@ -1001,11 +1004,26 @@
maven-failsafe-plugin
-run-integration-tests
+
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76890217
--- Diff: pom.xml ---
@@ -1001,11 +1004,26 @@
maven-failsafe-plugin
-run-integration-tests
+
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76888767
--- Diff: test/pom.xml ---
@@ -273,5 +275,41 @@
+
+ minicluster-unit-tests
+
+
t
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76888657
--- Diff: pom.xml ---
@@ -1001,11 +1004,26 @@
maven-failsafe-plugin
-run-integration-tests
+
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76887970
--- Diff: test/pom.xml ---
@@ -273,5 +275,41 @@
+
+ minicluster-unit-tests
+
+
tr
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76886952
--- Diff: test/pom.xml ---
@@ -273,5 +275,41 @@
+
+ minicluster-unit-tests
+
+
tr
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76887770
--- Diff: pom.xml ---
@@ -1001,11 +1004,26 @@
maven-failsafe-plugin
-run-integration-tests
+
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76887625
--- Diff: test/pom.xml ---
@@ -273,5 +275,41 @@
+
+ minicluster-unit-tests
+
+
t
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76886561
--- Diff: pom.xml ---
@@ -1001,11 +1004,26 @@
maven-failsafe-plugin
-run-integration-tests
+
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76887503
--- Diff: test/pom.xml ---
@@ -273,5 +275,41 @@
+
+ minicluster-unit-tests
+
+
t
Github user dimaspivak commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76887299
--- Diff: test/pom.xml ---
@@ -273,5 +275,41 @@
+
+ minicluster-unit-tests
+
+
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76887242
--- Diff: pom.xml ---
@@ -1001,11 +1004,26 @@
maven-failsafe-plugin
-run-integration-tests
+
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/144#discussion_r76887031
--- Diff: test/pom.xml ---
@@ -273,5 +275,41 @@
+
+ minicluster-unit-tests
+
+
tr
GitHub user joshelser opened a pull request:
https://github.com/apache/accumulo/pull/144
ACCUMULO-4423 Annotate integration tests with categories
Differentiates tests which always use a minicluster and those
which can use a minicluster or a standalone cluster. Out-of-the-box
43 matches
Mail list logo
