Github user dlmarion closed the pull request at:
https://github.com/apache/accumulo/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r117125225
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
---
@@ -169,25 +170,23 @@ public
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116310180
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
---
@@ -169,25 +170,23 @@ public
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116305691
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116305578
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116305410
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
@@ -135,15 +139,34 @@ public long requestCount() {
}
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116305014
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
---
@@ -169,25 +170,23 @@ public
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116300155
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116299503
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116302991
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
---
@@ -169,25 +170,23 @@ public
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116304148
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCacheManager.java
---
@@ -0,0 +1,48 @@
+/*
+ *
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116300272
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
@@ -135,15 +139,34 @@ public long requestCount() {
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116265855
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116260368
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
@@ -135,16 +142,41 @@ public long requestCount() {
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116251656
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
@@ -135,16 +142,41 @@ public long requestCount() {
}
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116232168
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116231739
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116044162
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CachedBlock.java
---
@@ -19,6 +19,8 @@
import java.util.Objects;
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116045467
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCache.java
---
@@ -99,116 +91,57 @@
private final
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116025738
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -245,7 +245,8 @@
TSERV_PREFIX("tserver.", null, PropertyType.PREFIX,
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116025321
--- Diff:
core/src/main/java/org/apache/accumulo/core/conf/ConfigurationCopy.java ---
@@ -95,4 +95,16 @@ public void set(String key, String value) {
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116042978
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116023101
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
@@ -67,6 +70,7 @@
private static final Range EMPTY_RANGE =
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116022505
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
@@ -135,16 +140,35 @@ public long requestCount() {
}
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116038091
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/tinylfu/TinyLfuBlockCacheFactory.java
---
@@ -0,0 +1,45 @@
+/*
+ *
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116045317
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCache.java
---
@@ -99,116 +91,57 @@
private final
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116037737
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r116030520
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CachedBlock.java
---
@@ -19,6 +19,8 @@
import java.util.Objects;
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115750382
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCacheFactory.java
---
@@ -0,0 +1,43 @@
+/*
+ *
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115748948
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheConfiguration.java
---
@@ -0,0 +1,88 @@
+/*
+ *
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115604124
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -245,7 +245,8 @@
TSERV_PREFIX("tserver.", null,
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115603206
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheConfiguration.java
---
@@ -0,0 +1,92 @@
+/*
+ *
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115597102
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheConfiguration.java
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115581232
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheConfiguration.java
---
@@ -0,0 +1,92 @@
+/*
+ *
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115578473
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheFactory.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115579078
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheFactory.java
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/256#discussion_r115584917
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
@@ -135,16 +142,41 @@ public long requestCount() {
37 matches
Mail list logo
