Review Request 21826: Accumulo-2632

2014-05-22 Thread John McNamee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21826/ --- Review request for accumulo. Repository: accumulo Description --- The go

Re: Review Request 21826: Accumulo-2632

2014-05-22 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21826/#review43764 --- Have you done any benchmarks with these changes? I would think that

Re: Review Request 21826: Accumulo-2632

2014-05-22 Thread Josh Elser
> On May 22, 2014, 8:28 p.m., Josh Elser wrote: > > Have you done any benchmarks with these changes? I would think that you > > should see higher CPU usage with less disk I/O, and, overall, quicker > > ingest. It would be good to see some before and after numbers that show > > this. Oops, sor

Re: Review Request 21826: Accumulo-2632

2014-05-23 Thread Christopher Tubbs
> On May 22, 2014, 4:28 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/conf/Property.java, line 270 > > > > > > Should this be tagged with the @Experimental annotation? I view @Experimental to

Re: Review Request 21826: Accumulo-2632

2014-05-23 Thread Christopher Tubbs
> On May 22, 2014, 4:28 p.m., Josh Elser wrote: > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java, > > line 572 > > > > > > It looks like this sync invocation got dropped. Did I just miss

Re: Review Request 21826: Accumulo-2632

2014-11-24 Thread John McNamee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21826/ --- (Updated Nov. 24, 2014, 1:26 p.m.) Review request for accumulo. Changes -