[GitHub] activemq-artemis pull request: CLI Create command enhancements and...

2015-05-06 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/229 CLI Create command enhancements and fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis master

[GitHub] activemq-artemis pull request: HornetQ Protocol Support

2015-05-06 Thread mtaylor
Github user mtaylor commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99412764 Please hold off merging this for now. @andytaylor has asked me to do some performance testing on the usage of interceptors vs overriding methods in the

[GitHub] activemq-artemis pull request: HornetQ Protocol Support

2015-05-06 Thread andytaylor
Github user andytaylor commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99430232 personally I wouldn't have used Interceptors. Its a level of indirection that isn't really needed. I would just have used abstraction and catch the packets

[GitHub] activemq-artemis pull request: HornetQ Protocol Support

2015-05-06 Thread mtaylor
Github user mtaylor commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99431498 The test consisted of sending a million empty messages 5x, taking average time. The test is in no means 100% accurate as it was running on my dev laptop with

Re: Artemis with License Checks on PR/s build

2015-05-06 Thread Clebert Suconic
So, the poms now have the RAT check enabled. That means we would get our own mistakes instead of wasting server's time resource with a failed PR. I think that's the right way to do it... we wouldn't waste server's time resource on failed PRs... and wouldn't waste anyone's time on looking at PRs

DB persistence with embedded ActiveMQ plugin in WASCE 3.0.0.3(Websphere application server community edition)

2015-05-06 Thread auti.prash...@gmail.com
I am looking to achieve Oracle DB Persistence with embedded ActiveMQ plugin in WASCE 3.0.0.3(Websphere application server community edition). Looking for help to achieve DB persistence through the embedded ActiveMQ plugin. Please let me know, if anyone has tried this earlier, or any pointers for

How do i connect a glassfish server 4 to an external activeMQ 5.11?

2015-05-06 Thread Angel Guerra
I need help with this topic please -- View this message in context: http://activemq.2283324.n4.nabble.com/How-do-i-connect-a-glassfish-server-4-to-an-external-activeMQ-5-11-tp4696155.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

[GitHub] activemq-artemis pull request: Exclude keystore types from RAT che...

2015-05-06 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/230 Exclude keystore types from RAT check You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

Re: Artemis with License Checks on PR/s build

2015-05-06 Thread Andy Taylor
or document how to enable it so users can turn it on if they want On 06/05/15 15:16, Clebert Suconic wrote: The thing is.. we will have more failures on the PR builds.. .I would rather have people getting issues at their code. Perhaps you could just document how to disable on README.. and

Re: Artemis with License Checks on PR/s build

2015-05-06 Thread Timothy Bish
On 05/06/2015 10:24 AM, Andy Taylor wrote: which I think is fine. it doesnt matter for users who are just building from source, its only an issue for contributions which the PR build is there to catch Agreed, the users should be able to work however they are comfortable and let the automation

Re: Artemis with License Checks on PR/s build

2015-05-06 Thread Clebert Suconic
The thing is.. we will have more failures on the PR builds.. .I would rather have people getting issues at their code. Perhaps you could just document how to disable on README.. and make it easy for users to disable it. On Wed, May 6, 2015 at 10:14 AM, Andy Taylor andy.tayl...@gmail.com wrote:

Re: Artemis with License Checks on PR/s build

2015-05-06 Thread Andy Taylor
which I think is fine. it doesnt matter for users who are just building from source, its only an issue for contributions which the PR build is there to catch On 06/05/15 15:21, Clebert Suconic wrote: That's the kind of thing that won't happen.. people will just ignore it On Wed, May 6, 2015

Re: Artemis with License Checks on PR/s build

2015-05-06 Thread Justin Bertram
To be clear, those issues weren't caught because the license check was disabled even on the PR build. If that was enabled we would have caught the issues before the code was merged. - Original Message - From: Clebert Suconic clebert.suco...@gmail.com To: dev@activemq.apache.org Sent:

[GitHub] activemq-artemis pull request: A bunch of commits to fix Maven/bui...

2015-05-06 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/231 A bunch of commits to fix Maven/build stuff You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request: A bunch of commits to fix Maven/bui...

2015-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Artemis with License Checks on PR/s build

2015-05-06 Thread Justin Bertram
I sent PR # 231 [1] to (hopefully) deal with this. The license and checkstyle checks will be on for the the following profiles: -dev - used by developers -tests - used by Jenkins for regression tests, including nightly tests -fast-tests - used to verify pull requests -release - used

[GitHub] activemq-artemis pull request: Fixing examples commons

2015-05-06 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/232 Fixing examples commons Examples/jms/common was wrongly renamed long time ago, commons/prettify was broken and this will fix formatting on the README files You can merge this pull