[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-05-31 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107305686 I've updated my last comment.. I meant, if you need the patch, we will need to refacdtor this somehow it's independent and you should have the code commit

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-05-31 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107302365 ok, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-05-31 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107289228 Just commit the code you need. a patch is not a good solution on moving forward. It's impossible to maintain it. If you don't need the patch, the

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-05-31 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107281546 The code is only for compiling and running the tests to get the result. after that do a 'mvn clean' will get rid of all those codes. --- If your project is s

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-05-31 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107280665 @gaohoward we don't commit the code? why not actually commit the code and carry on? let me talk to you tomorrow about this. --- If your project

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-05-31 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107280602 @gaohoward Howard, just add @Deprecated on those classes.. that's all. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] activemq-artemis pull request: ARTEMIS-127 Adding activemq unit te...

2015-05-31 Thread gaohoward
Github user gaohoward commented on the pull request: https://github.com/apache/activemq-artemis/pull/8#issuecomment-107278310 Hi Clebert, I don't have a good idea as to how to fix this. What the module does is actually download the activmq 5 source code (unit tests, activemq-b

Re: Website & Dist for Artemis 1.0.0 is up

2015-05-31 Thread Andy Taylor
fixed On 30/05/15 07:23, Claus Ibsen wrote: Hi Should Artemis not be listed as a sub-project from the main ActiveMQ web site at http://activemq.apache.org/ On Fri, May 29, 2015 at 7:36 PM, Hiram Chirino wrote: The website is up now at: http://activemq.apache.org/artemis/ If anyone needs to