[GitHub] activemq-artemis pull request: Large message database

2016-05-04 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/502#issuecomment-217053349 @mtaylor I squashed 152e572 into d19a7dd... I preferred using an intermediate branch myself instead of asking you.. I was pretty sure about

[GitHub] activemq-artemis pull request: Large message database

2016-05-04 Thread mtaylor
Github user mtaylor commented on the pull request: https://github.com/apache/activemq-artemis/pull/502#issuecomment-217010719 @clebertsuconic What happened to the last commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Adding support for password masking to the Artemis

2016-05-04 Thread Justin Bertram
That sounds fine. I would expect the PR to also include a test or two (as mentioned previously) plus documentation updates as well. A full blown example (e.g. based on the "security" example) would be nice to have as well. Justin - Original Message - From: "adclayton"

[GitHub] activemq-artemis pull request: More test fixes

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/505 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Adding support for password masking to the Artemis

2016-05-04 Thread adclayton
OK well what I am thinking about is basically adding a nullable property to the PropertiesLoginModule that will allow the user to provide the classpath to an implementation of the org.apache.activemq.artemis.utils.SensitiveDataCodec, so that essentially the login.config would look like the

[GitHub] activemq-artemis pull request: More test fixes

2016-05-04 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/505 More test fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review

[GitHub] activemq-artemis pull request: Switch File Based Large Message Tes...

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request: Test-suite fixes

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request: Test-suite fixes

2016-05-04 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/503#discussion_r62092627 --- Diff: tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/LargeMessageOverReplicationTest.java --- @@

[GitHub] activemq-artemis pull request: Switch File Based Large Message Tes...

2016-05-04 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/504 Switch File Based Large Message Tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis FileLargeMessageTests

[GitHub] activemq-artemis pull request: ARTEMIS-512 fix variable name confl...

2016-05-04 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/503 ARTEMIS-512 fix variable name conflict You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request: Large message database

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Embedded REST - Missing msg-pull-subscriptions when request HEAD

2016-05-04 Thread Justin Bertram
What documentation are you reading? The documentation at http://activemq.apache.org/artemis/docs/1.2.0/rest.html indicates that you will receive this exact kind of response when you send a HEAD request to a queue. The "msg-pull-consumers" and "msg-push-consumers" are what you need to create a

Re: Embedded REST - Missing msg-pull-subscriptions when request HEAD

2016-05-04 Thread Julien d
Hi, I am facing an unexpected issue. As I understand from the documentation I have to register consumers subscribing. However using curl, how could I do that? At the moment when I issue curl --head http://localhost:8081/queues/orders, I obtain as response : HTTP/1.1 200 Ok connection:

[GitHub] activemq-artemis pull request: Large message database

2016-05-04 Thread mtaylor
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/502#discussion_r62008135 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFileFactory.java --- @@ -0,0 +1,255 @@

[GitHub] activemq-artemis pull request: Large message database

2016-05-04 Thread mtaylor
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/502#discussion_r62007801 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaRecoveryTest.java --- @@ -101,7 +101,7 @@