[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples

2016-06-30 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/613 The PR test build fails with: [ERROR] Failed to execute goal on project artemis-web: Could not resolve dependencies for project org.apache.activemq:artemis-web:jar:1.4.0-SNAPSHOT:

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

2016-06-30 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/613 ARTEMIS-602 Fix REST examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis restExamples Alternatively y

[GitHub] activemq-artemis pull request #609: ARTEMIS-555 Allowing examples to be exec...

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/609 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/610 I see how takari set it up now. Based on how this maven-wrapper works, I guess this is how it should be done. I will come up to this after the july-4th (holiday.. and I will

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/610 I will squash it.. it's not needed any longer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 Well its still in the PR - https://github.com/glauciom/activemq-artemis/blob/c84c39abf0c9033a0a3b989dabee9ab12e5f030c/.mvn/wrapper/maven-wrapper.jar --- If your project is set up for it,

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/610 I was afraid of having a binary that we don't control being a dependency directly. Maybe that's not an issue at all.. but anyway Glaucio seems to have fixed it. --- If your project

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @clebertsuconic maybe from your POV. However, from a release standpoint they carry the same problems. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @johnament the libaio binary is different. We produce this binary. just to facilitate the build. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] activemq-artemis pull request #612: [ARTEMIS-603] Remove e.printStackTrace()...

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread glauciom
Github user glauciom commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @johnament just removed .cmd file (whomever which wants windows support, feel free to do it) and now if maven-wrapper.jar is missing, it will be automatically downloaded from mvn central r

[GitHub] activemq-artemis pull request #612: [ARTEMIS-603] Remove e.printStackTrace()...

2016-06-30 Thread treblereel
GitHub user treblereel opened a pull request: https://github.com/apache/activemq-artemis/pull/612 [ARTEMIS-603] Remove e.printStackTrace() from code JIRA: https://issues.apache.org/jira/browse/ARTEMIS-603 You can merge this pull request into a Git repository by running: $ git p

[GitHub] activemq-artemis pull request #611: ARTEMIS-602 fix web.xml examples for RES...

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/611 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @clebertsuconic yep, shouldn't be an issue having it in source, just like the libaio binary. Just need to exclude it from your source release. @glauciom Even though they're under

[GitHub] activemq-artemis pull request #611: ARTEMIS-602 fix web.xml examples for RES...

2016-06-30 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/611 ARTEMIS-602 fix web.xml examples for REST You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alte

[GitHub] activemq-artemis issue #606: More on ARTEMIS-594: support HTTPS access to ha...

2016-06-30 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/606 Thanks @clebertsuconic :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread glauciom
Github user glauciom commented on the issue: https://github.com/apache/activemq-artemis/pull/610 mvnw files and the wrapper itself are under apache license, it seems that looks fine to keep them, I guess. On Thursday, June 30, 2016, John Ament wrote: > The usage o

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @johnament so, its ok to keep the binary committed then? if that's the case I would just add a README on how to update it.. and it needs to be out of the source distro (we c

[GitHub] activemq-artemis pull request #608: ARTEMIS-602 update pom info for REST WAR

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/608 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis issue #606: More on ARTEMIS-594: support HTTPS access to ha...

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/606 @gaohoward nice one howard! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] activemq-artemis pull request #606: More on ARTEMIS-594: support HTTPS acces...

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis pull request #606: More on ARTEMIS-594: support HTTPS acces...

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/606#discussion_r69144653 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java --- @@ -347,6 +361,27 @@ public String getClusterPa

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 The usage of maven-wrapper.jar is fine. You just need to make sure its excluded from your source release (and probably exclude mvnw and mvnw.bat files) https://github.com/takari/

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread glauciom
Github user glauciom commented on the issue: https://github.com/apache/activemq-artemis/pull/610 I will figure that out and will let you know On 30 Jun 2016 11:36, "clebertsuconic" wrote: > The one thing preventing this to be merged is this binary jar. There's no > lic

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/610 The one thing preventing this to be merged is this binary jar. There's no license about it... I don't think I can merge this. Where this came from? what's the license? wouldn

[GitHub] activemq-artemis issue #595: [ARTEMIS-591] Wrong XAException return code whe...

2016-06-30 Thread bayern39
Github user bayern39 commented on the issue: https://github.com/apache/activemq-artemis/pull/595 @clebertsuconic Hi clebert, i have considered your comment,what do you mean is that the RM can only find the old transactions whose lifetime are older than the default transaction timeo