[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread glauciom
Github user glauciom commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69371449 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread glauciom
Github user glauciom commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69371370 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

2016-07-01 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/613#discussion_r69371083 --- Diff: examples/features/standard/rest/dup-send/README.txt --- @@ -1,5 +1,5 @@ System Requirements: -You will need JDK 1.6 and Maven to

[GitHub] activemq-artemis pull request #614: ARTEMIS-606 JMSServerControl2Test#testCl...

2016-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #615: ARTEMIS-598 fix native logger code

2016-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/615 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

2016-07-01 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/613#discussion_r69366595 --- Diff: examples/features/standard/rest/javascript-chat/README.txt --- @@ -1,5 +1,5 @@ System Requirements: -You will need JDK

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

2016-07-01 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/613#discussion_r69366570 --- Diff: examples/features/standard/rest/dup-send/README.txt --- @@ -1,5 +1,5 @@ System Requirements: -You will need JDK 1.6 and

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69366465 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69366049 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 +

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69358896 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8

[GitHub] activemq-artemis pull request #616: Various cleanups

2016-07-01 Thread scop
GitHub user scop opened a pull request: https://github.com/apache/activemq-artemis/pull/616 Various cleanups You can merge this pull request into a Git repository by running: $ git pull https://github.com/scop/activemq-artemis cleanups Alternatively you can review and apply

[GitHub] activemq-artemis pull request #615: ARTEMIS-598 fix native logger code

2016-07-01 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/615 ARTEMIS-598 fix native logger code You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-598

[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples

2016-07-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/613 I sorted the dependency issue out, and I also ran the PR check on my local machine since the Apache CI seems to be flaky right now. It passed. --- If your project is set up for it, you

[GitHub] activemq-artemis pull request #614: ARTEMIS-606 JMSServerControl2Test#testCl...

2016-07-01 Thread dudaerich
GitHub user dudaerich opened a pull request: https://github.com/apache/activemq-artemis/pull/614 ARTEMIS-606 JMSServerControl2Test#testCloseConsumerConnectionsForAddr… …essForInVM fails Based on log it is clear that the connection was closed by Finalizer before the

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread glauciom
Github user glauciom commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69282938 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69260647 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8