[GitHub] activemq-artemis pull request #652: ARTEMIS-645 ClusteredGroupingTest fails

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/652 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis pull request #658: ARTEMIS-651 Typo in word "topology" in c...

2016-07-25 Thread MartinStyk
GitHub user MartinStyk opened a pull request: https://github.com/apache/activemq-artemis/pull/658 ARTEMIS-651 Typo in word "topology" in class ServerLocatorImpl See Artemis Jira [ARTEMIS-651](https://issues.apache.org/jira/browse/ARTEMIS-651) You can merge this pull request into a

[GitHub] activemq-artemis issue #658: ARTEMIS-651 Typo in word "topology" in class Se...

2016-07-25 Thread MartinStyk
Github user MartinStyk commented on the issue: https://github.com/apache/activemq-artemis/pull/658 Check failed with: AMQ224000: Failure in initialisation: java.net.BindException: Address already in use It is not related to this PR --- If your project is set up for it, you can re

[GitHub] activemq-artemis issue #658: ARTEMIS-651 Typo in word "topology" in class Se...

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/658 thanks, will merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] activemq-artemis pull request #659: ARTEMIS-653 Possible Null Pointer Except...

2016-07-25 Thread MartinStyk
GitHub user MartinStyk opened a pull request: https://github.com/apache/activemq-artemis/pull/659 ARTEMIS-653 Possible Null Pointer Exception during message properties… … read using XmlDataImporter Create SimpleString object only if value of attribute is not null You ca

[GitHub] activemq-artemis pull request #653: ARTEMIS-548 Stomp durable sub unsubscrbe

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis pull request #654: ARTEMIS-413 doc for Stomp durable subs

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis pull request #660: ARTEMIS-652 Incorrect null check in Acti...

2016-07-25 Thread MartinStyk
GitHub user MartinStyk opened a pull request: https://github.com/apache/activemq-artemis/pull/660 ARTEMIS-652 Incorrect null check in ActiveMQActivationSpec#toString f… …or attribute connectionFactoryLookup Changed null check to check correct attribute You can merge thi

[GitHub] activemq-artemis pull request #655: Fix ByteBuffer regression from Netty upg...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/655 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis pull request #657: ARTEMIS-650 clarify doc, use TTL default...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/657 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

ActiveMq Publish Message timestamp

2016-07-25 Thread Tejasvi Dev
Hi Guys, I am new to ActiveMq and there is one thing that i had noticed. When i open the web console for the broker, i could see the time-stamp of each message corresponding to each queue but when i open the topic, i just see the topic and the number of messages enqueue/dequeue. I am trying to und

[GitHub] activemq-artemis pull request #658: ARTEMIS-651 Typo in word "topology" in c...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis pull request #661: ARTEMIS-628 Adding back old constructor ...

2016-07-25 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/661 ARTEMIS-628 Adding back old constructor for API compatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/ac

[GitHub] activemq-artemis pull request #660: ARTEMIS-652 Incorrect null check in Acti...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis pull request #659: ARTEMIS-653 Possible Null Pointer Except...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/659 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @johnament this looks good to me. Are you done here? Can I merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] activemq-artemis pull request #661: ARTEMIS-628 Adding back old constructor ...

2016-07-25 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/661#discussion_r72120144 --- Diff: README.md --- @@ -44,4 +44,7 @@ If you are trying to copy the examples somewhere else and modifying them. Consid # if trying to

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 you can't run a server. There is some changes needed on the release packaging: ``` Exception in thread "main" java.lang.NoClassDefFoundError: javax/json/JsonValue

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 Ah good catch. I can fix that, probably some assembly issues. I'm assuming shipping johnzon as the default is fine? --- If your project is set up for it, you can reply to this email an

Information about a bug

2016-07-25 Thread Chalaka Chamupathi Sudusinghe
Hello, I start looking issue https://issues.apache.org/jira/browse/ARTEMIS-272. I am new to this, is this issue still a valid one it is from year 2015 , And where can i find information about interceptor tests. -- Thanks and Regards, Chalaka Chamupathi Sudusinghe Undergraduate at University

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 Looks fine to me. I reversed engineered the code and I'm not sure how you specify the JSON provider. it seems you need something on the CLASSINFO? Also, I just reali

[GitHub] activemq-artemis pull request #640: ARTEMIS-565 Replace json.org with javax....

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/640#discussion_r72123060 --- Diff: pom.xml --- @@ -436,6 +436,17 @@ ${slf4j.version} + +

[GitHub] activemq-artemis pull request #640: ARTEMIS-565 Replace json.org with javax....

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/640#discussion_r72123156 --- Diff: pom.xml --- @@ -436,6 +436,17 @@ ${slf4j.version} + +

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @johnament how users doing embedded will use json? anything special they have to do? or just the maven dependencies would catch it? --- If your project is set up for it, you can rep

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @clebertsuconic yes, once i fix the distribution the johnzon one will ship by default. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] activemq-artemis pull request #661: ARTEMIS-628 Adding back old constructor ...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @johnament I was thinking about embedded cases (using the library direct), like wildfly. We can fix whatever needs on wildfly for next versions.. so I was really thinking ab

[GitHub] activemq-artemis pull request #640: ARTEMIS-565 Replace json.org with javax....

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/640#discussion_r72123081 --- Diff: pom.xml --- @@ -436,6 +436,17 @@ ${slf4j.version} + +

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/662 ARTEMIS-587 add more JSON JMX mgmt methods to core You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @clebertsuconic oh, for wildfly, you'll need to add dependencies on `javax.json.api` and `org.glassfish.javax.json` modules. As far as plain library usage, the dependency tree sho

[GitHub] activemq-artemis issue #645: Fix scaledownhandler lookup duplicate handling

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/645 @andytaylor can you comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @johnament cool.. thanks a lot. And sorry for my delay on this. was in vacations last week. :) --- If your project is set up for it, you can reply to this email and have your re

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72125621 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -1360,6 +1359,130 @

Re: Information about a bug

2016-07-25 Thread Justin Bertram
I suppose the issue is still valid. I believe the issue is that a test needs to be added to validate the functionality added in ARTEMIS-271. Therefore, in order to resolve this issue you need to understand the functionality added in ARTEMIS-271. If you need additional details you can follow-up h

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72130781 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -1360,6 +1359,130 @@

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 No problems @clebertsuconic hope it went well. I pushed up fixes, one oddity is that when starting the broker I get this on the console... ``` 20:50:26,422 INFO [org

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I just checked. its happening with my changes. I can't find this log message anywhere though. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/640 You need to rebase. That issue was resolved last week I believe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I checked your commit and it was ok. (I always use this script to merge PRs which will always rebase them, that's probably why it was ok)... https://github.com/apache/act

[GitHub] activemq-artemis pull request #640: ARTEMIS-565 Replace json.org with javax....

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/640 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I included 2 lines change features.xml towards the OSGI bundle and I squashed into your commit. I hope you won't mind. It was easier this way. --- If your project is set up for it,

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @johnament can you assign this JIRA to yourself? I couldn't find you (don't know why): https://issues.apache.org/jira/browse/ARTEMIS-565 --- If your project is set up for i

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I pinged the PMC to add me as contributor. That will allow JIRA assignment. I must have had something cached, as this was after I rebased. --- If your project is set up for it,

[GitHub] activemq-artemis issue #662: ARTEMIS-587 add more JSON JMX mgmt methods to c...

2016-07-25 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/662 I rebased this on John's recent JSON changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72180014 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSServerControlImpl.java --- @@ -796,20 +796,12 @@ pu