[GitHub] activemq-artemis pull request #1144: ARTEMIS-1078: Improved thread pool

2017-03-28 Thread bgutjahr
Github user bgutjahr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1144#discussion_r108594658 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java --- @@ -46,32 +45,70 @@ privat

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 Actually the test failing contradicts the test you added on openwire/MQTT... so I will just remove the test... --- If your project is set up for it, you can reply to this email and

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 @dejanb I'm fixing a test here, accordingly to a bisect it was broken at 21b64b3... Your change was correct.. so I'm not sure if the test is invalid.. or if there's somethi

[GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

2017-03-28 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1150 NO-JIRA Fixing testReceiveWildcardTopicMatchDoubleWildcard Fixing JmsTopicWildcardSendReceiveTest::testReceiveWildcardTopicMatchDoubleWildcard Accordingly to bisect, this

[GitHub] activemq-artemis pull request #1148: [1.x] ARTEMIS-1074 Acceptors/Connectors...

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1134: ARTEMIS-1071 Invalid Type exception han...

2017-03-28 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1134#discussion_r108575576 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/JMSTestBase.java --- @@ -197,21 +198,33 @@ protected voi

[GitHub] activemq-artemis pull request #1147: Fixing tests

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1149: ARTEMIS-1065 get queue names by routing...

2017-03-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1149 ARTEMIS-1065 get queue names by routing type You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1065

[GitHub] activemq-artemis pull request #1134: ARTEMIS-1071 Invalid Type exception han...

2017-03-28 Thread yourcaptain
Github user yourcaptain commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1134#discussion_r108573779 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/JMSTestBase.java --- @@ -197,21 +198,33 @@ protected v

[GitHub] activemq-artemis pull request #1134: ARTEMIS-1071 Invalid Type exception han...

2017-03-28 Thread yourcaptain
Github user yourcaptain commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1134#discussion_r108573033 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/JMSTestBase.java --- @@ -197,21 +198,33 @@ protected v

[GitHub] activemq-artemis pull request #1134: ARTEMIS-1071 Invalid Type exception han...

2017-03-28 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1134#discussion_r108572088 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java --- @@ -626,7 +626,12 @@

[GitHub] activemq-artemis pull request #1148: [1.x] ARTEMIS-1074 Acceptors/Connectors...

2017-03-28 Thread roelens8
GitHub user roelens8 opened a pull request: https://github.com/apache/activemq-artemis/pull/1148 [1.x] ARTEMIS-1074 Acceptors/Connectors now start up when configured to use SSL and a password codec (cherry picked from commit 3ceb3328664e3dfa1dbeb24bad45115e2f1970c4) Refer t

[GitHub] activemq-artemis issue #1139: ARTEMIS-1074 Acceptors/Connectors now start up...

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1139 Sure. If u could use git cheepick -x please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] activemq-artemis pull request #1146: ARTEMIS-1064 AddressControl routingType...

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis issue #1139: ARTEMIS-1074 Acceptors/Connectors now start up...

2017-03-28 Thread roelens8
Github user roelens8 commented on the issue: https://github.com/apache/activemq-artemis/pull/1139 Could we put up a PR to merge this fix into the 1.X branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis pull request #1144: ARTEMIS-1078: Improved thread pool

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1144#discussion_r108526952 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java --- @@ -46,32 +45,70 @@

[GitHub] activemq-artemis pull request #1147: ARTEMIS-1056 fixing tests

2017-03-28 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1147 ARTEMIS-1056 fixing tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis improv Alternativel

[GitHub] activemq-artemis pull request #1144: ARTEMIS-1078: Improved thread pool

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1144#discussion_r108526825 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java --- @@ -46,32 +45,70 @@

[GitHub] activemq-artemis issue #1145: ARTEMIS-1079 CLI option for paging/blocking

2017-03-28 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1145 Will do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] activemq-artemis pull request #1139: ARTEMIS-1074 Acceptors/Connectors now s...

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1146: ARTEMIS-1064 AddressControl routingType...

2017-03-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1146 ARTEMIS-1064 AddressControl routingType fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1064

[GitHub] activemq-artemis pull request #1141: ARTEMIS-1056 Improving Proton usage

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis issue #1141: ARTEMIS-1056 Improving Proton usage

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1141 @tabish121 thanks.. done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] activemq-artemis issue #1141: ARTEMIS-1056 Improving Proton usage

2017-03-28 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1141 Checkstyle is asking you for some more work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] activemq-artemis pull request #1139: ARTEMIS-1074 Acceptors/Connectors now s...

2017-03-28 Thread roelens8
Github user roelens8 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1139#discussion_r108497183 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java --- @@ -139,8 +140,12 @@ private void

[GitHub] activemq-artemis issue #1145: ARTEMIS-1079 CLI option for paging/blocking

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1145 @jbertram can you add one little thing? can you ask what is the max global size? add something like (we recommend half of your JVM memory) --- If your project is s

[GitHub] activemq-artemis issue #1145: ARTEMIS-1079 CLI option for paging/blocking

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1145 default = 100M (in case user press enter) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] activemq-artemis pull request #1139: ARTEMIS-1074 Acceptors/Connectors now s...

2017-03-28 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1139#discussion_r108480518 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java --- @@ -139,8 +140,12 @@ private void

[GitHub] activemq-artemis pull request #1139: ARTEMIS-1074 Acceptors/Connectors now s...

2017-03-28 Thread roelens8
Github user roelens8 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1139#discussion_r108471873 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java --- @@ -20,6 +20,8 @@ import jav

[GitHub] activemq-artemis pull request #1134: ARTEMIS-1071 Invalid Type exception han...

2017-03-28 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1134#discussion_r108462405 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java --- @@ -626,7 +626,12 @@ p

[GitHub] activemq-artemis pull request #1145: ARTEMIS-1079 CLI option for paging/bloc...

2017-03-28 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1145 ARTEMIS-1079 CLI option for paging/blocking You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work A

[GitHub] activemq-artemis pull request #1143: ARTEMIS-1077 Fixing Pool usage on InVM ...

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1142: ARTEMIS-1075 - Add Routing Type to Queu...

2017-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis issue #1141: ARTEMIS-1056 Improving Proton usage

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1141 @tabish121 nice! don't merge this yet.. I am making one final adjustment. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] activemq-artemis issue #1141: ARTEMIS-1056 Improving Proton usage

2017-03-28 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1141 At first look this does improve things quite a bit, consumer performance now seems to track with producer performance in my tests --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis pull request #1144: ARTEMIS-1078: Improved thread pool

2017-03-28 Thread bgutjahr
GitHub user bgutjahr opened a pull request: https://github.com/apache/activemq-artemis/pull/1144 ARTEMIS-1078: Improved thread pool The improved thread pool make sure that only those threads that are currently waiting in queue poll or take calls are considered idle and ready to run

[GitHub] activemq-artemis pull request #1143: ARTEMIS-1077 Fixing Pool usage on InVM ...

2017-03-28 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1143 ARTEMIS-1077 Fixing Pool usage on InVM and RemotingConnection You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/a

[GitHub] activemq-artemis pull request #1139: ARTEMIS-1074 Acceptors/Connectors now s...

2017-03-28 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1139#discussion_r108424112 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java --- @@ -20,6 +20,8 @@ import jav

[GitHub] activemq-artemis pull request #1140: ARTEMIS-1056 Better event processing

2017-03-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1140#discussion_r108422248 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java ---

[GitHub] activemq-artemis pull request #1140: ARTEMIS-1056 Better event processing

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1140#discussion_r108418250 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java --

[GitHub] activemq-artemis issue #1119: ARTEMIS-1025 OutOfDirectMemoryError raised fro...

2017-03-28 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1119 @clebertsuconic @jbertram Thanks guys! Np @clebertsuconic , another couple of eyes on it will be more than welcome: it is a impactful change hence better have more than my 4 eyes on i

[GitHub] activemq-artemis pull request #1140: ARTEMIS-1056 Better event processing

2017-03-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1140#discussion_r108396438 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java ---

[GitHub] activemq-artemis pull request #1140: ARTEMIS-1056 Better event processing

2017-03-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1140#discussion_r108398829 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java ---

[GitHub] activemq-artemis pull request #1138: ARTEMIS-1073 Adding configuration for P...

2017-03-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1138#discussion_r108394675 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/amqp-acceptor.txt --- @@ -1,3 +1,3 @@

[GitHub] activemq-artemis pull request #1138: ARTEMIS-1073 Adding configuration for P...

2017-03-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1138#discussion_r108394942 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml --- @@ -61,10 +61,13 @@ ${ping-config.settings

[GitHub] activemq-artemis pull request #1142: ARTEMIS-1075 - Add Routing Type to Queu...

2017-03-28 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1142 ARTEMIS-1075 - Add Routing Type to QueueControl management API https://issues.apache.org/jira/browse/ARTEMIS-1075 You can merge this pull request into a Git repository by running: