[GitHub] activemq-artemis pull request #1392: NO-JIRA fix few typos and a docstring

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: Non Durable Queue Cleanup

2017-07-11 Thread Michael André Pearce
Just a little more digging, it seems when two separate topic subscriptions are made, one of the queues is made durable, and the other is not, even so both should be not durable, seems to occur on both core and amqp client. No idea how this could be still, any pointers of code to check or put bre

Re: Non Durable Queue Cleanup

2017-07-11 Thread Michael André Pearce
Ignore the last comment, its not true, i just can’t read a simple log line. but alas still stumped. > On 11 Jul 2017, at 19:47, Michael André Pearce > wrote: > > Just a little more digging, it seems when two separate topic subscriptions > are made, one of the queues is made durable, and the o

[GitHub] activemq-artemis pull request #1395: ARTEMIS-1269 Simple Actor

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: Non Durable Queue Cleanup

2017-07-11 Thread Michael André Pearce
We have been connecting both amqp (jms) and core clients connected to the address. We have shutdown all, yet an amount of queues remain. We have checked the connected consumers = 0 and the queues that remain are def non durables. Sent from my iPhone > On 11 Jul 2017, at 17:28, Andy Taylor

Re: Non Durable Queue Cleanup

2017-07-11 Thread Andy Taylor
Depends on the protocol Michael, which client are you using when you see this occur? On 11 July 2017 at 16:35, Michael André Pearce wrote: > Hi All, > > I'm trying to find the logic that cleans up non durable queues (jms topic > subscription). > > I can find logic with regards to auto created an

Non Durable Queue Cleanup

2017-07-11 Thread Michael André Pearce
Hi All, I'm trying to find the logic that cleans up non durable queues (jms topic subscription). I can find logic with regards to auto created and auto delete where message count == 0. But nothing with regards to specific logic to clear up non durables. Reason I'm asking is we are seeing non

[GitHub] activemq-artemis pull request #1394: ARTEMIS-1268 Fix LargeMessages over STO...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1396: ARTEMIS-1277 - purgeOnNoConsumer is not...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: [DISCUSS] Replacing Executor by a new Actor on ServerSessionHandler

2017-07-11 Thread Clebert Suconic
On Tue, Jul 11, 2017 at 12:06 AM, Michael André Pearce wrote: > Always helps to fully read the PR code, not just the snippet in the email. > > It still is thread handing off, as such ignore my previous comment, and +1 to > the general idea. > > Just one other question: > > "why not use an existin

[GitHub] activemq-artemis pull request #1397: ARTEMIS-1274 MultipleProducersTest.wron...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1397 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] activemq-artemis pull request #1397: ARTEMIS-1274 MultipleProducersTest.wron...

2017-07-11 Thread dudaerich
GitHub user dudaerich opened a pull request: https://github.com/apache/activemq-artemis/pull/1397 ARTEMIS-1274 MultipleProducersTest.wrongQueue fails (cherry picked from commit ab92306d81df10e6cfdc771973b39980721a6f98) You can merge this pull request into a Git repository by running

[GitHub] activemq-artemis issue #1395: ARTEMIS-1269 New actor framework

2017-07-11 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1395 I don't want to make a framework. This is just to diminish GC on a few executors. Instead of creating a new runnable everybtime we pass in the data. --- If your

[GitHub] activemq-artemis pull request #1396: ARTEMIS-1277 - purgeOnNoConsumer is not...

2017-07-11 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1396 ARTEMIS-1277 - purgeOnNoConsumer is not working properly make sure rollback doesn't add messages back https://issues.apache.org/jira/browse/ARTEMIS-1277 You can merge this pul

[GitHub] activemq-artemis issue #1395: ARTEMIS-1269 New actor framework

2017-07-11 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1395 @clebertsuconic I have two comments on this. Firstly, what is the goal of this patch. Is the aim to reduce the GC overhead by reusing Runnables? If so surely this could be done

[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

2017-07-11 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1393#discussion_r126614869 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java --- @@ -300,7 +300,7 @@ public sy