[GitHub] activemq-artemis pull request #1585: NO-JIRA docs clarification of divert po...

2017-10-12 Thread michalxo
GitHub user michalxo opened a pull request: https://github.com/apache/activemq-artemis/pull/1585 NO-JIRA docs clarification of divert position in broker.xml file You can merge this pull request into a Git repository by running: $ git pull https://github.com/michalxo/activemq-a

[GitHub] activemq-artemis issue #1576: ARTEMIS-1447 JDBC NodeManager to support JDBC ...

2017-10-12 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1576 @franz1981 I think using a single class to hold the database statements is fine. Splitting this up into several classes would mean that every provider would have to override 3 or 4 classe

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread Matze2
Github user Matze2 commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 I tried the latest snapshot with an AmqpInterceptor implementation. This does not work. ``` @Override public boolean intercept(final AMQPMessage message, RemotingConnecti

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread Matze2
Github user Matze2 commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 Ignore my last message. I was irritated by the pull request title containing the word "interceptor". The JIRA issue is named differently. ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 I think the snapshot wasn’t updated yet. ---

[GitHub] activemq-artemis issue #1576: ARTEMIS-1447 JDBC NodeManager to support JDBC ...

2017-10-12 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1576 @mtaylor @clebertsuconic > I think using a single class to hold the database statements is fine. Agree! >Another note. I haven't checked these statements work with D

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread Matze2
Github user Matze2 commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 I was not even aware that there is somewhere a binary snapshot to download. I compiled it myself (had to add servlet-api dependency to artemis-rest module to be able to build it).

[GitHub] activemq-artemis issue #1576: ARTEMIS-1447 JDBC NodeManager to support JDBC ...

2017-10-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1576 As long as you don't keep semantics within the statements it's fine... just use prepared statements... there are way too many statements created for all the state possible combinati

[GitHub] activemq-artemis issue #1576: ARTEMIS-1447 JDBC NodeManager to support JDBC ...

2017-10-12 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1576 @clebertsuconic @mtaylor I'm already using prepared statements with different parameters but each row id can have only one meaning (live lock, backup lock,nodeId and state) hence it's b

[GitHub] activemq-artemis issue #1576: ARTEMIS-1447 JDBC NodeManager to support JDBC ...

2017-10-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1576 @franz1981 the ActiveMQScheduledComponent was a suggestion BTW.. do what's right.. even if we need to refactor later... if you make the impl easier to understand it's fine.

[GitHub] activemq-artemis issue #1576: ARTEMIS-1447 JDBC NodeManager to support JDBC ...

2017-10-12 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1576 @clebertsuconic I probably need to do just a little change on that component (ie: customize the initial delay) but the implementation now is simpler to be read/maintained. It was a good

[GitHub] activemq-artemis issue #1585: NO-JIRA docs clarification of divert position ...

2017-10-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1585 thanks! ---

[GitHub] activemq-artemis pull request #1585: NO-JIRA docs clarification of divert po...

2017-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1585 ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 @Matze2 the broker plugin is basically intercepting the message. I used the term out of the concept instead of the class name. ---