[GitHub] activemq-artemis issue #1576: ARTEMIS-1447 JDBC NodeManager to support JDBC ...

2017-10-16 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1576 @franz1981 you're using your own Pool Infrastructure.. differently than what Martyn used? did you check what @mtaylor used here? Also: I see an issue with threads.. if

[GitHub] activemq-artemis pull request #1587: ARTEMIS-1366 Hide Advisory Address from...

2017-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1587 ---

[GitHub] activemq-artemis pull request #1589: ARTEMIS-1456 use queue name when null a...

2017-10-16 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1589 ARTEMIS-1456 use queue name when null address on createQueue You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artem

[GitHub] activemq-artemis pull request #1586: ARTEMIS-1462 Allow ActiveMQScheduledCom...

2017-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1586 ---

[GitHub] activemq-artemis pull request #1588: ARTEMIS-1463 - add role based authentic...

2017-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1588 ---

[GitHub] activemq-artemis pull request #1588: ARTEMIS-1463 - add role based authentic...

2017-10-16 Thread andytaylor
Github user andytaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1588#discussion_r144866130 --- Diff: artemis-server/pom.xml --- @@ -53,6 +53,11 @@ org.apache.activemq + artemis-boot

[GitHub] activemq-artemis pull request #1588: ARTEMIS-1463 - add role based authentic...

2017-10-16 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1588#discussion_r144864790 --- Diff: artemis-server/pom.xml --- @@ -53,6 +53,11 @@ org.apache.activemq + artemis-boot

[GitHub] activemq-artemis issue #1588: ARTEMIS-1463 - add role based authentication t...

2017-10-16 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1588 ok.. will merge it then ---

[GitHub] activemq-artemis issue #1588: ARTEMIS-1463 - add role based authentication t...

2017-10-16 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1588 jaxb expects it to be in the same package or it doesnt compile then. I can restructure this later ---

[GitHub] activemq-artemis issue #1588: ARTEMIS-1463 - add role based authentication t...

2017-10-16 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1588 on the dto package, I would create a sub package for this new stuff... say... security... I would move what's in there (later or now) to a package apps... or some other nam

[GitHub] activemq-artemis pull request #1588: ARTEMIS-1463 - add role based authentic...

2017-10-16 Thread andytaylor
Github user andytaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1588#discussion_r144853262 --- Diff: artemis-cli/pom.xml --- @@ -35,6 +35,11 @@ org.apache.activemq + artemis-boot --- E

[GitHub] activemq-artemis pull request #1588: ARTEMIS-1463 - add role based authentic...

2017-10-16 Thread andytaylor
Github user andytaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1588#discussion_r144853104 --- Diff: artemis-cli/pom.xml --- @@ -35,6 +35,11 @@ org.apache.activemq + artemis-boot --- E

[GitHub] activemq-artemis pull request #1588: ARTEMIS-1463 - add role based authentic...

2017-10-16 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1588#discussion_r144852919 --- Diff: artemis-cli/pom.xml --- @@ -35,6 +35,11 @@ org.apache.activemq + artemis-boot -

[GitHub] activemq-artemis pull request #1588: ARTEMIS-1463 - add role based authentic...

2017-10-16 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1588 ARTEMIS-1463 - add role based authentication to the JMX objects This is done by creating a guard and using JAAS to check for access to mbean objects and their methods. NB this

[GitHub] activemq-artemis pull request #1587: ARTEMIS-1366 Hide Advisory Address from...

2017-10-16 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1587 ARTEMIS-1366 Hide Advisory Address from Management Console Openwire consumer is listed twice below "consumers" tab. First it shows correctly the requested queue consume. Second i