[GitHub] activemq-artemis issue #1741: NO-JIRA Diverts: updated doc & tests with orig...

2018-01-04 Thread art-licis
Github user art-licis commented on the issue: https://github.com/apache/activemq-artemis/pull/1741 Done. ---

[GitHub] activemq-artemis pull request #1740: ARTEMIS-1181 Fix broken links in user-m...

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1740 ---

[GitHub] activemq-artemis issue #1748: ARTEMIS-1576 anon AMQP producer creates addres...

2018-01-04 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1748 Nice find. LGTM. ---

[GitHub] activemq-artemis issue #1741: NO-JIRA Diverts: updated doc & tests with orig...

2018-01-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1741 Can you squash these two commits together? They appear very closely related. ---

[GitHub] activemq-artemis issue #1750: ARTEMIS-1581 fix handshake-timeout property co...

2018-01-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1750 GitHub is reporting that this branch has conflicts. Also it would be worth adding a test here to verify the fix since none of the existing tests caught it. ---

[GitHub] activemq-artemis pull request #1743: ARTEMIS-1575 configure custom broker pl...

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1743 ---

[GitHub] activemq-artemis pull request #1746: ARTEMIS-1572 UTF-8 Encoding is not tran...

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1746 ---

[GitHub] activemq-artemis issue #1715: ARTEMIS-1548 Support CRL

2018-01-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1715 Rather than go back and forth on this again and again I just modified your commit and then squashed my modifications before I merged. Modifications include: * Changing example d

[GitHub] activemq-artemis pull request #1715: ARTEMIS-1548 Support CRL

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1715 ---

[GitHub] activemq-artemis issue #1743: ARTEMIS-1575 configure custom broker plugins w...

2018-01-04 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1743 @pgfox great stuff! LGTM, will look to merge for you tonight/tomorrow, pending no further comments from anyone else. Thanks for the contribution. re the tools schema, ye

[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...

2018-01-04 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1750 ARTEMIS-1581 fix handshake-timeout property configurability You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-ar

[GitHub] activemq-artemis pull request #1749: ARTEMIS-1579 browsing messages in hawti...

2018-01-04 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1749 ARTEMIS-1579 browsing messages in hawtio console You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis E899

[GitHub] activemq-artemis issue #1744: [ARTEMIS-1577] Address-settings policies aren'...

2018-01-04 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1744 @shailendra14k if you step through the code and as i highlighted the ActiveMQPacketHandler is setting this when the session is made and the client version is pre-addressing chan

[GitHub] activemq-artemis issue #1744: [ARTEMIS-1577] Address-settings policies aren'...

2018-01-04 Thread shailendra14k
Github user shailendra14k commented on the issue: https://github.com/apache/activemq-artemis/pull/1744 @michaelandrepearce Yes, I tested on the latest master as fas as I remember, will retest it again. >>removePrefix only operates if prefix's are enabled for that session: Doe

[GitHub] activemq-artemis issue #1744: [ARTEMIS-1577] Address-settings policies aren'...

2018-01-04 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1744 @shailendra14k just going through the code around the producer credits you mentioned (my inquisitiveness got the better of me) It looks like this is possibly fixed maybe

[GitHub] activemq-artemis issue #1747: [WIP] NO-JIRA DISCUSS Replica use operationcon...

2018-01-04 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1747 Michael is correct, that's what I meant. Let me explain how this works. Every record that is written to the journal is also sent to the backup. Once the backup receives the

[GitHub] activemq-artemis issue #1743: ARTEMIS-1575 configure custom broker plugins w...

2018-01-04 Thread pgfox
Github user pgfox commented on the issue: https://github.com/apache/activemq-artemis/pull/1743 @michaelandrepearce suggested changes made. I defined an element "property" around the complex type and reused it in both places. The element definition baked in the naming conven

[GitHub] activemq-artemis issue #1744: [ARTEMIS-1577] Address-settings policies aren'...

2018-01-04 Thread shailendra14k
Github user shailendra14k commented on the issue: https://github.com/apache/activemq-artemis/pull/1744 @michaelandrepearce thank you for the update, I will try to include this at the protocol level. ---

[GitHub] activemq-artemis issue #1744: [ARTEMIS-1577] Address-settings policies aren'...

2018-01-04 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1744 My view on this is that this is for back compatibility with 1.5.X clients and should be done at protocol handling levels (not within core guts). As Clebert has done for other ba

[GitHub] activemq-artemis issue #1744: [ARTEMIS-1577] Address-settings policies aren'...

2018-01-04 Thread shailendra14k
Github user shailendra14k commented on the issue: https://github.com/apache/activemq-artemis/pull/1744 @michaelandrepearce, Most the places what I observed is prefixes are removed like:- artemis-core-client:- QueueAbstractPacket class while getting the address prefix are remo