Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1847
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1847
ARTEMIS-1658 Add prefix option to ActivationSpec
Checkstyle fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandr
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
Here is a much more complete sample, i would be expecting to see (this is
what i was meaning in the original PR comment on: #1793)
```
/**
* Licensed to the Apa
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
Copied from example i gave originally:
https://github.com/apache/activemq-artemis/pull/1793
e.g. along this line.
public class OpenwireMessage extends RefCountM
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@RaiSaurabh @franz1981 I just got some perf results back on this, and its
not pretty. (i retract my prev comments (i deleted)
After looking again it seems like all this
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1846
Avoid NPE when setting null address
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alternati
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@franz1981 im happy to do the merge, but i would like a thumbs up from you
before i do.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@RaiSaurabh looks really good to me, as noted by @franz1981 there is quite
a few bits to optimise, but i personally would prefer we merge this (as long as
no functional regressi
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165769403
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConve
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165768988
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165768705
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverte
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165768314
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverte
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165767867
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConve
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1845
ARTEMIS-1632 add PropertyPermission for test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1632
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1844
ARTEMIS-1645 fix test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1645
Alternatively you can
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1843
---
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1843
ARTEMIS-1658 Add prefix option to ActivationSpec
Artemis 1.x RA would do a core queue lookup if it could not find the
Destination in JNDI. We need to ensure that we can support the ol
Github user franz1981 closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1842
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1842
It is broking some test.. I will close it for now :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1842
Do not merge it yet: need to run the OpenWire compatibility tests
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1842
ARTEMIS-1656 OpenWire scalability improvements
The improvements included are:
- exclusive OpenWireFormat instances for input/output message paths
- direct ByteBuf pooling for mes
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1827#discussion_r165706644
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java
---
@@ -38,6 +38,10 @@ public static
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1838
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1836
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1840
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1841
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1836
A.. that's why the compatibility tests are generating so many tmp
files.. thanks!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1834
@rpahli, it would be appropriate to add the link to the documentation.
---
Github user nlippke commented on the issue:
https://github.com/apache/activemq-artemis/pull/1822
@michaelandrepearce, @franz1981 Done.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1840
Updated PR as I found a second spot where the ref counter needed to be
decremented
---
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/commit/22311333dc19a6a76f377530b03f75eef5c186cc#commitcomment-27291689
In
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/Topology.java:
In
artemis-core
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/22311333dc19a6a76f377530b03f75eef5c186cc#commitcomment-27291597
In
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/Topology.java:
In
artemis-
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1841
@franz1981 this replaces the previous PR, actually fixing the source of the
issue.
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1841
ARTEMIS-1655 Fix TransportConfiguration encode failing
Check for null on isMaskPassword, seems this regressed in
bb84f679363f62e8b2663f63bf23f04133de481d change for ARTEMIS-160
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1840
ARTEMIS-1657 - Properly decrement memory usage when moving messages
When messages are retried and moved froma DLQ to the original queue the
memory usage tracker needs to be decre
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165608418
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1839
@franz1981 if you want to have the honor Iâm more than happy letting you
merge :)
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1839
@michaelandrepearce As soon as the checks will pass (if jenkins behave
normally!!) I will merge it :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1839
@michaelandrepearce If it ok I will going to merge it or you do it by
yourself?
---
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1839
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1832
@michaelandrepearce @gtully @mtaylor If everything is fine I will going to
merge it, ok?
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165609280
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessagePersister.java
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1839
@franz1981 can you just wait actually, ive jsut seen something, i want to
recheck.
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165606383
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1839
ARTEMIS-1655 TransportConfiguration - only encode non-null values
Check for null, to avoid encoding issue, this is seen on failover.
You can merge this pull request into a Git
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165604393
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165603319
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165602190
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
-
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165602075
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
-
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165601509
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
-
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165600483
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
-
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165600076
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
-
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165599007
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireCoreConverter.java
-
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165597637
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1832
@gtully you happy if this is merged? Just waiting on this before I continue
with the other bits as mentioned
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1838
@clebertsuconic could you check this
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1838
ARTEMIS-1654 - fix bridge reconnect logic
Make sure that if a bridge disconnects and there is no record in the
topology that it uses the original bridge connector to reconnect
57 matches
Mail list logo
