Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1851#discussion_r170185326
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java
---
@@ -457,11 +459,11 @@ priv
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1851
---
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
Oops, i deleted the branch :( It seems not possible to reopen. I'll create
a new one.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
@wy96f Np you can pick up the master and push a new PR with the new changes
that are more improvements/gardening than fixes.
IMO would be interesting to:
- drop the (completly use
GitHub user qihongxu opened a pull request:
https://github.com/apache/activemq-artemis/pull/1894
ARTEMIS-1700 Fixed deadlock in paging state
JournalStorageManager is not indeed using a `single` thread. We apply this
patch to use a simple single thread executor.
We have seen s
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1894
@qihongxu Thanks for the PR!
IMO would be better to provide a test or a reproducer that has been fixed
by this change.
Re the changes: the `ArtemisExecutor` is a `fake` executor t
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170355937
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170356212
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1893#discussion_r170359387
--- Diff:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
---
@@ -2285,7 +2286,6 @@ public vo
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1893#discussion_r170359441
--- Diff:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
---
@@ -2285,7 +2286,6 @@ public vo
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405082
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405300
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405391
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405747
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1
Github user qihongxu commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405758
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170407785
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
@michaelandrepearce hi, i don't get what you mean the test. Why do we need
a suit test? And where should the test be put to stop from running by CI buid?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
There are tests that run as part of PR and then separately there are a
fuller test suite. Reason for this is the larger test suite takes much longer
to complete, as such itâs
18 matches
Mail list logo
