[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml

2018-02-26 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1896 @michaelandrepearce do you think we should add some documentation for this feature? ---

[GitHub] activemq-artemis issue #1899: ARTEMIS-1700 Fixed deadlock in paging state

2018-02-26 Thread shoukunhuai
Github user shoukunhuai commented on the issue: https://github.com/apache/activemq-artemis/pull/1899 So it is a mistake to use global thread pool instead of io thread pool for page cursor. But this does not fix our problem, as you can see ``` "Thread-274672

[GitHub] activemq-artemis pull request #1902: Revert "NO-JIRA Using Wait.assertEquals...

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1902 ---

[GitHub] activemq-artemis pull request #:

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/2df9c0ee76cf278ae8cc379e23f554346d5777c3#commitcomment-27802961 @michaelandrepearce I don't think it's related. ---

[GitHub] activemq-artemis pull request #:

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/2df9c0ee76cf278ae8cc379e23f554346d5777c3#commitcomment-27802963 but I will double check ---

[GitHub] activemq-artemis pull request #1901: Make a benign change to test PR build u...

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1901 ---

[GitHub] activemq-artemis pull request #1902: Revert "NO-JIRA Using Wait.assertEquals...

2018-02-26 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1902 Revert "NO-JIRA Using Wait.assertEquals on test" This reverts commit 691300d10e74e58855f38599988de0fb969982c4. You can merge this pull request into a Git repository by

[GitHub] activemq-artemis pull request #:

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/2df9c0ee76cf278ae8cc379e23f554346d5777c3#commitcomment-27802561 @clebertsuconic going through builds, i see the Joram tests start failing after

[GitHub] activemq-artemis pull request #1901: Make a benign change to test PR build u...

2018-02-26 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1901 Make a benign change to test PR build using master You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #:

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/2df9c0ee76cf278ae8cc379e23f554346d5777c3#commitcomment-27802383 @clebertsuconic i had locally and a branch fully passing, then i rebased onto top of master after this

[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1896 just rebased. ---

[GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1893 ---

[GitHub] activemq-artemis pull request #1895: ARTEMIS-1702 ConcurrentLongHashMap and ...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1895 ---

[GitHub] activemq-artemis pull request #1900: ARTEMIS-1704 clear activate callbacks w...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1900 ---

[GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1894 ---

[GitHub] activemq-artemis pull request #1899: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1899 ---

[GitHub] activemq-artemis issue #1900: ARTEMIS-1704 clear activate callbacks when sto...

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1900 @jbertram checkstyle! ---

[GitHub] activemq-artemis issue #1899: ARTEMIS-1700 Fixed deadlock in paging state

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1899 it's ready to be merged! testsuite pass! ---

[GitHub] activemq-artemis pull request #1900: ARTEMIS-1704 clear activate callbacks w...

2018-02-26 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1900 ARTEMIS-1704 clear activate callbacks when stopping You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1849 @franz1981 you noted you were going to merge this once you ran all openwire suite. Also you said "I'm fixing the last few bits and it is getting in the right shape to be

[GitHub] activemq-artemis issue #1885: ARTEMIS-1694 fix graceful-shutdown doc

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1885 @jbertram you've been busy!! lots to merge :) +1 ---

[GitHub] activemq-artemis pull request #1885: ARTEMIS-1694 fix graceful-shutdown doc

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1885 ---

[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1887 ---

[GitHub] activemq-artemis issue #1887: ARTEMIS-1696 allow empty 'address' for groupin...

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1887 as no further comments, and @jbertram answered my query from the other day, merging. ---

[GitHub] activemq-artemis pull request #1890: NO-JIRA fix JMX examples

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1890 ---

[GitHub] activemq-artemis issue #1895: ARTEMIS-1702 ConcurrentLongHashMap and Concurr...

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1895 @franz1981 i assume the perf stats you mentioned on the pre-cursor PR to this are still the same: master: ConcurrentLongHashMapThroughput.randomGetPutRemove

[GitHub] activemq-artemis issue #1898: ARTREMIS-1703 disable listing in web console

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1898 @stanlyDoge thanks as always , great contributions! ---

[ANNOUNCE] CVE-2017-12174: Memory exhaustion via UDP and JGroups discovery

2018-02-26 Thread Martyn Taylor
CVE-2017-12174: Memory exhaustion via UDP and JGroups discovery Severity: High Vendor: The Apache Software Foundation Versions Affected: 1.0.0, 1.1.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5, 2.0.0, 2.1.0, 2.2.0, 2.3.0 Description: If an Apache Artemis broker is

[ANNOUNCE] Apache Artemis 1.5.6

2018-02-26 Thread Martyn Taylor
All, I am extremely pleased to announce the release of Apache Artemis 1.5.6 This 1.5.6 patch release contains the following fix: https://issues.apache.org/jira/browse/ARTEMIS-1482 The project website for Apache Artemis has been updated include this release and can be found here:

[GitHub] activemq-artemis pull request #1899: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1899#discussion_r170695023 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ArtemisExecutor.java --- @@ -50,6 +50,16 @@ default int

[GitHub] activemq-artemis pull request #1899: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-26 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1899#discussion_r170691220 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ArtemisExecutor.java --- @@ -50,6 +50,16 @@ default int

[GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1894#discussion_r170689156 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java ---

[GitHub] activemq-artemis pull request #1899: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-26 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1899 ARTEMIS-1700 Fixed deadlock in paging state This closes #1894 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1899: ARTEMIS-1700 Fixed deadlock in paging state

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1899 Please wait my ack before merging this.. I'm running the whole testsuite! open for discussion only now ---

[GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-26 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1894#discussion_r170676481 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java ---

[GitHub] activemq-artemis pull request #1898: ARTREMIS-1703 disable listing in web co...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1898 ---

[GitHub] activemq-artemis issue #1898: ARTREMIS-1703 disable listing in web console

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1898 +1 LGTM ---

[GitHub] activemq-artemis pull request #1897: ARTEMIS-1693 fix java.security.auth.log...

2018-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1897 ---

[GitHub] activemq-artemis pull request #1898: ARTREMIS-1703 disable listing in web co...

2018-02-26 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1898 ARTREMIS-1703 disable listing in web console You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis

[GitHub] activemq-artemis pull request #1895: ARTEMIS-1702 ConcurrentLongHashMap and ...

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1895#discussion_r170587405 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java --- @@ -196,11

[GitHub] activemq-artemis pull request #1897: ARTEMIS-1693 fix java.security.auth.log...

2018-02-26 Thread dejanb
GitHub user dejanb opened a pull request: https://github.com/apache/activemq-artemis/pull/1897 ARTEMIS-1693 fix java.security.auth.login.config value You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejanb/activemq-artemis

[GitHub] activemq-artemis pull request #1895: ARTEMIS-1702 ConcurrentLongHashMap and ...

2018-02-26 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1895#discussion_r170562278 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java --- @@ -460,7 +468,7 @@ private

[GitHub] activemq-artemis pull request #1895: ARTEMIS-1702 ConcurrentLongHashMap and ...

2018-02-26 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1895#discussion_r170550704 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java --- @@ -196,11 +202,13 @@

[GitHub] activemq-artemis pull request #1895: ARTEMIS-1702 ConcurrentLongHashMap and ...

2018-02-26 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1895#discussion_r170542143 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java --- @@ -196,11

[GitHub] activemq-artemis pull request #1896: ARTEMIS-1661 Support splitting of broke...

2018-02-26 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1896 ARTEMIS-1661 Support splitting of broker.xml Support XML standard XInclude thus allowing splitting of the broker.xml Added test cases with split out config using import.

[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

2018-02-26 Thread JiriOndrusek
Github user JiriOndrusek commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1857#discussion_r170531201 --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java --- @@ -122,6 +122,10 @@

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

2018-02-26 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 @wy96f If you want to take a look/review the code I have pushed https://github.com/apache/activemq-artemis/pull/1895 to improve the volatile usage witht the results I've attached in the

[GitHub] activemq-artemis pull request #1895: ARTEMIS-1702 ConcurrentLongHashMap and ...

2018-02-26 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1895 ARTEMIS-1702 ConcurrentLongHashMap and ConcurrentLongHashSet should avoid volatile set cost on put/remove Most of the visibility guarantees of size/capacity fields modifications are

[GitHub] activemq pull request #277: [AMQ-6556] Support system property proxy setting...

2018-02-26 Thread amarkevich
GitHub user amarkevich opened a pull request: https://github.com/apache/activemq/pull/277 [AMQ-6556] Support system property proxy settings for HTTP(S) client You can merge this pull request into a Git repository by running: $ git pull https://github.com/amarkevich/activemq

[GitHub] activemq pull request #233: AMQ-6556 Support system property proxy settings ...

2018-02-26 Thread amarkevich
Github user amarkevich closed the pull request at: https://github.com/apache/activemq/pull/233 ---

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

2018-02-26 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 @wy96f > In your example My example was just to show the method used to perform a padding with an existing abstract class, has not values from the perf purposes: sorry, my