Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

2018-03-02 Thread Clebert Suconic
If you have anything in mind that you consider a blocking. That’s the idea of the heads up. My expectation was the examples. But if you want to request another change, like be PR pending you have that I need to work on ? :) Let me know if you have anything in mind that is a blocker. On Fr

[GitHub] activemq-artemis pull request #1923: ARTEMIS-1726 - check proper permissions...

2018-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1923 ---

[GitHub] activemq-artemis pull request #1927: ARTEMIS-1720 put activemq.xsd in 'schem...

2018-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1927 ---

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 @franz1981 @clebertsuconic I've sent an alternate PR #1928 which performs the send without any buffer copy unless necessary due to message redelivery or existence of original delivery an

[GitHub] activemq-artemis pull request #1928: ARTEMIS-1722 Don't copy message bytes u...

2018-03-02 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1928 ARTEMIS-1722 Don't copy message bytes unless needed Alternate patch that doesn't copy the message bytes unless doing a redelivery or skipping delivery annotations in the original ver

[GitHub] activemq-artemis pull request #1927: ARTEMIS-1720 put activemq.xsd in 'schem...

2018-03-02 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1927 ARTEMIS-1720 put activemq.xsd in 'schema' dir You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1720

[GitHub] activemq-artemis pull request #1925: ARTEMIS-1727 - Make sure transport is s...

2018-03-02 Thread cshannon
Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1925#discussion_r171924792 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java ---

[GitHub] activemq-artemis pull request #1925: ARTEMIS-1727 - Make sure transport is s...

2018-03-02 Thread cshannon
Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1925#discussion_r171921837 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java ---

[GitHub] activemq-artemis pull request #1925: ARTEMIS-1727 - Make sure transport is s...

2018-03-02 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1925#discussion_r171918979 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java ---

[GitHub] activemq-artemis pull request #1924: ARTEMIS-1696 doc updates

2018-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1924 ---

[GitHub] activemq-artemis pull request #1922: [ARTEMIS-1724] Create Artemis Openwire ...

2018-03-02 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1922#discussion_r171909862 --- Diff: tests/karaf-client-integration-tests/pom.xml --- @@ -36,6 +36,18 @@ + + org.apache.activem

[GitHub] activemq-artemis pull request #1922: [ARTEMIS-1724] Create Artemis Openwire ...

2018-03-02 Thread johnpoth
Github user johnpoth commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1922#discussion_r171908429 --- Diff: tests/karaf-client-integration-tests/pom.xml --- @@ -36,6 +36,18 @@ + + org.apache.activem

[GitHub] activemq-artemis pull request #1926: ARTEMIS-1721 fix broken doc link

2018-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1926 ---

[GitHub] activemq-artemis pull request #1922: [ARTEMIS-1724] Create Artemis Openwire ...

2018-03-02 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1922#discussion_r171901488 --- Diff: tests/karaf-client-integration-tests/pom.xml --- @@ -36,6 +36,18 @@ + + org.apache.activem

[GitHub] activemq-artemis pull request #1926: ARTEMIS-1721 fix broken doc link

2018-03-02 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1926 ARTEMIS-1721 fix broken doc link You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1721 Alternative

[GitHub] activemq-artemis pull request #1925: ARTEMIS-1727 - Make sure transport is s...

2018-03-02 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1925 ARTEMIS-1727 - Make sure transport is stopped on failed OpenWire connection To prevent a socket from hanging open by a bad client the broker should make sure to stop the tran

[GitHub] activemq-artemis pull request #1924: ARTEMIS-1696 doc updates

2018-03-02 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1924 ARTEMIS-1696 doc updates You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1696 Alternatively you c

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 @clebertsuconic > SoftReference sucks. It usually let you OME before it’s released. I know and i was too hurried to say that it could be used :P you're right :+1:

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 @franz1981 It doesn't look like the buffer could be contended unless perhaps the consumer was able to be subscribed to more than one queue at a time via some sort of composite type subsc

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 SoftReference sucks. It usually let you OME before it’s released. What about having a pool somewhere else? Or a smaller pool from Netty? I’m out toda

[GitHub] activemq-artemis pull request #1923: ARTEMIS-1726 - check proper permissions...

2018-03-02 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1923 ARTEMIS-1726 - check proper permissions when using OpenWire Ensure that on queue creation and deletion that the proper permissions are checked You can merge this pull request into a

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 @clebertsuconic Yep , don't worry I'm glad that you have taken a look on it! Will answer inline.. > i - There's a buffer sitting on the ProtonSenderContext now that may be unuse

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 I won't be able to look into this before Tuesday.. Please don't merge this without me... :) ---

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 I see two problems here.. i - There's a buffer sitting on the ProtonSenderContext now that may be unused for a while. What if you had 1000 connections at one time.. and then

[GitHub] activemq-artemis pull request #1916: ARTEMIS-1504 Update Qpid JMS to 0.30.0 ...

2018-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1916 ---

[GitHub] activemq-artemis pull request #1922: [ARTEMIS-1724] Create Artemis Openwire ...

2018-03-02 Thread johnpoth
GitHub user johnpoth opened a pull request: https://github.com/apache/activemq-artemis/pull/1922 [ARTEMIS-1724] Create Artemis Openwire client Karaf feature https://issues.apache.org/jira/browse/ARTEMIS-1724 Thanks! You can merge this pull request into a Git repository by r

[GitHub] activemq-artemis pull request #1921: ARTEMIS-1725 fix browsing non-listing t...

2018-03-02 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1921 ARTEMIS-1725 fix browsing non-listing tabs under JMX You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis A

[GitHub] activemq-artemis pull request #1920: Added acknowledgements for messages exp...

2018-03-02 Thread ilkkavi
GitHub user ilkkavi opened a pull request: https://github.com/apache/activemq-artemis/pull/1920 Added acknowledgements for messages expired without expiry address bindings Referring to a resource leak and JMX reporting expired messages as in-delivery as discussed in the user mailing

[GitHub] activemq-artemis pull request #1919: ARTEMIS-1723 Migrate AMQP C# examples t...

2018-03-02 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/activemq-artemis/pull/1919 ARTEMIS-1723 Migrate AMQP C# examples to the common .NET version You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvolod/activemq-art

[GitHub] activemq-artemis issue #1918: ARTEMIS-1722 Reduce pooled Netty ByteBuf usage

2018-03-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1918 This one, together with https://github.com/apache/activemq-artemis/pull/1916 aims to reduce the memoty footprint (improving scalability by different angles) of AMQP on the broker. I

[GitHub] activemq-artemis pull request #1918: ARTEMIS-1722 Reduce pooled Netty ByteBu...

2018-03-02 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1918 ARTEMIS-1722 Reduce pooled Netty ByteBuf usage Given the temporary nature of the ProtonServerSenderContext, the Netty heap pool can be avoided by reusing (enlarging if needed) a lazy lo