Re: [VOTE] Apache ActiveMQ Artemis 2.5.0

2018-03-14 Thread Clebert Suconic
It’s not a regression. I don’t think so. I say we release against in 1 or 2 weeks with 2.5.1. On Wed, Mar 14, 2018 at 7:55 PM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > Agree with Justin, I wouldn't stop this release unless it is a > regression caused since 2.4.0. We can a

Re: [VOTE] Apache ActiveMQ Artemis 2.5.0

2018-03-14 Thread Christopher Shannon
Agree with Justin, I wouldn't stop this release unless it is a regression caused since 2.4.0. We can always do bug fix releases even if they only contain a couple of fixes if they are of high importance. On Wed, Mar 14, 2018 at 7:09 PM, Justin Bertram wrote: > So is this a regression or a new is

Re: [VOTE] Apache ActiveMQ Artemis 2.5.0

2018-03-14 Thread Justin Bertram
So is this a regression or a new issue? If it's a regression then I think it should be fixed. If it's a new issue then I think it should go in 2.5.1 in short order. Justin On Wed, Mar 14, 2018 at 5:23 PM, Michael André Pearce < michael.andre.pea...@me.com> wrote: > Hi again, > > So I have man

[GitHub] activemq-artemis pull request #1953: Fixing MQTT Leak

2018-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1953 ---

Re: [VOTE] Apache ActiveMQ Artemis 2.5.0

2018-03-14 Thread Michael André Pearce
Hi again, So I have managed to create an integration test that re-creates the problem. https://github.com/michaelandrepearce/activemq-artemis/tree/NetworkHealthCheckIssue Essentially when NetworkHealthCheck detects network failure issue, the server is stopped, once the network issue is resolve

[GitHub] activemq-artemis pull request #1953: Fixing MQTT Leak

2018-03-14 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1953 Fixing MQTT Leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1286 Alternatively y

Re: [VOTE] Apache ActiveMQ Artemis 2.5.0

2018-03-14 Thread Michael André Pearce
We’ve spotted a nasty issue, I’m trying to put an integration test together to have recreatable the problem, but taking me some time. Can you give me another 24hours? To create the test to share then for you to decide if the issue is blocking or not. Sent from my iPhone > On 14 Mar 2018, at

[GitHub] activemq-artemis pull request #1952: ARTEMIS-1743 fix NPE in server log when...

2018-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1952 ---

Re: [VOTE] Apache ActiveMQ Artemis 2.5.0

2018-03-14 Thread Francesco Nigro
+1 Compiled and run some tests on it Il giorno mer 14 mar 2018 alle ore 10:46 Dejan Bosanac ha scritto: > +1 > > Regards > -- > Dejan Bosanac > http://sensatic.net/about > > On Wed, Mar 14, 2018 at 12:25 AM, Christopher Shannon < > christopher.l.shan...@gmail.com> wrote: > > > +1 > > > > On Tu

Re: [VOTE] Apache ActiveMQ Artemis 2.5.0

2018-03-14 Thread Dejan Bosanac
+1 Regards -- Dejan Bosanac http://sensatic.net/about On Wed, Mar 14, 2018 at 12:25 AM, Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > +1 > > On Tue, Mar 13, 2018 at 4:05 PM, Timothy Bish wrote: > > On 03/12/2018 04:40 PM, Clebert Suconic wrote: > >> > >> I would like to propos