[GitHub] activemq-artemis pull request #1966: ARTEMIS-370: Make JDBC Journal Sync per...

2018-03-21 Thread RaiSaurabh
GitHub user RaiSaurabh opened a pull request: https://github.com/apache/activemq-artemis/pull/1966 ARTEMIS-370: Make JDBC Journal Sync period configurable Added parameter "jdbc-journal-sync-period " to keep the sync time period configurable. You can merge this pull request into a

[GitHub] activemq-artemis pull request #1965: NO-JIRA Fixing Stomp large message test...

2018-03-21 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1965#discussion_r176306425 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompSession.java --- @@ -154,

[GitHub] activemq-artemis issue #1965: NO-JIRA Fixing Stomp large message tests

2018-03-21 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1965 please do not merge. We need discussion. ---

[GitHub] activemq-artemis pull request #1965: NO-JIRA Fixing Stomp large message test...

2018-03-21 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1965 NO-JIRA Fixing Stomp large message tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis f_fix_stomp_lm

Re: [GitHub] activemq-cpp pull request #5: Move timer objects to the end of member list

2018-03-21 Thread Andrzej Lichnerowicz
Hi y’all It’s been a while, and I am wondering, how can we move forward with this PR? Is there anything that needs to be done on my side? Do we need to have a discussion? Do you need more info? Are you guys having any questions regarding the fix? Let me know if anything is blocking the fix from

[GitHub] activemq-artemis issue #1961: [ARTEMIS-1758] support SASL EXTERNAL with Text...

2018-03-21 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1961 When running in the IDE the new test works fine, however when I run the AMQP tests from the command line the new test produces an error as below which seems to indicate the test environm

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

2018-03-21 Thread rstancel
GitHub user rstancel opened a pull request: https://github.com/apache/activemq-artemis/pull/1964 [ARTEMIS-1761] Log one warning if cluster could not be formed because… … it's not possible to connect to other cluster node Jira: https://issues.apache.org/jira/browse/ARTEMI

[GitHub] activemq-artemis issue #1962: ARTEMIS-1760 JDBC HA should have configurable ...

2018-03-21 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1962 @gtully I hope to have provided a good way to handle it: it is quite different from what [LeaseDatabaseLocker](https://github.com/apache/activemq/blob/master/activemq-jdbc-store/src/mai

[GitHub] activemq-artemis issue #1963: ARTEMIS-1757 Improve DB2 compatibility

2018-03-21 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1963 DO NOT MERGE YET, I'm running some tests to see if there are other evident compatibility issues (SQL syntax and weird exception/driver behaviours). ---

[GitHub] activemq-artemis pull request #1963: ARTEMIS-1757 Improve DB2 compatibility

2018-03-21 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1963 ARTEMIS-1757 Improve DB2 compatibility It includes: - Fixed AUTO_INCREMENT not supported on DB2 - Added proper stop/teardown of driver - Fixed recursive SQLException formatti

[GitHub] activemq-artemis issue #1962: ARTEMIS-1760 JDBC HA should have configurable ...

2018-03-21 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1962 @clebertsuconic If I have missed anything on CLI level, please correct me so I will fix it ASAP :+1: ---

[GitHub] activemq-artemis pull request #1962: ARTEMIS-1760 JDBC HA should have config...

2018-03-21 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1962 ARTEMIS-1760 JDBC HA should have configurable tolerance of DB time misalignment It allows a user to customize the max allowed distance between system and DB time, improving HA reliabil

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1960#discussion_r176109013 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompTransaction.java ---

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1960#discussion_r176097804 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompTransaction.java --- @@ -

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1960#discussion_r176096108 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/CommandType.java --- @@ -0,0 +

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1960#discussion_r176095964 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompSession.java --- @@ -154,

[GitHub] activemq-artemis issue #1960: ARTEMIS-406 STOMP acknowledgements should supp...

2018-03-21 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1960 I'm closing it for now as we need some discussion. ---

[ANNOUNCE] ActiveMQ Artemis 2.5.0 Released

2018-03-21 Thread Clebert Suconic
I'm pleased to announce the release of ActiveMQ Artemis . Downloads are now available at: http://activemq.apache.org/artemis/download.html For a complete list of updates: http://activemq.apache.org/artemis/release-notes-2.5.0.html Many thanks for all the contributors to this release.

[GitHub] activemq-artemis pull request #1961: [ARTEMIS-1758] support SASL EXTERNAL wi...

2018-03-21 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1961 [ARTEMIS-1758] support SASL EXTERNAL with TextCertLoginModule - rework proton handler to use saslListener You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1960#discussion_r176080680 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompTransaction.java ---

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1960#discussion_r176080114 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/CommandType.java --- @@ -

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1960#discussion_r176078341 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompSession.java --- @@

[GitHub] activemq-artemis pull request #1960: ARTEMIS-406 STOMP acknowledgements shou...

2018-03-21 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1960 ARTEMIS-406 STOMP acknowledgements should support transactions - Add support for transactional STOMP acks/nacks - Fixed some stomp test issues You can merge this pull request into a