Github user mohamnag commented on the issue:
https://github.com/apache/activemq-artemis/pull/1982
@jbertram thanks for comments, I just opened this to check for the CI, so I
will fix it asap.
regarding your last sentence, what do you mean using normal API? Is there a
way I ca
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1982
Couple of things related to your commit:
1. The commits should be squashed.
2. The commit message should follow the recommendation from the [Hacking
Guide](https://github.co
Yes, I understand.
Hope my feedback is constructive. If there are specifics on which feedback
would by more helpful, please don’t hesitate to let me know.
FYI - just saying the following in an attempt to clarify my point-of-view, not
critizing... the goals of this effort are vague for me. A
It is time once again to submit a report to the ASF board for April. Please
take 5 minutes to contribute some of the project activity to the report at
the wiki page below:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75977784
This report must be submitted by April 11th.
I rea
Did you read what I said in my email?
> Everyone should take a look at the gitbook that Mike put together. It's a
great first example.
Nothing is complete. He is giving us an early preview.
Bruce
On Thu, Mar 22, 2018 at 11:28 AM, Arthur Naseef wrote:
> I pulled down Michael's git repo and bro
GitHub user ingo1121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1983
ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt
Also, this is a pretty obvious fix. Doesn't quite fix
ssl-enabled-dual-authentication
, though,,
You can merge this pull request into a
GitHub user mohamnag opened a pull request:
https://github.com/apache/activemq-artemis/pull/1982
JUnit rules to be usable against external secured broker
as a companion to https://issues.apache.org/jira/browse/ARTEMIS-1778 this
will allow using junit rules to be used against an exte
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1980
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1981
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1980#discussion_r178144362
--- Diff: artemis-distribution/pom.xml ---
@@ -102,6 +102,11 @@
artemis-amqp-protocol
${project.version}
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1980#discussion_r178144111
--- Diff: artemis-distribution/pom.xml ---
@@ -102,6 +102,11 @@
artemis-amqp-protocol
${project.version}
GitHub user ingo1121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1981
ARTEMIS-1749 - missing avariable in Windows Profile
An obvious fix is the missing definition of ARTEMIS_ETC_INSTANCE, in the
Windows "artemis.profile.cmd"
You can merge this pull reques
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1980
ARTEMIS-1777 Adding Protocol specific into producer / consumer / imp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsu
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1822#discussion_r178098492
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -189,17 +187,27 @@ pri
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1974
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1976
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
@clebertsuconic Done, now there is just one commit into this PR :+1:
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
@franz1981 rebase please
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1979
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1976
@clebertsuconic This PR now contains all the necessary commits: what we can
do now?
I prefer to have just one PR with all the related commits in order to trace
better why they were
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1822#discussion_r177985094
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -189,17 +187,27 @@ pri
21 matches
Mail list logo