[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 These following tests are failing: Test Result (14 failures / +14)

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 if I merged this now I would need to use cherry-picks from master into 2.6.x... if I could wait a week before merging this? ---

[GitHub] activemq-artemis pull request #2091: ARTEMIS-1870:Missing documentation for ...

2018-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2091 ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 I'm running the testsuite first before merging this... ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-21 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @RaiSaurabh thanks for adding test, i would ask this goes in after a 2.6.1 release though, as this is new feature, and i think 2.6.1 should just be bug fixes to avoid scope of

[GitHub] activemq-artemis pull request #2094: ARTEMIS-1874 fix NPE setting object pro...

2018-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2094 ---

[GitHub] activemq-artemis pull request #2092: ARTEMIS-1853 Adding Netty OpenSSL provi...

2018-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2092 ---

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

2018-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2090 ---

[GitHub] activemq-artemis pull request #2095: ARTEMIS-1875 Add message address if not...

2018-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2095 ---

[GitHub] activemq-artemis issue #2095: ARTEMIS-1875 Add message address if not set du...

2018-05-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2095 I ran the whole testsuite and this was fine.. making this failure a non issue. Merging this. ---

Re: [HEADS-UP] ActiveMQ Artemis release in week.

2018-05-21 Thread Clebert Suconic
Good point... Just created 2.6.x However.. if I need to pick everything from master.. .I will just do the following: git checkout 2.6.x git pulll --rebase apache master And in case I find things that are not supposed to be on 2.6.1.. i will use cherry-picking. On Mon, May 21, 2018 at 2:29

Re: [HEADS-UP] ActiveMQ Artemis release in week.

2018-05-21 Thread Timothy Bish
On 05/21/2018 02:03 PM, Clebert Suconic wrote: As we talked during the voting thread, we will follow up 2.6.0 with a short 2.6.1 in 1 week from now. meanwhile... please try to not break anything :) Branch now and cherry-pick, then it doesn't matter if anyone breaks anything, -- Tim Bish

[HEADS-UP] ActiveMQ Artemis release in week.

2018-05-21 Thread Clebert Suconic
As we talked during the voting thread, we will follow up 2.6.0 with a short 2.6.1 in 1 week from now. meanwhile... please try to not break anything :) -- Clebert Suconic

Re: [DISCUSS] Commits report

2018-05-21 Thread Clebert Suconic
If we update the Release guide to include the commit report. Is there any git repo we could include it, as a sub project of ActiveMQ? The report could actually work on both ActiveMQ and Artemis codebases. On Thu, May 17, 2018 at 8:35 AM, Clebert Suconic wrote: > I

[RESULT] [VOTE] Apache ActiveMQ Artemis 2.6.0

2018-05-21 Thread Clebert Suconic
Results of the Apache ActiveMQ Artemis 2.6.0 release vote. Vote passes with 6 votes (3 binding and 3 non binding) The following votes were received: Binding: +1 Timothy Bish +1 Christopher Shannon +1 Clebert Suconic Non Binding: +1 Robbie Gemmell +1 Francesco Nigro +1 Howard Gao Thank

[GitHub] activemq-artemis pull request #2095: ARTEMIS-1875 Add message address if not...

2018-05-21 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2095 ARTEMIS-1875 Add message address if not set during redistribution You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2094: ARTEMIS-1874 fix NPE setting object pro...

2018-05-21 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2094 ARTEMIS-1874 fix NPE setting object property You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1874

Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

2018-05-21 Thread Clebert Suconic
ok.. fair enough... I will finish the release 2.6.0 as is.. and shortly after I'm sending a HEADS-UP for 2.6.1 in 1 week. On Mon, May 21, 2018 at 6:29 AM, Robbie Gemmell wrote: > I'd say the same. It is essentially the same amount of work to respin > as it is to do

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.4

2018-05-21 Thread Christopher Shannon
Ok nevermind, it apparently sent right the first time but my gmail collapsed it so it appeared to be missing the [RESULT] block in the subject so you can ignore the second email. On Mon, May 21, 2018 at 8:39 AM, Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > Resending with the

[RESULT][VOTE] Apache ActiveMQ 5.15.4

2018-05-21 Thread Christopher Shannon
Resending with the proper tags in the subject... Results of the Apache ActiveMQ 5.15.4 vote: Vote passes with 3 +1 binding votes. The following votes were received: Binding: +1 Timothy Bish +1 Christopher Shannon +1 Clebert Suconic Non-Binding +1 Jean-Baptiste Onofré +1 Francois Papon +1

[RESULT][VOTE] Apache ActiveMQ 5.15.4

2018-05-21 Thread Christopher Shannon
Results of the Apache ActiveMQ 5.15.4 vote: Vote passes with 3 +1 binding votes. The following votes were received: Binding: +1 Timothy Bish +1 Christopher Shannon +1 Clebert Suconic Non-Binding +1 Jean-Baptiste Onofré +1 Francois Papon +1 Ragnar Paulson +1 Robbie Gemmell I'll start pushing

Re: [VOTE] Apache ActiveMQ 5.15.4

2018-05-21 Thread Christopher Shannon
I removed the MD5 checksums, thanks Robbie. On Mon, May 21, 2018 at 6:59 AM, Robbie Gemmell wrote: > +1 (non-binding) > > I checked things over as follows: > - Verified the signature and checksum files (see note below). > - Checked for LICENCE and NOTICE files being

Re: [VOTE] Apache ActiveMQ 5.15.4

2018-05-21 Thread Robbie Gemmell
+1 (non-binding) I checked things over as follows: - Verified the signature and checksum files (see note below). - Checked for LICENCE and NOTICE files being present in the archives. - Ran the source build. - Ran the smoke tests. - Started the broker from the tar.gz binary and ran some AMQP

Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

2018-05-21 Thread Robbie Gemmell
I'd say the same. It is essentially the same amount of work to respin as it is to do another release, and it isnt a regression in this release, so I'd personally proceed and just use this as reason to do a quick 2.6.1 along with any other approriate fixes. Robbie On 19 May 2018 at 15:27, Timothy

Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

2018-05-21 Thread Robbie Gemmell
+1 (non-binding) I gave things a look over as follows: - Verified all the signature and checksum files. - Checked for licence + notice files being present in the archives. - Ran mvn apache-rat:check to verify licence headers in the source tar.gz - Ran the build (only, no tests) from the tar.gz. -

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-21 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @michaelandrepearce Yep, makes sense indeed. I will probably implemented it in the same you've done (on Core). I haven't finished to read the AMQP part yet :+1: ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

2018-05-21 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @franz1981 @michaelandrepearce I have added the test case to check for default 30 is used if not set or configured. I hope now it is okay. ---