GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2136
Revert "[ARTEMIS-1819] Missing fields on listAllConsumersAsJSON, listâ¦
â¦ConsumersAsJSON and listConnectionsAsJSON"
This reverts commit c3fbd1b9e479f87898e0acd53f386d588c99763
My understanding is that, KahaDB rewrite the KAHA_SUBSCRIPTION_COMMAND to
latest journal file for ease of deletion the oldeset jorunal log,
when the durable subscriber has no pending message.
But, in the following case, "Durable Subscriber C and D" aren't rewritten
to latest journal despite they
Hi all, I use ActiveMQ 5.13.1 for MQTT.
It seems that ActiveMQ writes some useless commands, when the durable
subscriber is destroyed by Offline Timeout.
For example, the following situation:
- Topic a, b, c
- Durable Subscriber A, B, C
- "Durable Subscriber A" subscribe ONLY "Topic a"
- "Durable
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2134
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2135#discussion_r194569617
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -0,0 +1
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2135#discussion_r194569421
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -0,0 +1
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2135
---
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2135#discussion_r194568008
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
---
@@ -0,0 +1,83 @
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2135
Code looks good. Add a paragraph to the docs and it should be good to go.
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2135
ARTEMIS-1924 Add amqpIdleTimeout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1924
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2134
ARTEMIS-1922 clarify doc on updating xincluded files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEM
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2128
I would create a single PR.
Also Im not sure this is a complete fix. There is still code in there that
sets up an SSL socket layer.
Also I think we need to understand
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2133
A test here would be useful. Even something as simple as adding some
getters and verifying the properties are set as expected would work, I think.
---
Hi all, I use ActiveMQ 5.13.1 for MQTT.
It seems that ActivMQ writes some useless commands, when the durable
subscriber
is destroyed by Offline Timeout.
For example, the following situation:
- Topic a, b, c
- Durable Subscriber A, B, C
- "Durable Subscriber A" subscribe ONLY "Topic a"
- "Durable
Github user k-wall commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
That should be the checkstyle violation resolved.
---
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2133
ARTEMIS-1923 fix constructing binding journalimpl bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wy96f/activemq-artemis binding_jo
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
actually on second glance I think what you have done is correct
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
you do have 1 checkstyle violation that needs fixing
---
Github user k-wall commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
Thanks for the feedback. I did initially consider making the change in
`ProtonServerSenderContext#close(boolean)` but I couldn't see a way organise
for the `closed` field of the detach per
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
There is code in ProtonServerSenderContext and
ProtonServerReceiverContextthat handles how to treat this scenario, maybe it
sthis that needs updating rather than handling this in 2 plac
GitHub user k-wall opened a pull request:
https://github.com/apache/activemq-artemis/pull/2132
ARTEMIS-1893: Treat the detach of a link with expiry policy of link-detatch
as if closed flag were true.
I believe this patch will resolve the issue I reported.
You can merge this pull re
21 matches
Mail list logo
