[GitHub] activemq-artemis issue #2155: ARTEMIS-1949 fix IllegalMonitorStateException ...

2018-07-03 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2155 Test resolved:) ---

Re: AMQ-7006

2018-07-03 Thread Avikash Mishra
Hi Gary, Thanks for your reply. Is there any tests I can leverage off? I need to test the onStompMessageAck method in StompSubsrcription.java class. Or if you can point me in the right direction. Thanks Avikash > On 3/07/2018, at 9:14 PM, Gary Tully wrote: > > please add a unit test that

AMQ-7006

2018-07-03 Thread AvikashMishra
Hi there, We have been having the issue mentioned here https://issues.apache.org/jira/browse/AMQ-7006 I have attached a patch. Please review and get back to me asap. We have tested this on our test environment and all seems to work fine and fixes the issue we are having. Would like to push this

Re: AMQ-7006

2018-07-03 Thread Gary Tully
please add a unit test that will demonstrate the problem and fix and also protect it. On Tue, 3 Jul 2018, 06:04 Avikash Mishra, wrote: > Hi there, > > We have been having the issue mentioned here > https://issues.apache.org/jira/browse/AMQ-7006 > > I have attached a patch. Please review and get