Re: AMQ-7006

2018-07-09 Thread Avikash Mishra
Hi Gary, The issue I’m trying to fix is a memory leak in ProtocolConverter.java I can’t seem to find any tests that use this file or the StompSubscription.java file. The problem is the pedingAcks array in ProtocolConverter.java is not getting cleaned up when we ACK in client mode. The garbage

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201165498 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransfo

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201156531 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransf

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2174 ---

[GitHub] activemq-nms-amqp pull request #2: AMQNET-575: NMS AMQP Client Rework

2018-07-09 Thread RagnarPaulson
GitHub user RagnarPaulson opened a pull request: https://github.com/apache/activemq-nms-amqp/pull/2 AMQNET-575: NMS AMQP Client Rework Add an NMS API implememntation that wraps the AMQPnetLite .NET API. Signed-off-by: Ragnar Paulson You can merge this pull request into

[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...

2018-07-09 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-nms-amqp/pull/1 The move of legacy code was done properly now on the Apache repo, this PR needs to be rebased and squashed into one commit for review. ---

AMQNET-575 and AMQNET-576

2018-07-09 Thread Ragnar Paulson
Hi all, I submitted a pull request for the AMQP Rework to use the .NET AMQP implementation, amqpentlite. The pull request can be seen here: https://github.com/apache/activemq-nms-amqp/pull/1 It may have been lost in the flurry of activity over the last 2 months. What is required to move forward

AMQNET-576 and AMQNET=575

2018-07-09 Thread Ragnar Paulson
Hi all, I submitted pull-req

Re: Need input for July ASF Board report

2018-07-09 Thread Justin Bertram
I added a little more information on the Artemis releases. Justin On Mon, Jul 9, 2018 at 1:12 PM, Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > I added the release dates for all of the releases done. > > On Mon, Jul 9, 2018 at 1:07 PM Bruce Snyder > wrote: > > > This is my th

Re: Need input for July ASF Board report

2018-07-09 Thread Christopher Shannon
I added the release dates for all of the releases done. On Mon, Jul 9, 2018 at 1:07 PM Bruce Snyder wrote: > This is my third and final request for input for the July board report. So > far, there has been zero input for this report and it is due on Wednesday. > > ActiveMQ committers, please tak

Re: Need input for July ASF Board report

2018-07-09 Thread Bruce Snyder
This is my third and final request for input for the July board report. So far, there has been zero input for this report and it is due on Wednesday. ActiveMQ committers, please take five minutes to contribute to the report regarding project activity: https://cwiki.apache.org/confluence/pages/vie

[GitHub] activemq-artemis pull request #2175: ARTEMIS-856 - Support consumersBeforeDi...

2018-07-09 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2175#discussion_r201076355 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -270,6 +271,15 @@ priva

[GitHub] activemq-artemis issue #2175: ARTEMIS-856 - Support consumersBeforeDispatch ...

2018-07-09 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2175 Fyi i go on annual leave 4pm tomorrow, so if youbcan comment before i can make changes before i leave else it will have to wait 2 weeks ---

[GitHub] activemq-artemis pull request #2175: ARTEMIS-856 - Support consumersBeforeDi...

2018-07-09 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2175#discussion_r201073066 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -270,6 +271,15 @@

[GitHub] activemq-artemis pull request #2175: ARTEMIS-856 - Support consumersBeforeDi...

2018-07-09 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2175#discussion_r201051073 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -270,6 +271,15 @@ priva

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201027188 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundT

[GitHub] activemq-artemis pull request #2176: ARTEMIS-1974 document LDAP role expansi...

2018-07-09 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2176 ARTEMIS-1974 document LDAP role expansion You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1974 Al

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201026341 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundT

Register now for ApacheCon and save $250

2018-07-09 Thread Rich Bowen
Greetings, Apache software enthusiasts! (You’re getting this because you’re on one or more dev@ or users@ lists for some Apache Software Foundation project.) ApacheCon North America, in Montreal, is now just 80 days away, and early bird prices end in just two weeks - on July 21. Prices will b

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201008853 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransfo

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201007171 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransf

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201005993 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutbo

[GitHub] activemq-artemis pull request #2174: ARTEMIS-1941 fix failing tests

2018-07-09 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2174#discussion_r201004508 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundT

[GitHub] activemq-artemis pull request #2175: ARTEMIS-856 - Support consumersBeforeDi...

2018-07-09 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2175 ARTEMIS-856 - Support consumersBeforeDispatch and delayBeforeDispatch https://issues.apache.org/jira/browse/ARTEMIS-856 This is equivalent to consumersBeforeDispatchSta