Re: [VOTE] Apache ActiveMQ 5.15.6

2018-09-04 Thread Timothy Bish
+1 * Validated signatures and checksums * Checked for license and notice files * Built from source and ran sanity tests and all AMQP tests * Ran the binary broker build and tested the web console On Tue, Sep 4, 2018 at 7:58 AM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > Hi E

Re: [VOTE] Apache ActiveMQ 5.15.6

2018-09-04 Thread Arthur Naseef
Looking over the release. I see the fix for AMQ-6954 is working. The build works when run without any tests. After a few retries, I have the following tests continually failing: Tests run: 19, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 173.792 sec <<< FAILURE! - in org.apache.activemq.br

Re: [VOTE] Apache ActiveMQ 5.15.6

2018-09-04 Thread Arthur Naseef
Looking over the release. I see the fix for AMQ-6954 is working. The build works when run without any tests. After a few retries, I have the following tests continually failing: Tests run: 19, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 173.792 sec <<< FAILURE! - in org.apache.activemq.br

[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-09-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 I couldn't find a description of what the grades on the badges actually mean. Do you have any idea about that? ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread mvtorres
Github user mvtorres commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 Thanks for the fix. ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 Please look at #2292 ---

[GitHub] activemq-artemis pull request #2292: ARTEMIS-2074 URI not transposing Server...

2018-09-04 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2292 ARTEMIS-2074 URI not transposing ServerLocator on ConnectionFactory You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuc

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 @jbertram I think the right fix is on the Schemas... ```java @Override protected ActiveMQConnectionFactory internalNewObject(URI uri,

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 OK. I see now where this isn't being passed through when used for a JMS connection factory, although using the property in the URL for a `ServerLocator` directly does work. You should a

[GitHub] activemq-artemis issue #2291: ARTEMIS-2072 eliminate unnecessary binding que...

2018-09-04 Thread marcelmeulemans
Github user marcelmeulemans commented on the issue: https://github.com/apache/activemq-artemis/pull/2291 Wow, fast! ... I will check this in my setup tomorrow. ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread mvtorres
Github user mvtorres commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 This is the config, our app is currently running on jboss 4.3. RemoteJMSJNDI java.naming.factory.initial=org.apache.activemq.artemis.

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 @mvtorres, how is JNDI being configured? ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread mvtorres
Github user mvtorres commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 > Why don't you just use cf = new ActiveMQConnectionFActory(uri); ? The existing code has the ConnectionFactory lookup via jndi, we're migrating from a different JMS provider(JBos

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 anyway.. if you add the property.. also add the getter.. as the externalize will it. ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 Why don't you just use cf = new ActiveMQConnectionFActory(uri); ? ---

[GitHub] activemq-artemis issue #2291: ARTEMIS-2072 eliminate unnecessary binding que...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2291 nm.. I cherry-picked it into 2.6.x ---

[GitHub] activemq-artemis issue #2291: ARTEMIS-2072 eliminate unnecessary binding que...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2291 2.6.x? ---

[GitHub] activemq-artemis pull request #2291: ARTEMIS-2072 eliminate unnecessary bind...

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2291 ---

[GitHub] activemq-artemis pull request #2259: Documentation: Add steps for Artemis as...

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2259 ---

[GitHub] activemq-artemis issue #2273: ARTEMIS-2058 Support any kind of extraProperti...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2273 Thanks for the contrib ---

[GitHub] activemq-artemis pull request #2273: ARTEMIS-2058 Support any kind of extraP...

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2273 ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread mvtorres
Github user mvtorres commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 When I was running on debug mode, it was actually hitting org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.ActiveMQConnectionFactory(boolean, TransportConfigurati

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 TBH: This currently works already. you don't need to expose the property. The URI is used to create the serverLocator, and it will be set on it already. ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 I usually just use the IDE to run tests... But you probably need to build the project before running the test? ---

[GitHub] activemq-artemis issue #2286: Support useTopologyForLoadBalancing on JMS Con...

2018-09-04 Thread mvtorres
Github user mvtorres commented on the issue: https://github.com/apache/activemq-artemis/pull/2286 This is an existing feature, I just exposed it so its usable on urls of ConnectionFactory. Existing documentation is at https://activemq.apache.org/artemis/docs/latest/clusters.h

[GitHub] activemq-artemis pull request #2289: ARTEMIS-2073 - make sure connection get...

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2289 ---

[GitHub] activemq-artemis pull request #2288: ARTEMIS-2073 - make sure connection get...

2018-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2288 ---

[GitHub] activemq-artemis issue #2289: ARTEMIS-2073 - make sure connection gets set f...

2018-09-04 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2289 @andytaylor close this please, we are not using PullRequests on 2.6.x.. (they don't work anyways). i will cherry-pick it with cherry-pick -x directly ---

[GitHub] activemq-artemis pull request #2291: ARTEMIS-2072 eliminate unnecessary bind...

2018-09-04 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2291 ARTEMIS-2072 eliminate unnecessary binding queries You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS

[VOTE] Apache ActiveMQ 5.15.6

2018-09-04 Thread Christopher Shannon
Hi Everyone, I have created the 5.15.6 release and it is ready for a vote. The list of resolved issues is here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12343805 You can get the release artifacts here: https://dist.apache.org/repos/dist/dev/activemq/activ

[GitHub] activemq-artemis pull request #2290: Add LGTM code quality badges

2018-09-04 Thread xcorail
GitHub user xcorail opened a pull request: https://github.com/apache/activemq-artemis/pull/2290 Add LGTM code quality badges Hi there! I thought you might be interested in adding these [code quality badges](https://lgtm.com/projects/g/apache/activemq-artemis/ci/#badges) to

[GitHub] activemq-artemis pull request #2289: ARTEMIS-2073 - make sure connection get...

2018-09-04 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2289 ARTEMIS-2073 - make sure connection gets set for interceptors https://issues.apache.org/jira/browse/ARTEMIS-2073 You can merge this pull request into a Git repository by running:

[GitHub] activemq-artemis pull request #2288: ARTEMIS-2073 - make sure connection get...

2018-09-04 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2288 ARTEMIS-2073 - make sure connection gets set for interceptors https://issues.apache.org/jira/browse/ARTEMIS-2073 You can merge this pull request into a Git repository by running: