[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-09-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 I'm dubious about users selecting a project based on the code quality rating from lgtm.com, but I am interested in the pull-request integration as I can think of at least one mistake it w

[GitHub] activemq-artemis pull request #2295: ARTEMIS-2076 Can't change queue filter ...

2018-09-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2295 ARTEMIS-2076 Can't change queue filter between restarts You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis AR

[DISCUSS] Network cable disconnected

2018-09-05 Thread Clebert Suconic
TL;DR: Should we make use of Netty_CONNECTION_TIMEOUT by default, as the connection would block forever if the IP on the live server is gone. Long version: I'm kind of proud of this little test I wrote, which I have committed here: https://github.com/apache/activemq-artemis/commit/05ce7c6ecd1c7

Re: [VOTE] Apache ActiveMQ 5.15.6

2018-09-05 Thread Clebert Suconic
+1 for the release +1 to fix the test after the release. On Wed, Sep 5, 2018 at 6:25 AM Christopher Shannon wrote: > > My thought are that these tests should be fixed at some point but I don't > see any reason to stop this release considering they were not broken in any > of the commits in this

Re: [VOTE] Apache ActiveMQ Artemis 2.6.3

2018-09-05 Thread Francesco Nigro
+1 Il mer 5 set 2018, 18:03 Martyn Taylor ha scritto: > +1. > > On Fri, Aug 31, 2018 at 6:08 PM, Christopher Shannon < > christopher.l.shan...@gmail.com> wrote: > > > +1 > > > > On Fri, Aug 31, 2018 at 11:11 AM Timothy Bish > wrote: > > > > > On 08/30/2018 10:46 PM, Clebert Suconic wrote: > > >

Re: [VOTE] Apache ActiveMQ Artemis 2.6.3

2018-09-05 Thread Martyn Taylor
+1. On Fri, Aug 31, 2018 at 6:08 PM, Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > +1 > > On Fri, Aug 31, 2018 at 11:11 AM Timothy Bish wrote: > > > On 08/30/2018 10:46 PM, Clebert Suconic wrote: > > > I would like to propose an Apache ActiveMQ Artemis 2.6.3 release. > > > > >

Re: [VOTE] Apache ActiveMQ 5.15.6

2018-09-05 Thread Christopher Shannon
My thought are that these tests should be fixed at some point but I don't see any reason to stop this release considering they were not broken in any of the commits in this release. I think the MultiKahaDB tests were broken at some point in 5.15.4 but whatever broke it can be fixed in time for 5.1

[GitHub] activemq-artemis pull request #2294: ARTEMIS-2068 save reading any file to g...

2018-09-05 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2294 ARTEMIS-2068 save reading any file to get AMQP large msg size ServerJMSBytesMessage::getBodyLength can save reading the whole large message file by reading just its file size Yo

[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-09-05 Thread xcorail
Github user xcorail commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 Hi @jbertram The code quality grade, or grade, is an estimation of the relative quality of a project when compared to similar reference projects. It is a letter between A+ and E

[GitHub] activemq-artemis issue #2293: ARTEMIS-2075 - allow Extra backups to try to r...

2018-09-05 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2293 this will need cherry picking into 2.6.x as well ---

[GitHub] activemq-artemis pull request #2293: ARTEMIS-2075 - allow Extra backups to t...

2018-09-05 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2293 ARTEMIS-2075 - allow Extra backups to try to replicate more than once https://issues.apache.org/jira/browse/ARTEMIS-2075 You can merge this pull request into a Git repository by runnin

Re: [VOTE] Apache ActiveMQ 5.15.6

2018-09-05 Thread Francois Papon
+1 (non-binding) Thanks for the release ! regards, François Papon fpa...@apache.org Le 04/09/2018 à 15:57, Christopher Shannon a écrit : > Hi Everyone, > > I have created the 5.15.6 release and it is ready for a vote. > > The list of resolved issues is here: > https://issues.apache.org/jira/sec