Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@franz1981 i don't think that would help, issue here is whilst locally,
performance was better, i put it on a real server to quickly re-check, and it
was slower. I think the iss
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@michaelandrepearce I have @home an AMD Thread Ripper dual socket so I can
try something with it :P Just to understand the issue here: with single
threading a stamped lock is fine but un
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@michaelandrepearce I have done some experiments on it and I have noticed
that the issue is the contention of the `state` field on `StampedLock` with the
rest of the surrounding fields o
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2331
ARTEMIS-2095 - Typed Properties ThreadSafety
Add Concurrency Test to expose concurrency errors seen in logs.
Add Fix to ensure TypedProperties to ensure threadsafety
Add
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2331
@franz1981 so it looks like stampedlock unless using optimistic read,
(which we cant in this case), doesn't play nice with dual socket's, i guess
something with all of last year
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@franz1981 i redid the solution to fix the issues, essentially ensuring all
access is via synchronized methods, and nothing leaks out (e.g. internal
properties isnt able to be g
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
@franz1981 theres a new PR, i pinged you on it.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2331
@jbertram just to be clear this sorts another issue, not the packet issue
you're aware we are having. As i believe the fix you have for that is due to a
you think a concurrency
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2326
@jbertram , @clebertsuconic can this be merged? And also cherry picked to
2.6.x this is causing issues.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2326
Will merge it.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2330
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2326
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2329
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2326
@michaelandrepearce can you do the cherry-pick on 2.6.x? there are
conflicts.. on such cases I usually ask the committer to do the cherry-pick.
on 2.6.x the code was changed
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2331
Looks like this needs to be rebased now since another PR was merged which
also changes
`artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/con
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2331
grr. (makes that change makes cherry picking fun)
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2332
ARTEMIS-2094 - Fix Configuration change loss when network Issue
(cherry picked from commit cce0e19)
You can merge this pull request into a Git repository by running:
$ git
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2326
cherry pick here: https://github.com/apache/activemq-artemis/pull/2332
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2333
ARTEMIS-2095 - Typed Properties ThreadSafety
(cherry picked from commit 8e40b2d)
You can merge this pull request into a Git repository by running:
$ git pull https://githu
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2331
Whilst its fresh, i made the cherry pick ready here:
https://github.com/apache/activemq-artemis/pull/2333
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2333
This is a cherry pick to 2.6.x of
https://github.com/apache/activemq-artemis/pull/2331
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
@rpelisse theres a suite of tests i believe under
(org.apache.activemq.artemis.tests.integration.ra ) package in the integration
test module, this would probably where i would l
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2332
@clebertsuconic heres the cherry
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2332
I saw that. Looks good.
I will be able to merge it in 30 min.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2332
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2331
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2333
Close it please!
It's important to keep the cherry-pick consistent.. so I ammended your
commit before pushing.
I also have been keeping the entire hash of
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2334
ARTEMIS-2098 potential NPE when decoding protocol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2333
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2331
@jbertram have you pr'd your fix for the packet issue? I couldnt find it in
the commits
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2334#discussion_r220697913
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
---
@@ -196,6 +196,10 @@ protect
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2250#discussion_r220699668
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
---
@@ -1796,15 +1826,15 @@ pri
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2334#discussion_r220700987
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
---
@@ -196,6 +196,10 @@ protected void de
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2335
NO-JIRA Avoid possible double instantiation of properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepear
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2335
@jbertram nudge.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2335
I just created ARTEMIS-2099. I'll update the commit message to use this
when I merge it. I'm just waiting for the PR build to finish.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2335#discussion_r220716297
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -551,12 +551,16 @@ public Core
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2250#discussion_r220720824
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
---
@@ -1796,15 +1826,15 @@ private sync
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2335#discussion_r220723361
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -551,12 +551,16 @@ p
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2335
---
Github user michaelandrepearce commented on the pull request:
https://github.com/apache/activemq-artemis/commit/8ab3be71a3ebc5667c402c2b6e6458cb73bce616#commitcomment-30665922
@jbertram will you cherry pick, or you want me to raise a second pr with
cherry?
---
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/commit/8ab3be71a3ebc5667c402c2b6e6458cb73bce616#commitcomment-30665944
@michaelandrepearce, I already cherry-picked it to 2.6.x.
---
42 matches
Mail list logo