[discussion] About blocking producers

2018-10-15 Thread Howard Gao
Hi guys, I'm working on this story and I'd like to hear your thoughts. The Jira: https://issues.apache.org/jira/browse/ARTEMIS-2097 This is to provide a functionality of the broker to block on producers so that user can consume all the existing messages (for maintaining their servers for example

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225383942 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ public sy

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225357936 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ publ

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225353248 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ public sy

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225353155 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ public sy

[GitHub] activemq-artemis pull request #2372: ARTEMIS-2126 web server can leak

2018-10-15 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2372 ARTEMIS-2126 web server can leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2126 Alternative

[GitHub] activemq pull request #310: [AMQ-7076] Fix and update features to fully supp...

2018-10-15 Thread jbonofre
GitHub user jbonofre opened a pull request: https://github.com/apache/activemq/pull/310 [AMQ-7076] Fix and update features to fully support Karaf 4.2.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/activemq AMQ-7076 A

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 @michalxo, in your test is it the management context that's leaking or something else? ---

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225165274 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ publ

[GitHub] activemq pull request #309: [AMQ-7075] Fix Camel test (userName instead of u...

2018-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/309 ---

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225164140 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java --- @@ -0,0 +1,24 @@

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225143852 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java --- @@ -0,0 +1,24 @@ +/*

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 I have managed to reproduced this issue on VM by simply adding extra hdd, formatting it, and making Artemis to use it for bindings, journal, (etc..). Started broker, waited for all compon

[GitHub] activemq-artemis pull request #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread michalxo
Github user michalxo commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2347#discussion_r225120812 --- Diff: artemis-cli/src/test/java/org/apache/activemq/cli/test/ArtemisTest.java --- @@ -233,6 +237,21 @@ public void testWebConfig() throws Exc

[GitHub] activemq pull request #309: [AMQ-7075] Fix Camel test (userName instead of u...

2018-10-15 Thread jbonofre
GitHub user jbonofre opened a pull request: https://github.com/apache/activemq/pull/309 [AMQ-7075] Fix Camel test (userName instead of username) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/activemq AMQ-7075 Alternat

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225093373 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java --- @@ -0,0 +1,24 @@ +/*

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

2018-10-15 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2369#discussion_r225077165 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java --- @@ -599,6 +600,29 @@

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2371 ARTEMIS-2097 Pause and Block Producers Added new methods to AddressControl and ServerControl to allow users to block sending on addresses. Once blocked, any messages sending to t

[GitHub] activemq-artemis issue #2370: ARTEMIS-2125 Queue preference changes to displ...

2018-10-15 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2370 I'll take a look at this today ---