[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-12 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r232560925 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -318,6 +320,33 @@ public sync

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-12 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r232590511 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -318,6 +320,33 @@ public sync

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-12 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r232654687 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -318,6 +320,33 @@ pu

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 Retest this please. ---

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 @TomasHofman you'll need to update your branch somehow to force the PR build to run again. I recommend something like `git commit --amend` & `push -f`. ---

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 No automation? Thanks, will do. :) ---

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 The PR build is automated. You just need to update your branch so it knows to test it again. A couple of git commands aren't really much harder than a GitHub comment. ---

[GitHub] activemq-artemis issue #2287: ARTEMIS-2069 Backup doesn't activate after sha...

2018-11-12 Thread TomasHofman
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/2287 Everything looks OK now, so I will wait for merging and porting to 2.6.x, and then will update downstream PR for 2.6.3.jbossorg-x (will cherry-pick -x from 2.6.x port). ---

[GitHub] activemq-artemis issue #2423: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-12 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2423 @michaelandrepearce I agree, that expiry bit qualifies as a bug and should also be fixed to disallow modification ---

[GitHub] activemq-artemis issue #2423: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-12 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2423 Id disagree thats a very importand broker feature. ---

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-12 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r232758121 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -318,6 +320,33 @@ public sync

[GitHub] activemq-artemis issue #2423: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2423 Any modification has to be on extra properties. ---

[GitHub] activemq-artemis issue #2423: ARTEMIS-2168 Fix "populate-validated-user" fea...

2018-11-12 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2423 But then that would mean it would not show on JMS properties correctly . Which it does today ---

[GitHub] activemq pull request #315: AMQ-7091 - O(n) Memory consumption when broker h...

2018-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/315 ---

ActiveMQ 5.15.8 release train

2018-11-12 Thread Jamie G.
Hi All, We've merged into 5.15.x several major bug fixes affecting KahaDB: https://issues.apache.org/jira/browse/AMQ-7082 https://issues.apache.org/jira/browse/AMQ-7091 https://issues.apache.org/jira/browse/AMQ-7093 What would be regular procedure towards getting a 5.15.x patch train moving forw