Re: [Discuss] Refactoring KahaDBStore class

2018-11-28 Thread Gary Tully
Jamie, you are missing my point. it is a tradeoff plain and simple. easier to maintain for who? It has been carefully maintained for more than 7 years. Do refactoring at the beginning of a release cycle, not at the end. diffs between 5.15.x and 5.16 will be meaningless otherwise. push out 5.16.0, w

[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...

2018-11-28 Thread spyrkob
Github user spyrkob commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2432#discussion_r237094610 --- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java --- @@ -45,16

Re: [Discuss] Refactoring KahaDBStore class

2018-11-28 Thread Arthur Naseef
Hey Gary - I agree that these changes belong on a minor version increase. What I don't understand is the assertion that the changes between 5.15.x and 5.16.0 need to be small. Given that the minor version bump can mean significant changes, as long as they are backward compatible, I see no reason

Re: [Discuss] Refactoring KahaDBStore class

2018-11-28 Thread jgenender
gtully wrote > Jamie, > you are missing my point. it is a tradeoff plain and simple. easier to > maintain for who? It has been carefully maintained for more than 7 > years. I am a bit confused and surprised. Its been maintained for 7 years by a small select few of what has become stovepipe app de

Re: [Discuss] Refactoring KahaDBStore class

2018-11-28 Thread Jamie G.
Hi Clebert, I've run the full set of test suites with these changes to passing tests. I'm happy to expand upon unit testing of course. On Tue, Nov 27, 2018 at 3:53 PM Clebert Suconic wrote: > > I'm getting too old now to realize that the most expensive thing in > *any* messaging system is testin

[GitHub] activemq pull request #325: Set the secure processing feature on the Transfo...

2018-11-28 Thread coheigea
GitHub user coheigea opened a pull request: https://github.com/apache/activemq/pull/325 Set the secure processing feature on the TransformerFactory It's good security practice to set the secure processing feature on TransformerFactory instances (as well). You can merge this pull re

[GitHub] activemq-artemis pull request #2445: ARTEMIS-2187 remove page from softcache...

2018-11-28 Thread wy96f
GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2445 ARTEMIS-2187 remove page from softcache before consumedpage We found some PageCursorInfo in consumedPage map even if these corresponding page file is deleted. Suppose that there is