[GitHub] activemq-artemis issue #2462: ARTEMIS-2197 Page deleted before transaction f...

2018-12-13 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 I think you should keep separated commits. or if you squash, make it clear that this is a two commits squashed please? ---

[GitHub] activemq-artemis issue #2462: ARTEMIS-2197 Page deleted before transaction f...

2018-12-13 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 @clebertsuconic I've update the PR including the regression fix. ---

[GitHub] activemq-artemis pull request #2155: ARTEMIS-1949 fix IllegalMonitorStateExc...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2155 ---

[GitHub] activemq-artemis pull request #2461: ARTEMIS-2202 Improve MSSQL support for ...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2461 ---

[GitHub] activemq-artemis pull request #2421: [ARTEMIS-2166]Unable to delete queue wi...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2421 ---

[GitHub] activemq-artemis pull request #2084: ARTEMIS-1859 Adding testAnonymousProduc...

2018-12-13 Thread jdanekrh
Github user jdanekrh closed the pull request at: https://github.com/apache/activemq-artemis/pull/2084 ---

[GitHub] activemq-artemis issue #2084: ARTEMIS-1859 Adding testAnonymousProducerWithQ...

2018-12-13 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2084 I've pulled this test into #2464 along with the fix (including removing the 2nd `send`). This PR can be closed. ---

[GitHub] activemq-artemis pull request #2464: ARTEMIS-1859 Incorrect routing with AMQ...

2018-12-13 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2464 ARTEMIS-1859 Incorrect routing with AMQP anonymous producer & auto-created queue You can merge this pull request into a Git repository by running: $ git pull https://github.com/jb

[GitHub] activemq-artemis issue #2312: ARTEMIS-2085 - Improve validation of MDB activ...

2018-12-13 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2312 I merged this on master and 2.6.x. @rpelisse, can you please close this? ---

[GitHub] activemq-artemis pull request #2411: ARTEMIS-2162 Remove -XX:+AggressiveOpts...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2411 ---

[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2441 ---

[GitHub] activemq-artemis pull request #2453: ARTEMIS-2194 Typo in word 'update' in c...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2453 ---

[GitHub] activemq-artemis pull request #2440: ARTEMIS-2181 Add `static` storage class...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2440 ---

[GitHub] activemq-artemis pull request #2447: Corrected a spelling mistake of "no" to...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2447 ---

[GitHub] activemq-artemis issue #2440: ARTEMIS-2181 Add `static` storage class for an...

2018-12-13 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/2440 Works on my machine... ---

[GitHub] activemq-artemis issue #2440: ARTEMIS-2181 Add `static` storage class for an...

2018-12-13 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2440 Can you confirm this change is backwards compatible (i.e. everything still works with previous version of GCC)? ---

[GitHub] activemq-artemis pull request #2463: ARTEMIS-2197 Page deleted before transa...

2018-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2463 ---

[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-13 Thread mnovak1
Github user mnovak1 commented on the issue: https://github.com/apache/activemq-artemis/pull/2460 Test looks ok to me now. ---

[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-13 Thread feuillemorte
Github user feuillemorte commented on the issue: https://github.com/apache/activemq-artemis/pull/2460 seems that there is no byteman in mvn dependencies in this package. I don't know is it a good idea to add it to dependencies... So, I would like to add getter for journalFileOpenTimeo

activemq-osgi generates MANIFEST.MF with double version arguments

2018-12-13 Thread Miroslav Beranič
Hi all, I am trying to run ActiveMQ on Karaf, with Camel and CXF. Short context: Basic idea is to accept SOAP request ( over CXF ) and pass on the request to ActiveMQ using Camel. All versions of projects are build from GIT master ( see footnotes for exact versions ). Problem: When I deploy Ac

[GitHub] activemq-artemis issue #2463: ARTEMIS-2197 Page deleted before transaction f...

2018-12-13 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2463 @clebertsuconic Can you take a look? thx. ---

[GitHub] activemq-artemis pull request #2463: ARTEMIS-2197 Page deleted before transa...

2018-12-13 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2463 ARTEMIS-2197 Page deleted before transaction finishes Fixed regression caused by previous commit b36dc37c152cabe3a0d9af178db043f842bfcdc0 You can merge this pull request into a Git

[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-13 Thread mnovak1
Github user mnovak1 commented on the issue: https://github.com/apache/activemq-artemis/pull/2460 @michalxo Sorry, i got confused as you were asking to check this PR :-) @feuillemorte @franz1981 Also byteman might do the trick. Byteman rule would be triggered after write to jou

[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-13 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2460 @mnovak1 @feuillemorte `JournalFilesRepository.journalFileOpenTimeout` isn't public or exposed by any getter hence to check it can be done in 2 ways: 1. using a mock to intercept

[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-13 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2460 It is a question on @feuillemorte Oleg, not me. I am not an author :-) ---