[GitHub] activemq-artemis pull request #2482: ARTEMIS-2214 Cache durable&priority in ...

2018-12-25 Thread qihongxu
GitHub user qihongxu opened a pull request: https://github.com/apache/activemq-artemis/pull/2482 ARTEMIS-2214 Cache durable&priority in PagedReference We recently performed a test on artemis broker and found a severe performance issue. When paged messages are being consumed

[GitHub] activemq-artemis issue #2482: ARTEMIS-2214 Cache durable&priority in PagedRe...

2018-12-25 Thread qihongxu
Github user qihongxu commented on the issue: https://github.com/apache/activemq-artemis/pull/2482 [stacks.txt](https://github.com/apache/activemq-artemis/files/2709657/stacks.txt) ---

[GitHub] activemq-artemis issue #2481: ARTEMIS-2213 don't expire critical component i...

2018-12-25 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2481 We add a pending counter to count enterCritical calls. If left time is less than enter time and pending counter equals to 0, we don't expire component as all threads have called leaveCritica

[GitHub] activemq-artemis issue #2481: ARTEMIS-2213 don't expire critical component i...

2018-12-25 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2481 @michaelandrepearce @franz1981 Here is the code of System::nanoTime from openjdk: jlong os::javaTimeNanos() { if (Linux::supports_monotonic_clock()) { struct timespec tp

[GitHub] activemq-artemis issue #2480: ARTEMIS-2212 Avoid using CLQ on ServerConsumer...

2018-12-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2480 If its not exposed and its used like doing lock on 'this". Then i can only assume it was the coders pattern at that time. ---

Starting point of activemq application

2018-12-25 Thread chtn...@gmail.com
Hi, Can someone please help me with the starting point of the activemq source code. I am trying to understand how the plugins/interceptors etc work. Regards, Chetan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis issue #2478: ARTEMIS-2210 Fix PagingStore creation synchron...

2018-12-25 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2478 @franz1981 Title changed. Thanks mate! ---

[GitHub] activemq-artemis issue #2481: ARTEMIS-2213 don't expire critical component i...

2018-12-25 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2481 @michaelandrepearce thanks buddy you too!!! ---

[GitHub] activemq-artemis issue #2478: ARTEMIS-2210 PagingStore creation is not prope...

2018-12-25 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2478 Looks fine to me buddy, just change the title, because no sync is happening anymore ;) ---

[GitHub] activemq-artemis issue #2481: ARTEMIS-2213 don't expire critical component i...

2018-12-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2481 @franz1981 haha snap. I had same thinking. ---

[GitHub] activemq-artemis issue #2481: ARTEMIS-2213 don't expire critical component i...

2018-12-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2481 I dont see how this handles clock drift if im honest. The test case doesnt actually cause a drift in nano. Also Nanoseconds also are from an arbitary offset on the cpu,

[GitHub] activemq-artemis issue #2481: ARTEMIS-2213 don't expire critical component i...

2018-12-25 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2481 I know that System::nanoTime is based on monothonic clock of the CPU thast's not wall clock time ie can't go back. System::currentTimeMillis ie UTC wall-clock can go backwards instead