michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement
Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455451227
@clebertsuconic once master is fixed ill rebase and if i could ask if you
then could re run this?
--
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455451227
@clebertsuconic one master is fixed ill rebase and if i could ask if you
then could re run this?
--
gaohoward commented on issue #2386: ARTEMIS-2135 Test multiple core consumers
receiving amqp messages
URL: https://github.com/apache/activemq-artemis/pull/2386#issuecomment-455419691
closing this as it already merged.
This is
gaohoward closed pull request #2386: ARTEMIS-2135 Test multiple core consumers
receiving amqp messages
URL: https://github.com/apache/activemq-artemis/pull/2386
This is an automated message from the Apache Git Service.
To re
gaohoward opened a new pull request #2506: ARTEMIS-2230 Exception closing
advisory consumers when supportAdvisory=false
URL: https://github.com/apache/activemq-artemis/pull/2506
When broker's advisory is disabled (supportAdvisory=false) any
advisory consumer won't get created at brok
gaohoward commented on a change in pull request #2473: ARTEMIS-1058 Jars in web
tmp dir locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2473#discussion_r248910611
##
File path:
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent
soul2zimate commented on issue #2391: Add page decoding test for large message …
URL: https://github.com/apache/activemq-artemis/pull/2391#issuecomment-455399344
It was from downstream change, I removed the cherry-pick from commit message
and PR description.
---
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455397205
@clebertsuconic could you look at this
https://github.com/apache/activemq-artemis/commit/b3f0a87e0db4832585a0460633889e13ef4
michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement
Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455394066
@clebertsuconic the message group test ones are are genuine, should be fixed
up in last push.
I dont believe S
michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement
Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455394066
@clebertsuconic the message group test ones are are genuine, and i have
fixed so now should be fixed up in last push.
michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement
Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455394066
@clebertsuconic the message group test ones are are genuine, should be fixed
up in last push.
I dont believe S
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455394066
@clebertsuconic the message group test ones are are genuine, should be fixed
up in last push.
-
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer
Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455391365
@clebertsuconic can you recheck this against master, i know things like
testDoubleDelete are failing currently on master wit
asfgit closed pull request #2505: NO-JIRA Null Check in logging
URL: https://github.com/apache/activemq-artemis/pull/2505
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitH
asfgit merged pull request #2504: NO-JIRA Check data != null during encode
URL: https://github.com/apache/activemq-artemis/pull/2504
This is an automated message from the Apache Git Service.
To respond to the message, please
jbertram commented on issue #2434: ARTEMIS-1867 FQQN for producers
URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455389307
I've rebased so everything should be OK for now. I'll rebase again if
necessary after the consumer priority stuff is done.
--
michaelandrepearce opened a new pull request #2505: NO-JIRA Null Check in
logging
URL: https://github.com/apache/activemq-artemis/pull/2505
This is an automated message from the Apache Git Service.
To respond to the message,
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455388517
Current list of failures:
Test Name | Duration | Age
-- | -- | --
org.apache.activemq.artemis.tests.integration.
jbertram commented on issue #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin
uses hard-coded RDN types
URL: https://github.com/apache/activemq-artemis/pull/2451#issuecomment-455387991
@clebertsuconic, let me fix the logging and it will be ready.
-
michaelandrepearce commented on issue #2504: NO-JIRA Check data != null during
encode
URL: https://github.com/apache/activemq-artemis/pull/2504#issuecomment-455387085
@clebertsuconic just running some code analysis quickly if and fixing the
issues highlighted that look genuine quickly.
--
michaelandrepearce commented on issue #2504: NO-JIRA Check data != null during
encode
URL: https://github.com/apache/activemq-artemis/pull/2504#issuecomment-455386880
data can be null, shown by check at top of method
int estimated = Math.max(1500, data != null ? data.capacity(
michaelandrepearce opened a new pull request #2504: NO-JIRA Check data != null
during encode
URL: https://github.com/apache/activemq-artemis/pull/2504
Picked up by code analysis checks
This is an automated message from the Ap
asfgit merged pull request #2503: NO-JIRA Fix field access
URL: https://github.com/apache/activemq-artemis/pull/2503
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub an
michaelandrepearce opened a new pull request #2503: NO-JIRA Fix field access
URL: https://github.com/apache/activemq-artemis/pull/2503
This is an automated message from the Apache Git Service.
To respond to the message, pleas
asfgit merged pull request #2502: NO-JIRA Fix String and SimpleString equals
check
URL: https://github.com/apache/activemq-artemis/pull/2502
This is an automated message from the Apache Git Service.
To respond to the message
michaelandrepearce opened a new pull request #2502: NO-JIRA Fix String and
SimpleString equals check
URL: https://github.com/apache/activemq-artemis/pull/2502
This is an automated message from the Apache Git Service.
To resp
franz1981 commented on a change in pull request #2427: ARTEMIS-2170 Optimized
CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248889763
##
File path:
artemis-commons/src/main/java/org/apache/a
franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's
checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-455379962
@michaelandrepearce I have checked that is not less optimized because the
original
asfgit merged pull request #2501: ARTEMIS-2221 Fix Merge
URL: https://github.com/apache/activemq-artemis/pull/2501
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
michaelandrepearce opened a new pull request #2501: ARTEMIS-2221 Fix Merge
URL: https://github.com/apache/activemq-artemis/pull/2501
This is an automated message from the Apache Git Service.
To respond to the message, please
michaelandrepearce commented on issue #2444: ARTEMIS-2186 Large message
incomplete when server is crashed
URL: https://github.com/apache/activemq-artemis/pull/2444#issuecomment-455373882
@clebertsuconic you happy with this one? I am.
michaelandrepearce commented on issue #2445: ARTEMIS-2187 remove page from
softcache before consumedpage
URL: https://github.com/apache/activemq-artemis/pull/2445#issuecomment-455370802
@clebertsuconic no worries, this is your area of expertise so will leave for
your better judgement. If y
clebertsuconic commented on issue #2391: Add page decoding test for large
message …
URL: https://github.com/apache/activemq-artemis/pull/2391#issuecomment-455369545
you're cherry-picking from a commit, and I don't know where that commit is
coming from.
master should be the root for
asfgit closed pull request #2445: ARTEMIS-2187 remove page from softcache
before consumedpage
URL: https://github.com/apache/activemq-artemis/pull/2445
This is an automated message from the Apache Git Service.
To respond to
michaelandrepearce edited a comment on issue #2434: ARTEMIS-1867 FQQN for
producers
URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455366517
@clebertsuconic ill hold on merging this, and the work on this with
@jbertram after
---
clebertsuconic commented on issue #2445: ARTEMIS-2187 remove page from
softcache before consumedpage
URL: https://github.com/apache/activemq-artemis/pull/2445#issuecomment-455366535
on this case I think it will be enough if the tests are passing.. will merge
it.
--
michaelandrepearce commented on issue #2434: ARTEMIS-1867 FQQN for producers
URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455366517
@clebertsuconic ill hold.
This is an automated message from the Apa
clebertsuconic commented on issue #2434: ARTEMIS-1867 FQQN for producers
URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455363730
this is conflicting. it will conflict even worse after we merge Consumers
priority.
Can we work on this after Consumers Prior
clebertsuconic commented on a change in pull request #2427: ARTEMIS-2170
Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248872930
##
File path:
artemis-commons/src/main/java/org/apa
asfgit closed pull request #2446: ARTEMIS-2188 fix address size leak caused by
large page message
URL: https://github.com/apache/activemq-artemis/pull/2446
This is an automated message from the Apache Git Service.
To respond
michaelandrepearce edited a comment on issue #2469: ARTEMIS-2221 avoid
unnecessary Bindings instance creation
URL: https://github.com/apache/activemq-artemis/pull/2469#issuecomment-455362104
@jbertram dont worry managed to sort the conflict on merge. Thanks for this
as always
michaelandrepearce commented on issue #2469: ARTEMIS-2221 avoid unnecessary
Bindings instance creation
URL: https://github.com/apache/activemq-artemis/pull/2469#issuecomment-455362104
@jbertram dont worry managed to sort the conflict on merge.
--
asfgit closed pull request #2469: ARTEMIS-2221 avoid unnecessary Bindings
instance creation
URL: https://github.com/apache/activemq-artemis/pull/2469
This is an automated message from the Apache Git Service.
To respond to th
clebertsuconic commented on issue #2451: ARTEMIS-2192
LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
URL: https://github.com/apache/activemq-artemis/pull/2451#issuecomment-455361649
@jbertram this is out of my expertise. Is this ready? only thing I have to
say is the nit-pik ab
clebertsuconic commented on a change in pull request #2451: ARTEMIS-2192
LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
URL: https://github.com/apache/activemq-artemis/pull/2451#discussion_r248871028
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/
asfgit closed pull request #2470: Fixes for alerts from lgtm.com
URL: https://github.com/apache/activemq-artemis/pull/2470
This is an automated message from the Apache Git Service.
To respond to the message, please log on Gi
michaelandrepearce commented on issue #2469: ARTEMIS-2221 avoid unnecessary
Bindings instance creation
URL: https://github.com/apache/activemq-artemis/pull/2469#issuecomment-455356062
@jbertram could you rebase, after merging another of your pr's
https://github.com/apache/activemq-artemis/
michaelandrepearce commented on issue #2434: ARTEMIS-1867 FQQN for producers
URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455354819
@jbertram just went to go merge this but seems theres a conflict (our bad
for not merging sooner), could you quickly rebase?
--
michaelandrepearce edited a comment on issue #2438: ARTEMIS-2178 routing-type
config for core bridge
URL: https://github.com/apache/activemq-artemis/pull/2438#issuecomment-455354071
@jbertram thanks for this, like the feature!!, sorry been so long to merge
it for you.
---
michaelandrepearce commented on issue #2438: ARTEMIS-2178 routing-type config
for core bridge
URL: https://github.com/apache/activemq-artemis/pull/2438#issuecomment-455354071
@jbertram thanks for this, sorry been so long to merge it for you.
---
asfgit closed pull request #2438: ARTEMIS-2178 routing-type config for core
bridge
URL: https://github.com/apache/activemq-artemis/pull/2438
This is an automated message from the Apache Git Service.
To respond to the message
asfgit closed pull request #2459: ARTEMIS-2200 NPE while dropping/failing large
messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459
This is an automated message from the Apache Git Service.
To respon
clebertsuconic commented on issue #2459: ARTEMIS-2200 NPE while
dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#issuecomment-455320839
The real issue was. JournalImpl was refactored a few years ago to use an
executor on IO. the call to ap
franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce
contention on LivePageCacheImpl
URL: https://github.com/apache/activemq-artemis/pull/2494#discussion_r248691840
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/
onlyMIT edited a comment on issue #2466: ARTEMIS-2206 The MQTT consumer
reconnection caused the queue to not be cle…
URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-453845902
@jbertram I have a question to consult you and hope you can answer it.
1. Why is there MUL
clebertsuconic commented on issue #2451: ARTEMIS-2192
LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
URL: https://github.com/apache/activemq-artemis/pull/2451#issuecomment-455247312
@franz1981 you aprooved the changes.. you could just have merged it :)
-
onlyMIT commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection
caused the queue to not be cle…
URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-455244484
@michaelandrepearce @jbertram I
think my RP failures in
`org.apache.activemq.artemis.tests.in
clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE
while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248745062
##
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artem
clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE
while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248745062
##
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artem
clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE
while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726923
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/p
franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while
dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726803
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journ
franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while
dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726229
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journ
clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE
while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248724979
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/
jbertram commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection
caused the queue to not be cle…
URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-455219703
@clebertsuconic, this is still in progress. I haven't had any time to
follow-up yet.
clebertsuconic commented on issue #2466: ARTEMIS-2206 The MQTT consumer
reconnection caused the queue to not be cle…
URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-455219150
@jbertram / @onlyMIT what's the status here? I was looking on PRs to merge
but this one see
clebertsuconic commented on a change in pull request #2473: ARTEMIS-1058 Jars
in web tmp dir locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2473#discussion_r248722829
##
File path:
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComp
clebertsuconic commented on issue #2474: [ARTEMIS-1536]: Incorrect Journal
filesize calculation where specified size is lest that the block size when
using AIO.
URL: https://github.com/apache/activemq-artemis/pull/2474#issuecomment-455216239
merged & cherry-picked into 2.6.x
-
asfgit closed pull request #2474: [ARTEMIS-1536]: Incorrect Journal filesize
calculation where specified size is lest that the block size when using AIO.
URL: https://github.com/apache/activemq-artemis/pull/2474
This is an a
asfgit closed pull request #2478: ARTEMIS-2210 Fix PagingStore creation
synchronization issue
URL: https://github.com/apache/activemq-artemis/pull/2478
This is an automated message from the Apache Git Service.
To respond to
clebertsuconic commented on a change in pull request #2479: ARTEMIS-2211 Avoid
duplicate code for ByteBuffer pooling and alignment
URL: https://github.com/apache/activemq-artemis/pull/2479#discussion_r248716417
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis
asfgit closed pull request #2480: ARTEMIS-2212 Avoid using CLQ on
ServerConsumerImpl
URL: https://github.com/apache/activemq-artemis/pull/2480
This is an automated message from the Apache Git Service.
To respond to the messa
clebertsuconic commented on a change in pull request #2480: ARTEMIS-2212 Avoid
using CLQ on ServerConsumerImpl
URL: https://github.com/apache/activemq-artemis/pull/2480#discussion_r24870
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/Ser
clebertsuconic commented on a change in pull request #2480: ARTEMIS-2212 Avoid
using CLQ on ServerConsumerImpl
URL: https://github.com/apache/activemq-artemis/pull/2480#discussion_r248709539
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/Ser
asfgit closed pull request #2500: NO-JIRA Adding test to verify Openwire
consuming from FQQN
URL: https://github.com/apache/activemq-artemis/pull/2500
This is an automated message from the Apache Git Service.
To respond to t
franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce
contention on LivePageCacheImpl
URL: https://github.com/apache/activemq-artemis/pull/2494#discussion_r248691840
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/
Create a broker instance.
Change the broker.xml to point the data where you need it.
Run it like local from that broker instance.
We could bring some options Into the main bin with additional parameters
required. Which ones you need ?
On Wed, Jan 16, 2019 at 5:58 PM artemissp wrote:
> Artem
qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on
LivePageCacheImpl
URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-455086939
@franz1981
Here's the result of single and 400 consumers.
With these settings applied:
max-size-bytes = 950MB,
77 matches
Mail list logo
