[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457811530 @michaelandrepearce > whats the compatibility of using the c++ c11 features I don't know , that' s

[GitHub] michaelandrepearce edited a comment on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce edited a comment on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457790372 +1 please feel free to merge (i left additional comments, but these are just that, im happy to merge as is

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182904 ## File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/i

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251184069 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/nio/NIOSeque

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251184000 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequ

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251183788 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/DelegateCall

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251183735 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/DelegateCall

[GitHub] michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251183735 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/DelegateCall

[GitHub] michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457790883 @franz1981 whats the compatibility of using the c++ c11 features, e.g. this change with cent

[GitHub] michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457790883 @franz1981 whats the compatibility of using the c++ c11 features, e.g. this change with cent

[GitHub] michaelandrepearce commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
michaelandrepearce commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457790883 @franz1981 whats the compatibility of using the c++ c11 features, e.g. this change with centOS6 / r

[GitHub] michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
michaelandrepearce edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457790883 @franz1981 whats the compatibility of using the c++ c11 features, e.g. this change with cent

[GitHub] michaelandrepearce commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457790372 +1 This is an automated message from the Apache

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182904 ## File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/i

[GitHub] michaelandrepearce edited a comment on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce edited a comment on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457790372 +1 please feel free to merge This is an a

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182904 ## File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/i

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182864 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182839 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457728883 @clebertsuconic About the memory barriers? Are the standard implementation used on the c++11 memory m

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457728883 @clebertsuconic About the memory barriers? Are the standard implementation used on the c++11 memory m

[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457728883 About the memory barriers? Are the standard implementation used on the c++11 memory model and I have asked a

[GitHub] clebertsuconic commented on a change in pull request #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#discussion_r251130524 ## File path: artemis-native/src/main/c/org_apache_activemq_artemis_jlibaio_L

[GitHub] michaelandrepearce edited a comment on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce edited a comment on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457695845 I cant spot anything else so im good. Looks like pr build failed tho :( Some checkstyle ---

[GitHub] michaelandrepearce commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457695845 I cant spot anything else so im good. Looks like pr build failed tho :( -

[GitHub] clebertsuconic commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
clebertsuconic commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457682049 @michaelandrepearce now it's ready! This is an autom

[GitHub] clebertsuconic commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
clebertsuconic commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457673988 I pushed it but it still wrong.. hold on.. I will inform it here

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251086218 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/Activ

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251077972 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/A

[GitHub] orpiske edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
orpiske edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457645769 @franz1981 absolutely! I will be happy to help with this one. I have some 32 bits systems where we can

[GitHub] orpiske commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
orpiske commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457645769 @franz1981 absolutely! I will be happy to help with this one. I have some 32 bits where we can work and test t

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457643382 It should be a nice step for a future optimization that would allow to use 1 core just to retrieve IO

[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457643382 It should be a nice step for a future optimization that would allow to use 1 core just to retrieve IO events

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457639282 @michaelandrepearce I suppose this one could be of some interest to you :) @orpiske Please mate I n

[GitHub] franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 edited a comment on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457639282 @michaelandrepearce I suppose this one could be of some interest to you :) @orpiske Please mate I n

[GitHub] franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 commented on issue #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523#issuecomment-457639282 @michaelandrepearce I suppose this one could be of some interest to you :) @orpiske Please mate I need som

[GitHub] franz1981 opened a new pull request #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events

2019-01-25 Thread GitBox
franz1981 opened a new pull request #2523: ARTEMIS-1977 ASYNCIO can reduce sys-calls to retrieve I/O events URL: https://github.com/apache/activemq-artemis/pull/2523 On LibAIO is possible to retrieve the I/O completion events without using io_getevents sys-calls by reading the user-sp

[GitHub] clebertsuconic commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
clebertsuconic commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457631663 @michaelandrepearce this is now ready for review and merge... if you're happy with it.. let me know.. and I can

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r251045798 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r251045798 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251045430 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/Activ

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251044280 ## File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/i

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r251043063 ## File path: artemis-commons/src/main/java/org/apache/activemq/ar

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251039152 ## File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integ

[GitHub] franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251038639 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSe

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251038775 ## File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integ

[GitHub] franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251038360 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSe

Re: [RESULT[ [VOTE] Apache ActiveMQ Artemis 2.6.4

2019-01-25 Thread Clebert Suconic
I was going to finish the release.. However for some reason Nexus upgrade did not upload the release on maven central. I'm asking help on infra to see what's going on. I will only make the announce and update the website once Infra solves the problem. meanwhile if anyone know how to help here..

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251009673 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251014507 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251014507 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251014507 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251011676 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251009673 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251011676 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251011676 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] clebertsuconic commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251011598 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuff

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251009673 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251009673 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] clebertsuconic commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251010514 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuff

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251009673 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251009673 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.ja

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r251008897 ## File path: artemis-commons/src/main/java/org/apache/activemq/ar

[GitHub] clebertsuconic commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
clebertsuconic commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251006945 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuff

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250995541 ## File path: artemis-commons/src/main/java/org/apache/activemq/ar

[GitHub] franz1981 opened a new pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-01-25 Thread GitBox
franz1981 opened a new pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522 NIO/MAPPED journal types can use directly the buffer of TimedBuffer to perform file writes, avoiding an expensive copy + zeroing. --

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250970503 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250970503 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250967776 ## File path: artemis-commons/src/main/java/org/apache/activemq/ar

[GitHub] soul2zimate commented on issue #2391: Add page decoding test for large message …

2019-01-25 Thread GitBox
soul2zimate commented on issue #2391: Add page decoding test for large message … URL: https://github.com/apache/activemq-artemis/pull/2391#issuecomment-457503259 OK, all downstream references are removed. This is an automated

[GitHub] franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment

2019-01-25 Thread GitBox
franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-457500842 @michaelandrepearce @clebertsuconic We can talk about this one on the issue/forum too: the thing is th

[GitHub] franz1981 commented on issue #2391: Add page decoding test for large message …

2019-01-25 Thread GitBox
franz1981 commented on issue #2391: Add page decoding test for large message … URL: https://github.com/apache/activemq-artemis/pull/2391#issuecomment-457496499 @soul2zimate I see that there are yet references to downstream repos on the description of the PR, please remove them

[GitHub] franz1981 closed pull request #2274: ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings

2019-01-25 Thread GitBox
franz1981 closed pull request #2274: ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings URL: https://github.com/apache/activemq-artemis/pull/2274 This is an automated message from the Apache Git Servi

[GitHub] franz1981 commented on issue #2274: ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings

2019-01-25 Thread GitBox
franz1981 commented on issue #2274: ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings URL: https://github.com/apache/activemq-artemis/pull/2274#issuecomment-457496029 @michaelandrepearce @jbertram I will close this one :+1:

[GitHub] franz1981 commented on issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-25 Thread GitBox
franz1981 commented on issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2199#issuecomment-457495822 @morefuntang Please close this one if is being solved: Let me know if master (that

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250900530 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250900079 ## File path: artemis-commons/src/main/java/org/apache/activemq/ar

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250899801 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250896278 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250899473 ## File path: artemis-commons/src/main/java/org/apache/activemq/ar

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250896278 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250896278 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250896278 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250896278 ## File path: artemis-commons/src/main/java/org/apache/a

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-25 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250893683 ## File path: artemis-commons/src/main/java/org/apache/activemq/ar