[GitHub] asfgit closed pull request #2563: NO-JIRA Document reloading when using modularised broker.xml

2019-02-22 Thread GitBox
asfgit closed pull request #2563: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2563 This is an automated message from the Apache Git Service. To respond to

[GitHub] michaelandrepearce opened a new pull request #2563: NO-JIRA Document reloading when using modularised broker.xml

2019-02-22 Thread GitBox
michaelandrepearce opened a new pull request #2563: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2563 This is an automated message from the Apache Git Serv

[GitHub] asfgit merged pull request #2562: NO-JIRA Document reloading when using modularised broker.xml

2019-02-22 Thread GitBox
asfgit merged pull request #2562: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2562 This is an automated message from the Apache Git Service. To respond to

[GitHub] michaelandrepearce opened a new pull request #2562: NO-JIRA Document reloading when using modularised broker.xml

2019-02-22 Thread GitBox
michaelandrepearce opened a new pull request #2562: NO-JIRA Document reloading when using modularised broker.xml URL: https://github.com/apache/activemq-artemis/pull/2562 Add docs to clarify the need to touch broker.xml for modularised config to reload

Re: [Discuss] automated github messages on a separate list

2019-02-22 Thread Clebert Suconic
Ok, so far the best choice is git...@activemq.apache.org If anyone objects, let me know.. I will give it 3 business day for objections. On Fri, Feb 22, 2019 at 3:49 PM michael.andre.pearce wrote: > > gitbox@ sounds good to me.Sent from my Samsung Galaxy smartphone. > Original message -

Re: [Discuss] automated github messages on a separate list

2019-02-22 Thread michael.andre.pearce
gitbox@ sounds good to me.Sent from my Samsung Galaxy smartphone. Original message From: Robbie Gemmell Date: 22/02/2019 18:53 (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [Discuss] automated github messages on a separate list I'm actually -0 on the move as noted belo

Re: [Discuss] automated github messages on a separate list

2019-02-22 Thread Robbie Gemmell
I'm actually -0 on the move as noted below, which is to say I dont think we should do it but I'm not objecting to the move generally (as I can just filter it all into the same place I have it now, no big deal). I am -1 on using commits@ for it, since to me these mails are not commits mails. I thi

[GitHub] asfgit closed pull request #2529: Refactor the native library build code

2019-02-22 Thread GitBox
asfgit closed pull request #2529: Refactor the native library build code URL: https://github.com/apache/activemq-artemis/pull/2529 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] asfgit closed pull request #2530: Native library fixes

2019-02-22 Thread GitBox
asfgit closed pull request #2530: Native library fixes URL: https://github.com/apache/activemq-artemis/pull/2530 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and us

[GitHub] clebertsuconic commented on issue #2558: ARTEMIS-2257 Synchronize SharedEventLoopGroup shutdownGracefully

2019-02-22 Thread GitBox
clebertsuconic commented on issue #2558: ARTEMIS-2257 Synchronize SharedEventLoopGroup shutdownGracefully URL: https://github.com/apache/activemq-artemis/pull/2558#issuecomment-466420409 @wy96f did you see my comment on the JIRA? Synchronized SharedEventLoopGroup is not the bug, it's

[GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

2019-02-22 Thread GitBox
clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259368542 ## File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/cli

[GitHub] clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout

2019-02-22 Thread GitBox
clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client session not exist if reattach timeout URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259368333 ## File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/cli

[GitHub] franz1981 commented on issue #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
franz1981 commented on issue #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#issuecomment-466403676 @michaelandrepearce I've added support for the `NettyFailoverTest` that's using the node managers for e

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259343016 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.x

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259343016 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.x

[GitHub] clebertsuconic commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
clebertsuconic commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259340837 ## File path: artemis-server/src/main/resources/schema/artemis-configurat

[GitHub] clebertsuconic commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
clebertsuconic commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259340443 ## File path: artemis-server/src/main/resources/schema/artemis-configurat

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259327411 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.x

[GitHub] clebertsuconic commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
clebertsuconic commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259323862 ## File path: artemis-server/src/main/resources/schema/artemis-configurat

Re: [Discuss] automated github messages on a separate list

2019-02-22 Thread Clebert Suconic
So you guys are +0 but you oppose to every move I propose. If you would rather -1 please say so. Or, Say we separate the list where we place these messages? Can you post your preference? On Thu, Feb 21, 2019 at 6:44 PM Robbie Gemmell wrote: > I'm not sure where you think I disagree on that. I

[GitHub] wy96f opened a new pull request #2561: ARTEMIS-2259 Client session not exist if reattach on new connection t…

2019-02-22 Thread GitBox
wy96f opened a new pull request #2561: ARTEMIS-2259 Client session not exist if reattach on new connection t… URL: https://github.com/apache/activemq-artemis/pull/2561 When client session reattach on new connection or session recreation timeout, an exception is thrown causing session recre

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259319433 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.x

[GitHub] michaelandrepearce commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
michaelandrepearce commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259295181 ## File path: artemis-server/src/main/resources/schema/artemis-config

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259288569 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.x

[GitHub] franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable

2019-02-22 Thread GitBox
franz1981 commented on a change in pull request #2559: ARTEMIS-2258 The FileLockNodeManager directory should be configurable URL: https://github.com/apache/activemq-artemis/pull/2559#discussion_r259288569 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.x

Report a Bug for activemq-cpp 3.9.5

2019-02-22 Thread mill888
I think this is a bug for activemq-cpp 3.9.5 In the file src/main/activemq/transport/correlator/ResponseCorrelator.cpp, the class ResponseFinalizer destructor would remove commandId from the map, but Actually it does not remove it successfully, because it throw exception. I insert a line to pri