Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2475
This is good to merge now, full test suite pass
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2475
don't merge just yet I want to run the whole test suite
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2475
ARTEMIS-2144 - tx begin failure in ra doesn't get cleaned up
https://issues.apache.org/jira/browse/ARTEMIS-2144
You can merge this pull request into a Git repository by ru
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2465
The thing is we have a place for client id, the other protocols use this
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2465
when the core protocol is used the client is not available in the
connection, via jmx or console, because it is set on the connecting session.
This adds this info at the view level. I
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2465
ARTEMIS-2130 - This is to allow views to have the client id when set â¦
â¦on core protocol
https://issues.apache.org/jira/browse/ARTEMIS-2130
You can merge this pull
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2420
Im not sure it does, i wrote this code and remember it not working well
when i did the same thing. Also you can set this as a separate system property
as per the docs
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2415
This looks fine
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2414
Ive reviewed and this looks fine to me. Most of the changes are non
intrusive
---
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/commit/9490e745c5431e681c768e6fdd20ed5dda0b7b95#commitcomment-31119169
Im not sure this is needed, you can do -DskipIntegrationTests=true
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2373
looks good I will merge.
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2370
I'll take a look at this today
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2367
NO-JIRA - fixing up some broken tests
updated tests that rely on logging id's
You can merge this pull request into a Git repository by running:
$ git pull https://githu
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2360
NO-JIRA - fixing up some broken tests
Some tests were added to a class that was extended, Ive moved these into
their own class
You can merge this pull request into a Git repository
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2306
fixed
---
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2306#discussion_r217312411
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2306
ENTMQBR-1569 - make sure to send credits on rejected messages
And also to run the credit runnables once memory is free in fail mode
https://issues.jboss.org/browse/ENTMQBR
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2293
retest this please
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2293
please retest this
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2293
this will need cherry picking into 2.6.x as well
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2293
ARTEMIS-2075 - allow Extra backups to try to replicate more than once
https://issues.apache.org/jira/browse/ARTEMIS-2075
You can merge this pull request into a Git repository by
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2289
ARTEMIS-2073 - make sure connection gets set for interceptors
https://issues.apache.org/jira/browse/ARTEMIS-2073
You can merge this pull request into a Git repository by running
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2288
ARTEMIS-2073 - make sure connection gets set for interceptors
https://issues.apache.org/jira/browse/ARTEMIS-2073
You can merge this pull request into a Git repository by running
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2170
The original commit was incorrect in a number of ways. Ive fixed and sent
this PR
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2170
ARTEMIS-1866 - Make wait time for reply configurable once vote goes oâ¦
â¦ut to acquire a quorum
Im refactoring a lot of this original fix as it has broken API compatibilty
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2128
I would create a single PR.
Also Im not sure this is a complete fix. There is still code in there that
sets up an SSL socket layer.
Also I think we need to understand
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
actually on second glance I think what you have done is correct
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
you do have 1 checkstyle violation that needs fixing
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2132
There is code in ProtonServerSenderContext and
ProtonServerReceiverContextthat handles how to treat this scenario, maybe it
sthis that needs updating rather than handling this in 2
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2113
+1 for not changing the current behaviour
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1969
looks ok to me
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1967
ARTEMIS-1763 - Remove 'quick check' before quorum
https://issues.apache.org/jira/browse/ARTEMIS-1763
You can merge this pull request into a Git repository by running:
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1957
ARTEMIS-1752 - avoid null pointer in BridgeImpl
https://issues.apache.org/jira/browse/ARTEMIS-1752
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1946
ARTEMIS-1741 - log warning if a node isnt configured for quorum voting
https://issues.apache.org/jira/browse/ARTEMIS-1741
You can merge this pull request into a Git repository by
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1939
ARTEMIS-1736 - make sure access methods are ordered when used
https://issues.apache.org/jira/browse/ARTEMIS-1736
You can merge this pull request into a Git repository by running
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/commit/22311333dc19a6a76f377530b03f75eef5c186cc#commitcomment-27291689
In
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/Topology.java:
In
artemis
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1838
@clebertsuconic could you check this
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1838
ARTEMIS-1654 - fix bridge reconnect logic
Make sure that if a bridge disconnects and there is no record in the
topology that it uses the original bridge connector to reconnect
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1818
actually, Clebert ran th e test suite so will merge now
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1818
the failures looked environmental, re running. I'll merge once the tests
have been re run
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1794
looks good will get it merged
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1747
Yes
On 11 Jan 2018 19:52, "Justin Bertram" wrote:
> Given the discussion here my understanding is that this PR should be
> closed. Are
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1747
Michael is correct, that's what I meant. Let me explain how this works.
Every record that is written to the journal is also sent to the backup.
Once the backup rec
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1747
There is no point in waiting until its written to disc, it just adds extra
latency and gives you no extra guarantees. If the backup crashes when the live
is still up then it would
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1730
looks good, will merge once the checks have completed
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1726
https://issues.apache.org/jira/browse/ARTEMIS-1565
ARTEMIS-1565 - replica should retry quorum vote
https://issues.apache.org/jira/browse/ARTEMIS-1565
You can merge this pull
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1719
looks good will merge
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1644
@mtaylor are we ok merging this?
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1695
@michaelandrepearce I dont have one :), however I dont see a reason to
change defaults that have around for such a long time.
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1695
I agree with Justin, I think its a bad idea to change this. we should find
a different solution if we want to propagate exceptions back to the client.
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1692
NO-JIRA Adding extra assertions to test
to make sure queue name is in the error message
You can merge this pull request into a Git repository by running:
$ git pull https
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1687
@clebertsuconic what do you think, should we do something in onError at
least fro discharge?
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1687
don't merge this yet
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1687
ARTEMIS-1535 - settle delivery in same lock as sending the disposition
https://issues.apache.org/jira/browse/ARTEMIS-1535
You can merge this pull request into a Git repository by
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1664
this was just env
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1664
NO-JIRA Adding test for duplicate queues in config
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andytaylor/activemq-artemis
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1647
@michaelandrepearce yes, I will wait before merging
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1647
@michaelandrepearce it is configured in the broker.xml file via the
acceptor url so Im fine with that, dont think we need to persist it. Im happy
to merge this.
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1657
yeah thats fine, cheers
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1657
I just moved these tests from another class and added slightly different
assertion.
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1647
looks ok to me
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1647
do we need to move the AddressInfo class?
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1657
NO-JIRA Adding tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andytaylor/activemq-artemis master
Alternatively you can
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1647
As long as the JMX objects aren't created they won't appear on the console,
I would have a flag to disable them completely and one to hide them by not
creating J
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1647
Also you need to make sure that the JMX objects aren't created at all for
both addresses and queues
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1647
Howard, This just turns off advisories completely from a management pov, we
should have a switch to turn them off or on as well
---
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1638
Clebert is correct, lets fix rather than re engineer
---
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1626
ARTEMIS-1491 - removed duplicate Jolokia instance
https://issues.apache.org/jira/browse/ARTEMIS-1491
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1599
ARTEMIS-1470 - fix console move message
https://issues.apache.org/jira/browse/ARTEMIS-1470
You can merge this pull request into a Git repository by running:
$ git pull https
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1593#discussion_r145416142
--- Diff:
examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1593#discussion_r145415855
--- Diff:
examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1593
ARTEMIS-1463 - added SSL example + docs
also added support for anon login
https://issues.apache.org/jira/browse/ARTEMIS-1463
You can merge this pull request into a Git
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1591
ARTEMIS-1463 - add role based authentication to the JMX objects
some example fixes
https://issues.apache.org/jira/browse/ARTEMIS-1463
You can merge this pull request into a
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1588#discussion_r144866130
--- Diff: artemis-server/pom.xml ---
@@ -53,6 +53,11 @@
org.apache.activemq
+ artemis-boot
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1588
jaxb expects it to be in the same package or it doesnt compile then. I can
restructure this later
---
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1588#discussion_r144853262
--- Diff: artemis-cli/pom.xml ---
@@ -35,6 +35,11 @@
org.apache.activemq
+ artemis-boot
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1588#discussion_r144853104
--- Diff: artemis-cli/pom.xml ---
@@ -35,6 +35,11 @@
org.apache.activemq
+ artemis-boot
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1588
ARTEMIS-1463 - add role based authentication to the JMX objects
This is done by creating a guard and using JAAS to check for access to
mbean objects and their methods.
NB
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1471
ARTEMIS-1350 - Update management console to expose client side objects
https://issues.apache.org/jira/browse/ARTEMIS-1350
You can merge this pull request into a Git repository by
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1462
@clebertsuconic I dont see mention of a bug?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1459
Also, the console has a help.md that can be accessed in the console, could
we add this there as well, maybe pull it in during the build?
---
If your project is set up for it, you can
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1420
merged, can you close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
looks good, altho I had to tweak the build by adding
'**/overlays/**'
to the rat plugin
---
If your project is set up for it, you can reply to this email and have
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1416
I'll merge this failure was env
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1405
The failure looks environmental
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1405
ARTEMIS-1296 - fix quorum vote
Add a check on top of just being able to connect to a live broker
https://issues.apache.org/jira/browse/ARTEMIS-1296
You can merge this pull
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1396
ARTEMIS-1277 - purgeOnNoConsumer is not working properly
make sure rollback doesn't add messages back
https://issues.apache.org/jira/browse/ARTEMIS-1277
You can merge
Github user andytaylor closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1348
https://github.com/apache/activemq-artemis/pull/1359
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1359
ARTEMIS-1237 - Hard coded timeout on Journal file open
Make timeout configurable
https://issues.apache.org/jira/browse/ARTEMIS-1237
You can merge this pull request into a Git
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1357
Im fine with it failing, we already have noise in several failing
integration tests. Id rather that then it remain commented out once someone
fixes it.
---
If your project is set up
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1345
@clebertsuconic I wouldn't mind your opinion on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1354
Howard, Im not sure but if the commit or rollback fails then you need to
add back the tx is some cases, for instance if you try to commit a suspended
tx. take a look at what
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1354
LGTM is a new one to me, had to google it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1348#discussion_r123010910
--- Diff:
artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
@@ -688,6 +688,15
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1345
I can only reiterate that removing queues that have messages in my view is
a bad thing and we shouldn't allow it. At least not without any thought as to
what we should do wit
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1345
The issue that needs solving is the fact we have this queues that exist in
both the bindings journal and the config and some that are only in the journal
and we never automatically
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1348
ARTEMIS-1237 - Hard coded timeout on Journal file open
Make timeout configurable
https://issues.apache.org/jira/browse/ARTEMIS-1237
You can merge this pull request into a Git
Github user andytaylor closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1346
ARTEMIS-1211 - Allow local transactions when no jta in Resource Adapter
https://issues.apache.org/jira/browse/ARTEMIS-1211
You can merge this pull request into a Git repository by
1 - 100 of 323 matches
Mail list logo
