[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-10-02 Thread calohmn
Github user calohmn commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 Rebased and updated after the refactorings done in #2329. ---

[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-09-24 Thread calohmn
Github user calohmn commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 Any comments on this? For the case that the newly introduced `outgoingDeliveryAnnotations` have not been set, the code is still the same as before. I only have adapted some comments

[GitHub] activemq-artemis issue #2273: ARTEMIS-2058 Support any kind of extraProperti...

2018-08-30 Thread calohmn
Github user calohmn commented on the issue: https://github.com/apache/activemq-artemis/pull/2273 Test failure was due to a class not changed in the commit here. I've done an update and rebase to fix that. ---

[GitHub] activemq-artemis pull request #2273: ARTEMIS-2058 Support any kind of extraP...

2018-08-28 Thread calohmn
GitHub user calohmn opened a pull request: https://github.com/apache/activemq-artemis/pull/2273 ARTEMIS-2058 Support any kind of extraProperties in AmqpCoreConverter This fixes [ARTEMIS-2058](https://issues.apache.org/jira/browse/ARTEMIS-2058). You can merge this pull request

[GitHub] activemq-artemis issue #2258: ARTEMIS-2044 Add onSendError, onMessageRouteEr...

2018-08-22 Thread calohmn
Github user calohmn commented on the issue: https://github.com/apache/activemq-artemis/pull/2258 @cshannon Do you mean the changes in `PostOfficeImpl` and `ServerSessionImpl`? The added whitespace there is because of a new try-catch block in each class, adding indentation

[GitHub] activemq-artemis issue #2258: ARTEMIS-2044 Add onSendError, onMessageRouteEr...

2018-08-22 Thread calohmn
Github user calohmn commented on the issue: https://github.com/apache/activemq-artemis/pull/2258 Ok, I've renamed the methods and amended the commit. ---

[GitHub] activemq-artemis pull request #2258: ARTEMIS-2044 Add onSendError, onMessage...

2018-08-22 Thread calohmn
GitHub user calohmn opened a pull request: https://github.com/apache/activemq-artemis/pull/2258 ARTEMIS-2044 Add onSendError, onMessageRouteError to broker plugin This fixes [ARTEMIS-2044](https://issues.apache.org/jira/browse/ARTEMIS-2044). You can merge this pull request

[GitHub] activemq-artemis pull request #2256: ARTEMIS-2045 Add support for setting de...

2018-08-21 Thread calohmn
Github user calohmn commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2256#discussion_r211574987 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@ -733,6

[GitHub] activemq-artemis pull request #2256: ARTEMIS-2045 Add support for setting de...

2018-08-21 Thread calohmn
GitHub user calohmn opened a pull request: https://github.com/apache/activemq-artemis/pull/2256 ARTEMIS-2045 Add support for setting delivery annotations on AMQPMessage This fixes ARTEMIS-2045. It enables outgoing AMQP interceptors to set delivery annotations for the outgoing