GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2345
ARTEMIS-2108 Potential StackOverflowError when load balancing disabled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2344
ARTEMIS-2107 clarify identity for authn failures in notification
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2343
ARTEMIS-2106 log broker start failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2106
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r222356400
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java
---
@@ -41,4 +41,13
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2340#discussion_r222129384
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
---
@@ -69,6 +54,21 @@
import
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2340
ARTEMIS-1018 de-duplicate logging codes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1018
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2338
Perhaps the OpenWireProtocolManager could change the filter of the cluster
connection when it's started or it could register an ActivateCallback and do
the changes there.
---
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/commit/8ab3be71a3ebc5667c402c2b6e6458cb73bce616#commitcomment-30665944
@michaelandrepearce, I already cherry-picked it to 2.6.x.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2335#discussion_r220716297
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -551,12 +551,16 @@ public
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2335
I just created ARTEMIS-2099. I'll update the commit message to use this
when I merge it. I'm just waiting for the PR build to finish.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2334#discussion_r220700987
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
---
@@ -196,6 +196,10 @@ protected void
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2334
ARTEMIS-2098 potential NPE when decoding protocol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2331
Looks like this needs to be rebased now since another PR was merged which
also changes
`artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2330#discussion_r220325428
--- Diff:
examples/features/standard/jmx-ssl/src/main/resources/activemq/server0/management.xml
---
@@ -21,9 +21,9 @@
connector
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2330
ARTEMIS-2087 fix NPE; mask password in example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
The PR build passed, but I'll give @michaelandrepearce a chance to respond
to @franz1981's comments...
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2328
LGTM. Will wait for PR build to finish and merge if there are no issues.
Nice work!
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2327
NO-JIRA update stomp doc a/b default behavior
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2322
ARTEMIS-1991 document advanced destination options
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2320
PR should be against master.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2315
Yes, I think it should be on 2.6.x.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2316
ARTEMIS-2087 support masked passwords in management.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2315
ARTEMIS-1919 implement SNI properly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1919
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2312
INFO level message and above need to be "methodized." See
`org.apache.activemq.artemis.ra.ActiveMQRALogger`.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2302
To be clear, you don't need to close a PR to update it. Just make your
changes and `push -f` to your `patch-1` branch and the changes will be
reflected here (including a new run
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2296
LGTM
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2297
ARTEMIS-2072 refactor logic to fix tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2072
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2296
IMO all these commits should be squashed. I don't mind if you take
authorship of the test I wrote for the other PR (assuming you don't).
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2296#discussion_r215657277
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java
---
@@ -710,6 +710,7
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2295
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2296#discussion_r215621762
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java
---
@@ -710,6 +710,7
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2290
I'm dubious about users selecting a project based on the code quality
rating from lgtm.com, but I am interested in the pull-request integration as I
can think of at least one mistake
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2295
ARTEMIS-2076 Can't change queue filter between restarts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2290
I couldn't find a description of what the grades on the badges actually
mean. Do you have any idea about that?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2286
OK. I see now where this isn't being passed through when used for a JMS
connection factory, although using the property in the URL for a
`ServerLocator` directly does work. You should
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2286
@mvtorres, how is JNDI being configured?
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2291
ARTEMIS-2072 eliminate unnecessary binding queries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2285
I ran the PR build locally and it passed. I have no idea why Travis keep
choking on this.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2285
ARTEMIS-2065 Can't change queue routing-type between restarts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2283
ARTEMIS-2066 LegacyJMSConfiguration parser may deploy non-jms queues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2282
ARTEMIS-2064 make address & queue deployment more robust
Any failure to deploy an address or queue will short-circuit the broker
initialization process preventing any other addre
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2280
ARTEMIS-2063 improve logging for address/queue deployment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2187
Getting back to this now after being heads-down on other tasks...
@michaelandrepearce, I've included your test and fix in my latest update.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2275
ARTEMIS-2060 OpenSSL tests broken after Netty upgrade
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2263
ARTEMIS-2051 add trace logging for JDBC
Activate by enabling TRACE logging for:
org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver
This doesn't log *all* JDBC
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2253
NO-JIRA Tweak RedeployTest
1) Remove use of deprecated EmbeddedJMS.
2) Change test config to use static clustering as discovery may not work
in some CI environments.
You can
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2251
ARTEMIS-2023 extend 1x naming to other ops
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2023
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@ricardozanini, you should squash all of your commits so there's just one.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Seems OK. I would have thought that the channelVersion would get set when
the session was re-created on the backup (e.g
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2247
Looks like compatibility tests are failing.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@ricardozanini, I'd remove it completely from everything.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
@ricardozanini, probably best to just close this PR based on
@michaelandrepearce's feedback. If you want, you could remove the dependencies
and make it a pure Spring Boot example
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
I can't speak the contributor rights and licensing issues as I've not
looked into the fine print on that, but I would say that the comparison to CMS
and NMS isn't a good one since those
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2241
IMO, the JMS pool from 5.x should not be migrated to Artemis. It belongs
in it's own project with it's own release cycle. Also, it makes sense for it
to *not* be in the ActiveMQ
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209626842
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209618198
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2238
ARTEMIS-2023 Support 1x prefixes for JMS dests created using session
In some cases users who migrate from 1.x to 2.x may still want to keep
the legacy prefixes for their JMS
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2233
ARTEMIS-2020 Use prefixes when useJNDI=false in RA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2228
@clebertsuconic, I updated to protect `get()` as well.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2228#discussion_r208791390
--- Diff:
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/SelectorParser.java
---
@@ -80,11 +78,15 @@ public static
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2228#discussion_r208790685
--- Diff:
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/SelectorParser.java
---
@@ -80,11 +78,15 @@ public static
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2228#discussion_r208667762
--- Diff:
artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/SelectorParser.java
---
@@ -80,11 +78,15 @@ public static
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2228
ARTEMIS-2017 SelectorParser cache not thread-safe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/#discussion_r208297490
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
---
@@ -224,8 +224,10 @@ public
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/
ARTEMIS-2014 Treat inability to create directory for paging as critial
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2218
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2218
ARTEMIS-2012 Treat replication failures on replica as critical
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2215
I just sent #2216 to deal with the failures. I must have had a brain fart
or something with the metadata stuff. Your solution is much better. Thanks
for the PR!
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2216
ARTEMIS-1947 fix tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1947
Alternatively you
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2215
I merged this, but just realized that it breaks the existing tests in
`org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlTest`.
I'll send another PR to fix
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2213
ARTEMIS-2010 actively detect unauthenticated LDAP Bind requests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r207253620
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
@@ -189,16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r207218441
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
@@ -189,16
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
I have a couple of concerns here:
1. The "enqueue" and "dequeue" nomenclature doesn't fit with existing
metrics already exposed on, e.g. the queue control.
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2208
ARTEMIS-2006 Remove setDeadLetterAddress & setExpiryAddress from docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jber
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/commit/a2da41ee2e347bcf8fe721bded89e4a78ca14cfb#commitcomment-29888281
In
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/commit/a2da41ee2e347bcf8fe721bded89e4a78ca14cfb#commitcomment-29887889
In
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2187
ARTEMIS-1545 Support JMS 2.0 Completion Listener for Exceptions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2186
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2186
ARTEMIS-1970 Clean up LDAP connection in JAAS login module
This bug-fix should go into 2.6.x.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2173
@michaelandrepearce, @gtully, I'm hoping that #2183 resolves the spurious
test failures.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2183
ARTEMIS-1971 make LDAP pooling test more robust
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r201165498
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2176
ARTEMIS-1974 document LDAP role expansion
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1974
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r200757804
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2173
Just for the record, when I merged this I split this into 2 commits - one
for the bug (ARTEMIS-1970) and one for the feature (ARTEMIS-1971).
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
I took for granted that the checkstyle issues were the only problems.
However, there were 4 tests failing. I've sent #2174 to deal with them, but
I'm not 100% certain they are correct
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2174
ARTEMIS-1941 fix failing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1941
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2172
ARTEMIS-1961 track routed and unrouted messages sent to an address
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
I forgot the merge commit so you will have to close this PR manually.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
I went ahead and fixed the checkstyle issues and pushed.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2168
Checkstyle violations in JMSMappingOutboundTransformerTest.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2169
@michaelandrepearce, I'm not sure I'm following. Are you saying that by
moving the null check from toSimpleString to the constructor then
toSimpleString becomes essentially useless
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2155
@wy96f, the test you added has a lot of checkstyle violations. Please
resolve.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2169
@michaelandrepearce, that constructor is used over 2,000 times in the
code-base so deprecating it probably isn't the best option. I think we'd
probably rather want to just move the null
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2163
I forgot that the client module is an explicit dependency of the server
module. That satisfies my concerns. Thanks!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2163
This has implications for backwards compatibility so it might be best to
wait on this until the next major release. Any thoughts?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2161
Agreed. There are lots of deprecated methods that we need to remove in the
next major version plus some more stuff that we need to deprecate between now
and then.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2165
This looks the same as #2166, @morefuntang. Please either close this one or
explain why it is different from #2166.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2166
The commits should be squashed and the commit message should reference the
JIRA.
---
101 - 200 of 1052 matches
Mail list logo
