Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2011
This looks good except for a few things:
- I would rather not have an additional file for the regex properties. I
think it would be better to instead denote the regex
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2004
ARTEMIS-1793 fix 'destination-type' STOMP header
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2001
ARTEMIS-1792 race in STOMP unsubscribe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1792
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1998
ARTEMIS-1701 strip zone id from IPv6 host
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1701
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1990#discussion_r178924323
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
---
@@ -29,12 +29,7
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1982
@mohamnag, by "normal API" I mean "a client API which is normally used by
remote clients (e.g. 'core' API or JMS API)." As I see it, most of the power in
the Art
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1982
Couple of things related to your commit:
1. The commits should be squashed.
2. The commit message should follow the recommendation from the [Hacking
Guide](https
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1955
I don't mean to be pedantic, but can you squash these and add the JIRA to
the final commit message? Also, I know there wasn't a test added on
ARTEMIS-1050, but would it be possible
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1948
NO-JIRA clean Artemis artifacts from Travis cache
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1947
NO-JIRA update upgrade details for 2.4->2.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_w
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1942
Agreed. I just wanted to make a note for posterity's sake before I merged
it. :)
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1942
I'm guessing that this will break the stuff committed for
https://issues.apache.org/jira/browse/ARTEMIS-1630, but at this point I can't
even get the tests in that commit to run
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1943
NO-JIRA review docs for content, style, & format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-art
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1941
I've got a bunch of other doc updates coming ASAP, and I'll include this
one so you can just close this so I don't have to merge and rebase.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1938
Documentation about versions and upgrade procedures
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1935
ARTEMIS-1198 add listAllSessionsAsJSON mgmnt method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1919
I ran the PR build locally and it passed. Previous failures were spurious
and not related to the PR.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1928
If we want this in 2.5 I think we should merge it today.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1933
From the [JIRA](https://issues.apache.org/jira/browse/ARTEMIS-1731),
"...starting Artemis fails when the server running broker has no Internet
access."
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1934
NO-JIRA ignore exception when deleting temp queue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1931
ARTEMIS-1719 fix threadleakrule after Netty upgrade
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1920
I wanted to keep your commit, but I also wanted to get this merged so it
can be included in the upcoming 2.5 release. Therefore, I sent #1930 which has
your commit with and updated
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1930
ARTEMIS-1730 fix expiry without address or bindings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1920
This change needs a JIRA and a test as well.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1927
ARTEMIS-1720 put activemq.xsd in 'schema' dir
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1922#discussion_r171909862
--- Diff: tests/karaf-client-integration-tests/pom.xml ---
@@ -36,6 +36,18
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1922#discussion_r171901488
--- Diff: tests/karaf-client-integration-tests/pom.xml ---
@@ -36,6 +36,18
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1926
ARTEMIS-1721 fix broken doc link
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1721
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1924
ARTEMIS-1696 doc updates
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1696
Alternatively you
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1915
Rebased.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1915
Handful of work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis exampleWork
Alternatively you can review
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1900
ARTEMIS-1704 clear activate callbacks when stopping
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1893
NO-JIRA make MessageConsumerTest deterministic
The method testStopConnectionDuringOnMessage in this class was relying
on sleep() calls for critical timing. This test fails sometimes
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1887#discussion_r170153460
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -1671,7 +1671,7
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1890
NO-JIRA fix JMX examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis jmxExamples
Alternatively you
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1889
ARTEMIS-1698 support 'instance' web deployments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1888
ARTEMIS-1697 give ActivateCallback default methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1887
ARTEMIS-1696 allow empty 'address' for grouping-handler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1885
ARTEMIS-1694 fix graceful-shutdown doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1694
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1883
Couple of small fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alternatively you can
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1881
I'm looking into it now. Trying to reproduce the failure locally, but have
been unsuccessful so far.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1881#discussion_r169664598
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
sudo: false
language: java
install: true
-script: mvn -Pfast-tests -Pextra-tests -B
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1881#discussion_r169453963
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
sudo: false
language: java
install: true
-script: mvn -Pfast-tests -Pextra-tests -B
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1881#discussion_r169429443
--- Diff:
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/NetworkHealthTest.java
---
@@ -179,6 +182,7 @@ private void doCheck
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1881#discussion_r169374458
--- Diff:
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/NetworkHealthTest.java
---
@@ -159,7 +159,7 @@ public void
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1881
ARTEMIS-1684 fail build for failed 'fast' tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1879
ARTEMIS-1688 fix cluster when auto-create-addresses=false
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1878
ARTEMIS-872 fix negative space calculation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-872
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1874#discussion_r169119878
--- Diff:
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
---
@@ -365,8 +365,6 @@ public void setUp
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1875
ARTEMIS-1688 fix cluster when auto-create-addresses=false
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
Please rebase this and push -f so the new Travis CI build for the PR will
run. Thanks!
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1857#discussion_r168862534
--- Diff:
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRASessionFactoryImpl.java
---
@@ -819,13 +819,12 @@ protected
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1874
ARTEMIS-1687 reduce logging for fast-tests
Logging for the "fast-tests" profile used for PR builds could be reduced
significantly. This would save time as well as p
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@RaiSaurabh, the Travis CI issues should be resolved. Can you please
rebase this PR and push -f? Thanks!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1873
@dejanb, can you rebase to get the Travis CI integration bits so the PR
build will run properly?
---
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/commit/6470e7e64d883282624619adc9d4816fa1688a1e#commitcomment-27608481
Can you merge this, @clebertsuconic? Once it's merged I'll ask existing
PRs to rebase where applicable.
---
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/commit/6470e7e64d883282624619adc9d4816fa1688a1e#commitcomment-27608249
I believe the build is triggered for every PR and then for every merge as
well. I'm not sure there's a way
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1872
ARTEMIS-1684 enable Travis CI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1684
Alternatively
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1835
Can you squash these commits, @dejanb?
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1868
ARTEMIS-1678 inherit maven-compiler-plugin version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1865
ARTEMIS-1666 refactor to avoid duplicate code and fix bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
Although this has been merged the PR won't be closed automatically
(something funny going on in the automation). @yersan, please close this PR
manually.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1863
Is there no option to just copy (or build) this file from the source so
manual syncing isn't necessary?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
So forget what I said before. I'll merge this PR and then send a different
one upstream to deal with this issue in a different way given the management
objects have changed so
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
Ideally there would be a new PR on master and then a cherry-pick of that
same commit onto 1.x (which would preclude this PR from staying open).
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1862
I something similar possible for artemis.profile.cmd also?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1861
Checkstyle violation in CoreMessage - extra space before the final
semicolon.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1850
Nice catch!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
If you don't want to do it let me know, and I'll do it. No worries.
In any case, I think this PR should be closed.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1854
Typically issues like this would be fixed on the 'master' branch first and
then back-ported to any other branches to avoid regressions. Although the
JMSServerManager is deprecated
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1846#discussion_r166100953
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -437,7 +437,11 @@ public
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1846
Avoid NPE when setting null address
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1845
ARTEMIS-1632 add PropertyPermission for test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1632
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1844
ARTEMIS-1645 fix test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1645
Alternatively you can
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1834
@rpahli, it would be appropriate to add the link to the documentation.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1834
Could you update the SSL documentation in
docs/user-manual/en/configuring-transports.md to include the new "sslProvider"
parameter including a short explanation of why the JD
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1835
I checked out your branch, and I still see the failures. Does everything
in org.apache.activemq.cli.test.ArtemisTest pass for you?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1835
PR build failures look legitimate to me. I reproduced them locally.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1775
@stanlyDoge, yes, I think so.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1834
Couple of things...
- All changes should be squashed into a single commit
- The commit message should follow the pattern described in the [Hacking
Guide](https://github.com
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1831
ARTEMIS-1645 diverted msg can't be retried from DLQ
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1830#discussion_r165095416
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/QueueAbstractPacket.java
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1830#discussion_r16508
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml
---
@@ -78,7 +78,7 @@ ${global-max-section
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1830
ARTEMIS-1644 legacy clients can't access resources with old prefixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@jostbg, that's what I was looking for. Although I would expect the
commits to be squashed together.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1809
@clebertsuconic, go for it.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1812
ARTEMIS-1399 fix comparison
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1399
Alternatively
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1811
ARTEMIS-1408 document synchronization
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1408
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1806
@jostbg, you can extend StompTestBase and override the createServer()
method. Look at the implementation of createServer() in StompTestBase to get
an idea how to create/configure
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1810
ARTEMIS-1414 potential PrintStream leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1414
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1809
ARTEMIS-1415 potential JMS bridge conn leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1415
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1808
ARTEMIS-836 log JDBC details when starting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-836
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1805
ARTEMIS-609 fix interceptor XML docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-609
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1804
ARTEMIS-608 document adding runtime deps
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-608
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1796
Couple of things:
- Nice work!
- It's not clear to me why some things are logged at DEBUG vs. INFO.
Perhaps the documentation could address this.
- Since you're using
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1781#discussion_r162473338
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
---
@@ -557,6 +592,25 @@ public Object run
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1781#discussion_r162473145
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
@@ -423,8 +423,8
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1781#discussion_r162472842
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/database-store.txt
---
@@ -0,0 +1,18
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1781
I think it's worth clarifying the specific purpose of Derby in the
documentation. My understanding here is that Derby is being packaged for
demonstration purposes only and shouldn't
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1788
Nice work, @cshannon.
---
301 - 400 of 1052 matches
Mail list logo
