Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1781#discussion_r162472842
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/database-store.txt
---
@@ -0,0 +1,18
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1781
I think it's worth clarifying the specific purpose of Derby in the
documentation. My understanding here is that Derby is being packaged for
demonstration purposes only and shouldn
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1788
Nice work, @cshannon.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Thanks, @michaelandrepearce. Nice results!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1773
@jostbg, I'm not terribly familiar with AMQP so I can't comment with
authority as to whether or not this is a good change. @tabish121, could you
perhaps take a look here?
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162153980
--- Diff: docs/user-manual/en/masking-passwords.md ---
@@ -18,12 +18,33 @@ Apache ActiveMQ Artemis provides a default password
encoder and
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162151931
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/LDAPLoginModule.java
---
@@ -105,12 +110,39 @@ public
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162146958
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
@@ -622,8 +622,8
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162119392
--- Diff:
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/SerializationTest.java
---
@@ -91,15 +91,15
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1778
@michaelandrepearce, I appreciate your reviews. They're consistently
valuable.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162082757
--- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy
---
@@ -24,30 +24,40 @@ import
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r162082434
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/JMSServerManager.java
---
@@ -60,6 +60,24 @@ boolean
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Any metrics to quantify the benefit and justify this change?
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161868488
--- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy
---
@@ -24,30 +24,46 @@ import
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1778
Take a look at the latest push and let me know what you think. I think
I've got everything in there!
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1778
@clebertsuconic, will do.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161794644
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -309,7 +330,7 @@ public
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161794632
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -273,6 +286,14 @@ public void
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1778
ARTEMIS-1609 restore 'name' to ActiveMQDestination
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/active
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1771
In my opinion, you should remove the mask-password config property from
this PR as it will require more code/documentation changes later when it's
deprecated and eventually removed.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1771
We should keep mask-password config support where it exists already, but
don't add any new features that use it. Instead we can rely on the ENC()
syntax.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1774
ARTEMIS-1602 avoid potential NPE if property is null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1742
@clebertsuconic, what's the status of this?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1747
Given the discussion here my understanding is that this PR should be
closed. Are we in agreement?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1766
Your assumption is correct. Do not auto-create the queue if the
routing-type is MULTICAST.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1771
Aside from the failing tests this looks OK.
That said, I would love to see us move all our password masking to use the
"ENC()" syntax instead of using boolean &quo
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1766
You should squash these commits together into a single commit and also add
a test to reproduce the failure and verify the fix.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1772
I'll buy that.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1772
IMO, it's less clean because now there are 2 places which are returning 0
in case of an error. In any case, it's really not a big deal.
One additional question here
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1772
I'm not sure this is actually necessary. `java.lang.NullPointerException`
extends `java.lang.RuntimeException` which in turn extends
`java.lang.Exception` which is already being c
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1759
This looks OK to me. @mtaylor, will you review this since you opened the
JIRA?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1754
I ran the PR build myself and it succeeded. It's been so long since the
failure that the artifacts have been removed so I can't see why it failed
originally.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1763
ARTEMIS-1594 don't log dlq/expiry warn for internal q
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-ar
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
@mbukosky, please note that a bug regarding this change was just resolved.
See #1750.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160195533
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1754
ARTEMIS-1576 couple more tests for good measure
I wrote these when investigating ARTEMIS-1582 not realizing I'd already
fixed the issue. I don't see any reason I should throw
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r159896349
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r159895861
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1741
Can you squash these two commits together? They appear very closely
related.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1750
GitHub is reporting that this branch has conflicts. Also it would be worth
adding a test here to verify the fix since none of the existing tests caught it.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1715
Rather than go back and forth on this again and again I just modified your
commit and then squashed my modifications before I merged. Modifications
include:
* Changing example
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1748
ARTEMIS-1576 anon AMQP producer creates address w/wrong routing-type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1745
ARTEMIS-1406 removing impossible instanceof
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1406
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1715
Can you squash the commits?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1721
I squashed your commit into my previous one for the html-to-markdown
conversion. You can close this one.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1720
@pgfox, no worries. It was quick work.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1718
@Skiler, nice work!
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1720
ARTEMIS-1562 fix new slow-consumer example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1562
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1718
> The commit message is too long to be included in the commit
Please follow the commit recommendations in the [Hacking
Guide](https://github.com/apache/activemq-artemis/b
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1704
BTW, this is related to 2f299334465d6acace1d856079f2f294d8a54914 which was
done as part of ARTEMIS-1540. It introduced this regression.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1704
I'm not sure what the failure was in the PR build as it's already been
deleted. I ran the PR build locally and it was successful.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1706
Couple of things...
- Brokers used in tests should be configured programmatically rather than
using file-based XML config.
- There are lots of XSD changes which seem
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1715#discussion_r157065620
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTSecurityCRLTest.java
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1715#discussion_r157064556
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTSecurityCRLTest.java
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1715#discussion_r157064083
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTSecurityCRLTest.java
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1716
ARTEMIS-1562 Refactor example documentation
This commit contains these changes:
* Change example documentation to use markdown
* Generate HTML doc based on markdown during
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1704
ARTEMIS-1553 JSON values all being converted to String
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1698
ARTEMIS-1547 support referrals in LDAP login module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1695
At this point I don't even think the broker is even sending anything back.
It looks to me like the client simply infers success based on no exceptions
when pushing the message int
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1695
I'm not compelled by the "expectations" argument because different users
have different expectations. Users from one JMS implementation might have an
expectation that
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1695
I'm not sure we'd want to change the default here as it will have
significant performance implications.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1690
@Skiler, btw this will go into 2.5.0 since 2.4.0 has already been released.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1690
@michaelandrepearce, I'm working on this PR with @Skiler. I plan on
amending it before merging to deal with all the stuff you mentioned (plus a few
other things).
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
It would be ideal to have a real test in the test-suite to validate this
functionality instead of just an example. I think that once a test was created
you could get rid of the example
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
It looks a lot better, but you need to squash your commits together into a
single commit. Once that's done I'll kick off a full test-suite run with your
changes and see how it goes.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1644
Any update on this? It's been waiting for additional info for 20 days.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
> For what I have analysed in the artemis code, the
message-load-balancing-type is only set for queues configured in the broker.xml.
I don't believe that's true.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1679
The single commit here is much easier to understand so thanks for that.
However, I don't believe technical solution is viable as it relies on the
address for the subscri
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1677
> Can you help me understand how the commits should be organized?
Commits should be organized into logical units. You shouldn't have a
commit adding the example and then a ha
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1677
Your commits should be broken into logical units with clear descriptions of
what you're fixing and why. Looking at the commits you should probably have 1
where you add the exampl
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1671
ARTEMIS-1525 refactor embedded examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1525
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1661
ARTEMIS-1513 fix AMQP + core bridge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1513
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1653#discussion_r150556595
--- Diff: artemis-core-client/pom.xml ---
@@ -65,6 +71,12 @@
test
+ org.hamcrest
--- End
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1653
ARTEMIS-1510 refactor Maven poms
Clean up unused declared dependencies and undeclared dependencies which
are pulled in transitively.
You can merge this pull request into a Git
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1646
NO-JIRA update release documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1290
For future reference, instead of commenting on a PR that has been closed
for awhile you can use one of the [ActiveMQ mailing
lists](http://activemq.apache.org/mailing-lists.html). The
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1631
ARTEMIS-1492 obfuscate passwords in acceptorControl
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1630
NO-JIRA updating release documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1627
NO-JIRA fix new example poms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Alternatively
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1623#discussion_r147768193
--- Diff: artemis-distribution/pom.xml ---
@@ -39,6 +39,11 @@
org.apache.activemq
+ artemis-jms
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1623#discussion_r147763425
--- Diff: artemis-distribution/pom.xml ---
@@ -39,6 +39,11 @@
org.apache.activemq
+ artemis-jms
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1623
ARTEMIS-1488 add 'all' client jar to distribution
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artem
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1618
ARTEMIS-1483 upgrade beanutils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1483
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1616
Good point. I removed the activemq-camel dependency, but had to add some
others to compensate.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1616
In any event, I believe I've addressed all the issues raised by
@michaelandrepearce (please comment if not). This should be ready to merge.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1616
@mtaylor, the example already contains a demonstration of the Artemis JMS
Bridge. I'm not sure another example for this would be necessary.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1616
I see the doc as just informational. IMO it's not promoting one option
over the other, but simply explaining what options exist. In any event, I
changed it to avoid this potentia
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1616#discussion_r147315575
--- Diff: examples/features/sub-modules/inter-broker-bridge/README.md ---
@@ -0,0 +1,143 @@
+# Inter-broker Bridging
+
+An example
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1616#discussion_r147313825
--- Diff: examples/features/sub-modules/inter-broker-bridge/pom.xml ---
@@ -12,37 +12,24 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1616#discussion_r147313493
--- Diff: pom.xml ---
@@ -112,6 +112,7 @@
0.7.9
1.4.3
+ 3.1.4.RELEASE
--- End diff --
Wow yes.
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1616#discussion_r147313440
--- Diff: examples/features/sub-modules/inter-broker-bridge/README.md ---
@@ -0,0 +1,143 @@
+# Inter-broker Bridging
+
+An example
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1616
ARTEMIS-1467 clean up example
- Rename example project
- Leverage built-in 5.x Camel support instead of using WAR
- Clarify instructions
- Fix pom names/structure
You can
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1594
I updated the commit message and the JIRA to clarify that this is simple
**an** approach, not necessarily the recommended approach.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1594
Using a bridge is a valid way to move messages between brokers so I'll go
ahead and merge this one. If we want to add another example using the
export/import CLI tools later t
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1614#discussion_r146899887
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageConsumerTest.java
---
@@ -430,6
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1612
Don't worry about it. I fixed the checkstyle issues locally before I
pushed.
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1612
Checkstyle errors...unused imports.
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1614
NO-JIRA fix parameter name in HTTP example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1613
ARTEMIS-1420 prevent potential NPE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1608
@cburlinchon, per my email to the dev list earlier this week, I plan on
doing a release soon so if you want this in there please update the PR ASAP.
---
401 - 500 of 1085 matches
Mail list logo
