[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-13 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2460 It is a question on @feuillemorte Oleg, not me. I am not an author :-) ---

[GitHub] activemq-artemis issue #2461: ARTEMIS-2202 Improve MSSQL support for JDBC st...

2018-12-12 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2461 Seems to be working fine with MSSQL 2016. ---

[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-12 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2460 @mnovak1 @andytaylor could you please check this PR? ---

[GitHub] activemq-artemis pull request #2345: ARTEMIS-2108 Potential StackOverflowErr...

2018-10-16 Thread michalxo
Github user michalxo commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2345#discussion_r225473981 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution

[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 I have managed to reproduced this issue on VM by simply adding extra hdd, formatting it, and making Artemis to use it for bindings, journal, (etc..). Started broker, waited for all

[GitHub] activemq-artemis pull request #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread michalxo
Github user michalxo commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2347#discussion_r225120812 --- Diff: artemis-cli/src/test/java/org/apache/activemq/cli/test/ArtemisTest.java --- @@ -233,6 +237,21 @@ public void testWebConfig() throws

[GitHub] activemq-artemis issue #2260: ARTEMIS-2104 Added several tests in artemis-cl...

2018-10-04 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/2260 Can this be merged now? ---

[GitHub] activemq-artemis pull request #:

2018-08-19 Thread michalxo
Github user michalxo commented on the pull request: https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30179541 Seems like due to this commit, artemis can't be built (due to Integration tests failing). ``` [INFO

[GitHub] activemq-artemis pull request #1585: NO-JIRA docs clarification of divert po...

2017-10-12 Thread michalxo
GitHub user michalxo opened a pull request: https://github.com/apache/activemq-artemis/pull/1585 NO-JIRA docs clarification of divert position in broker.xml file You can merge this pull request into a Git repository by running: $ git pull https://github.com/michalxo/activemq

[GitHub] activemq-artemis issue #1357: ARTEMIS-607 New tests AMQP,MQTT,Stomp intercep...

2017-06-22 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/1357 @jdanekrh has made a patch for ARTEMIS-1244 issue. So this can be solved if PR is correct & accepted. --- If your project is set up for it, you can reply to this email and have

[GitHub] activemq-artemis issue #1357: ARTEMIS-607 New tests AMQP,MQTT,Stomp intercep...

2017-06-21 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/1357 I am not a developer, but a tester. So this one is not up to me to decide. Talked to @andytaylor about he, told me it's ok if the test fails and jira is linked. --- If your

[GitHub] activemq-artemis pull request #1357: Artemis 607 qe

2017-06-21 Thread michalxo
GitHub user michalxo opened a pull request: https://github.com/apache/activemq-artemis/pull/1357 Artemis 607 qe Please note, that testCheckInterceptedMQTTMessageProperties currently fails because of issue ARTEMIS-1244 [mqtt] Retain flag of received message is lost (caught

[GitHub] activemq-artemis issue #1355: ARTEMIS-607 New tests AMQP,MQTT,Stomp intercep...

2017-06-21 Thread michalxo
Github user michalxo commented on the issue: https://github.com/apache/activemq-artemis/pull/1355 Yeah, I will close this PR and create a new one with corrected things. First real PR did not worked out well. :) --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis pull request #1355: ARTEMIS-607 New tests AMQP,MQTT,Stomp i...

2017-06-21 Thread michalxo
Github user michalxo closed the pull request at: https://github.com/apache/activemq-artemis/pull/1355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] activemq-artemis pull request #1355: ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp ...

2017-06-21 Thread michalxo
Github user michalxo commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1355#discussion_r123177981 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveInterceptorTest.java

[GitHub] activemq-artemis pull request #1356: Documentation minor issues

2017-06-21 Thread michalxo
GitHub user michalxo opened a pull request: https://github.com/apache/activemq-artemis/pull/1356 Documentation minor issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/michalxo/activemq-artemis doc-issues Alternatively you

[GitHub] activemq-artemis pull request #1355: ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp ...

2017-06-21 Thread michalxo
GitHub user michalxo opened a pull request: https://github.com/apache/activemq-artemis/pull/1355 ENTMQBR-559 ADD(Tests) AMQP,MQTT,Stomp interceptor properties tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/michalxo

[GitHub] activemq-artemis pull request #1296: DOC(Addressing Model) minor typos and w...

2017-05-29 Thread michalxo
GitHub user michalxo opened a pull request: https://github.com/apache/activemq-artemis/pull/1296 DOC(Addressing Model) minor typos and word corrections My first try of PR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michalxo