Github user roelens8 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1366#discussion_r124877640
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/PasswordMaskingUtil.java
---
@@ -108,22 +109,34 @@ public static
Github user roelens8 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1366#discussion_r124571031
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/PasswordMaskingUtil.java
---
@@ -108,22 +110,29 @@ public static
Github user roelens8 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1366
@clebertsuconic is my PR good enough to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user roelens8 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1366#discussion_r124116668
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/PasswordMaskingUtil.java
---
@@ -108,22 +110,29 @@ public static
GitHub user roelens8 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1366
ARTEMIS-1252 Add service loading of password codec to obtain its
implementation from the app's root context
Adds service loading to obtain implementation of password codec.
GitHub user roelens8 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1148
[1.x] ARTEMIS-1074 Acceptors/Connectors now start up when configured to use
SSL and a password codec
(cherry picked from commit 3ceb3328664e3dfa1dbeb24bad45115e2f1970c4)
Refer
Github user roelens8 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1139
Could we put up a PR to merge this fix into the 1.X branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user roelens8 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1139#discussion_r108497183
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
---
@@ -139,8 +140,12 @@ private
Github user roelens8 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1139#discussion_r108471873
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
---
@@ -20,6 +20,8 @@
import
Github user roelens8 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1139#discussion_r108338051
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
---
@@ -20,6 +20,8 @@
import
GitHub user roelens8 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1139
ARTEMIS-1074 Acceptors/Connectors now start up when configured to use SSL
and a password codec
-Updates the NettyConnector and NettyAcceptor classes to pass in the
password codec
11 matches
Mail list logo
