Github user scop commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2353#discussion_r224324385
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
---
@@ -1711,7 +1711,7 @@ void
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/2353
Log STOMP transaction starts with debug level instead of error
I don't think error is appropriate here. Perhaps info, but went for debug.
You can merge this pull request into
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/2352
Grammar and spelling fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis grammar
Alternatively you can review
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/1300
Spelling fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis spelling
Alternatively you can review and apply
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/900
I'm afraid I don't. I still have that branch in my fork, but I can't find a
PR here for it. Not sure if I have just forgotten to submit one, but then again
for some reason yo
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/842
NPE fixes
Found through code analysis.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis npe
Alternatively you can
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/829
It's already in (sevntu) checkstyle and enabled, but as mentioned in the
initial comment here, due to a bug in the check, some cases such as these are
currently slipping through.
-
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/831
Javadoc fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis javadoc
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/830
Add EditorConfig settings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis editorconfig
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/829
Remove redundant type arguments
Missed by sevntu-checkstyle, but not the Eclipse compiler.
https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/458
You can merge this pull
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/816
IDE settings updates, mainly Eclipse
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis ide-settings
Alternatively
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/813
Sure, can do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/813
More use of try-with-resources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis try-with-resources
Alternatively
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/812
Spelling fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis spelling
Alternatively you can review and apply
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/804
Hooray, it's about time :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/804
Update error prone, flag missing @Override as error
This updates error prone to 2.0.9. It is not the latest version at the
moment (2.0.13 is), but later versions than that introduce new
Github user scop commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/798#discussion_r80623084
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
---
@@ -1259,6 +1259,7 @@ public
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/799
Found through FirstMessageAsJSON failing and showing Unavailable in red in
jconsole for queues/messages with null property values.
---
If your project is set up for it, you can reply to this
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/799
Fix JsonUtil.addTo*() null add
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis json-add-null
Alternatively you
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/798
Build fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis build-fixes
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/797
Expose disk-scan-period, max-disk-usage, and global-max-size in serveâ¦
â¦r control
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/796
Don't generate unnecessary ID's on divert
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis divert-id
Alt
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/795
Fix closing quorums on QuorumManager.stop
Just something I happened to notice in code while looking into something
else. Not tested.
You can merge this pull request into a Git repository by
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/790
Make bunch of private fields final
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis finals
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/785
Add missing @Overrides, flag as error in IDEs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/784
ARTEMIS-740 Auto-reload diverts from broker.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis divert-reload
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/783
Rename misleading divertBindingNotExists to divertBindingAlreadyExists
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/776
Stomp encode speedups
These translate to ~15% speedup of `toActiveMQBuffer()`, measured with JMH
on my system using a frame with ~20 headers.
You can merge this pull request into a Git
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/775
Add missing @Overrides
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
Alternatively you can review and
Github user scop commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/734#discussion_r76302651
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -154,18 +154,22 @@ public
Github user scop closed the pull request at:
https://github.com/apache/activemq-artemis/pull/733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/733
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/734
Misc small improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis misc
Alternatively you can review and
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/733
ARTEMIS-698 Remove full path + executability check of java
Fixes issues with systems that have no "which", as well as the fallback
to using plain "java" from PATH.
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/732
@clebertsuconic also, in my opinion the separate try to get a full path to
the java executable and the related -x test is somewhat questionable. The full
path is not actually needed for
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/732
Ensure `JAVACMD` and `JAVA_HOME` are not set and `which` is not installed,
that should do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/732
Try to cope with systems without "which" for finding java
whence -p should work with zsh, type -p with bash and ksh.
You can merge this pull request into a Git repository
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/708
Misc trivial fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis misc
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/689
Fix allowable property check on add in AeroGearConnectorService.handle
Issue found by FindBugs. Not tested, nor really understood, but the code
was using a SimpleString to look up things in
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/688
Fix connection list cleanup in OpenWireProtocolManager.removeConnection
Issue found by FindBugs, not tested but I think this is the intended
behavior.
You can merge this pull request into a
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/687
Incorrect type related fixes
Issues found by FindBugs. Incorrect collection accesses due to wrong type
used, and an impossible instanceof.
You can merge this pull request into a Git
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/686
Miscellaneous small improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis misc
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/685
Use try-with-resources some more
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis try-with-resources
Alternatively
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/683
Miscellaneous little fixes
Most found by skimming what FindBugs has to say. Some more coming later.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user scop commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/680#discussion_r72696215
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java
---
@@ -63,10 +63,15 @@ public static final boolean
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/680
Null pointer/check related fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis npe
Alternatively you can review
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/679
Misc cleanups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis misc
Alternatively you can review and apply these
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/665
Spelling fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis spelling
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/645
Fix scaledownhandler lookup duplicate handling
Just something I happened to notice when examining Eclipse's redundant null
check warnings. Not tested, nor have I run into this or
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/644
Override fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/616
Various cleanups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis cleanups
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/582
Fix/update some links in docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis links
Alternatively you can review
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/579
The last commit is unrelated to the diamond operator, but depends on the
sevntu addition so I thought I'd just bundle it here.
---
If your project is set up for it, you can reply to
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/579
Remove redundant type arguments, add sevntu-checkstyle check for it
Hopefully with this check I don't need to keep submitting the redundant
type args PR's any more :)
You can
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/578
Done, plus a few similar ones in examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/578
Update maven-checkstyle-plugin to 2.17, fix violations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/515#issuecomment-219401406
PR updated and force-pushed. Hopefully it passes now, `mvn compile -Pdev`
failed for me due to receiving 502 errors for some deps at
http://repository.apache.org
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/516
Remove redundant type arguments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis redundant
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/515
Use StandardCharsets more
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis standardcharsets
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/454
Avoid unnecessary empty array creation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis arrays
Alternatively you
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/453
Remove redundant toString calls
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis tostring
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/452
Avoid instantiating some number objects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis objects
Alternatively you
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/451
Fix getter and setter validation test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis gettersetter
Alternatively
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/450
Replace some manual array copies with System.arraycopy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis arraycopy
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/449
Add missing @Overrides
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
Alternatively you can review and
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/448
Remove dead code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis deadcode
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/447
Fix URIFactory.removeSchema()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis removeschema
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/432
Remove unnecessary code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis unnecessary
Alternatively you can review
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/431
Spelling fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis spelling
Alternatively you can review and apply
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/430
Add missing @Override annotations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/429
Remove bashishm from ARTEMIS-318 example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis bashism
Alternatively
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/414
Divert doc improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis divert-docs
Alternatively you can review
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/413
HTML fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis html
Alternatively you can review and apply these
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/412#issuecomment-192613742
Not sure what's with Jenkins here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/412
Remove redundant null checks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis nullchecks
Alternatively you can
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/407
Use generics more
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis generics
Alternatively you can review and apply
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/397#issuecomment-186794649
Don't know what's up with Jenkins, but all these failed tests pass for me
locally.
---
If your project is set up for it, you can reply to this emai
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/397
Use try-with-resource more
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis try-with-resource
Alternatively you
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/356
Stomp header related tweaks/improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis stomp-headers
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/347
Use waitDisconnect more
PR #344 missed a few discussed Thread.sleeps
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/344
Disconnect on STOMP 1.2 errors
As required by the spec:
https://stomp.github.io/stomp-specification-1.2.html#ERROR
I'm not particularly happy with the AbstractStompClientConne
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/341#issuecomment-174532317
(Well, the subscription goes away too, but that's expected.)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/341#issuecomment-174532025
You seem to be missing that it's the *topic* (not subscription) that kind
of goes away; trying to send to the topic starts to produce error messages.
-
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/341
ARTEMIS-358 test case for topic disappearing on disconnect without unsub
Test case (not a fix) demonstrating the issue.
You can merge this pull request into a Git repository by running
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/340
Various code cleanups
Was previously included only in getFloatProperty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/339
Include key name in property conversion exception messages
Was previously included only in getFloatProperty
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/307
Deprecation fixes
Some low hanging ones here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis deprecations
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/304#issuecomment-170279942
FWIW, IDEA seems to have such a setting as well, Editor -> Inspections ->
Java -> Inheritance Issues -> Missing @Override annotation
---
If your pr
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/304#issuecomment-170278575
I have my Eclipse config flag them as errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/305
Remove dead code
ServerSessionImpl changes are actually NPE avoiding ones, but similar as
the other ones (were unnecessary null checks) so I left them here. See also
ARTEMIS-335 for one
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/304
Add missing @Overrides
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
Alternatively you can review and
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/303
artemis.cmd, artemis.profile: Drop executable bits
There should be no need for *.cmd to be executable, and since the profile
script is sourced and not executed, it shouldn't need those
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/302
cli logmanager fixes
The artemis.profile.cmd change is untested (no Windows here), just happened
to stumble upon it.
You can merge this pull request into a Git repository by running
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/281
Java version related fixes and cleanups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis javaver
Alternatively you
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/280
Use instead of deprecated with maven-antrun-plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis antrun
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/277#issuecomment-166353664
MissingOverride checkstyle check removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/279
Remove redundant type arguments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis redundant-type
Alternatively you
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/278
Access static members directly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis direct-access
Alternatively you
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/277
Add missing @Overrides
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
Alternatively you can review and
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/228#issuecomment-153434306
I use https://github.com/lyda/misspell-check every now and then on various
projects when I'm bored :)
---
If your project is set up for it, you can rep
1 - 100 of 133 matches
Mail list logo
