GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/26
ARTEMIS-127 Fixes compile errors reported by Error Prone
This fixes the pom parent version for actimemq5.x-tests project and also
fix some compile errors.
You can merge this pull
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110814326
@clebertsuconic, here:
tests/activemq5-unit-tests/pom.xml:23:
version1.0.0-SNAPSHOT/version
Changing to 1.0.1-SNAPHOT breaks the build
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110823751
@clebertsuconic we are skipping checkstyle, may we skip Error Prone also,
just to maintain certain compatibility with the ActiveMQ codebase
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110862182
yes I can.
On Wed, Jun 10, 2015 at 1:44 PM clebertsuconic notificati...@github.com
wrote:
I think we should keep Error Prone
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-110427482
@clebertsuconic please update the parent version pom:
version1.0.0-SNAPSHOT/version
Should we have some kind of rule in the build to enforce
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108443642
Hi, Howard Gao, if you wish, we could work together on this.
On Wed, Jun 3, 2015 at 8:46 AM Howard Gao notificati...@github.com wrote
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/11#issuecomment-108447524
Feel free to do so!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108712726
I am all forward for reusing code/ideas for tests from ActiveMQ! We can
accomplish that with an objective in mind: don't replicate/depend on ActiveMQ,
just
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/11
ARTEMIS-129 License header should be a normal comment
To reproduce this commit, apply the following replace regex rule:
search regex: /\*\*\n \* Licensed
replace
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/11#issuecomment-108167254
Please, review it with some regexes and greps.
On Tue, Jun 2, 2015 at 11:42 PM clebertsuconic notificati...@github.com
wrote:
Nice
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/264
Ignores %PATH/java, use $JAVA_HOME/bin/java instead
Deduce `java` executable from current java.home property to spawn
processes for test purposes.
You can merge this pull request
Github user thiagokronig closed the pull request at:
https://github.com/apache/activemq-artemis/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/260#issuecomment-102563792
I agree. Closing it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/262#issuecomment-102564693
I couldn't the failure in both linux and windows, using `mvn clean test
-Pextra-tests`.
---
If your project is set up for it, you can reply
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/260
Fix AeroGearBasicServerTest by binding random port
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thiagokronig/activemq-artemis
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/260#issuecomment-102047182
Occasionally I have something running on 8080.
I thought that it would be better than binding to a fixed port so common as
8080.
Also, doing so
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/262
Make Topology non-serializable and also improve constructor
Topology serialization is already broken at this point, as its
`topologyListeners` are not Serializable themselves
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/259
Fix FileConfigurationTest for Windows
The test wrongly assumes that Class.getResource(..) needs to specify the
System line-separator. The contract for the method dictates
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/236#issuecomment-100643055
I sent the dummy PR. No HornetQBot messages received so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user thiagokronig closed the pull request at:
https://github.com/apache/activemq-artemis/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/237
DONTMERGEME
As requested by @clebertsuconic, pushing a PR for testing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/236#issuecomment-100573037
AFK here. If you can wait 1 hour, I'll send the null PR
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user thiagokronig opened a pull request:
https://github.com/apache/activemq-artemis/pull/236
Enables Google's Error Prone and fixes some mistakes
Also, I can squash or drop any of the commits. Let me know how can I be
helpful.
You can merge this pull request into a Git
23 matches
Mail list logo
