Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-06 Thread Christopher Shannon
Protocol free sounds good to me. Binary can still be Base64 wrapped. I guess if we did that then the importer could be configured to write the message to the broker in different formats, either core or openwire. Also, one thing I don't currently like with the the XmlImporter implementation is th

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-06 Thread Clebert Suconic
I would change it to be protocol free. text goes here Maps binary etc. On Mon, Mar 6, 2017 at 8:45 AM Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > Sounds good we can talk monday (i guess today). I think the current > strategy of converting to core and using the existin

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-06 Thread Christopher Shannon
Sounds good we can talk monday (i guess today). I think the current strategy of converting to core and using the existing importer is fine for now as i don't want to hold up a 2.0.0 release. But we can target enhancements for future versions. On Sun, Mar 5, 2017 at 11:01 PM, Clebert Suconic wr

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-05 Thread Clebert Suconic
PR just arrived :) https://github.com/apache/activemq-artemis/pull/1064 On Sat, Mar 4, 2017 at 1:10 AM, Clebert Suconic wrote: > @CShanon: I was actually dealing with the exporter/importer today. > > You're right.. the body of the message is for core-only. > > > We could do the following: > > >

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-03 Thread Clebert Suconic
@CShanon: I was actually dealing with the exporter/importer today. You're right.. the body of the message is for core-only. We could do the following: I - expand the format to be agnostic: or we could encode at the protocols it seems easier to just use the protocol now. we could

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-03 Thread Clebert Suconic
... almost there... my testsuite is almost cleaned up.. there will be a few tests failing that will fix after bringing into master. I am planning to bring this into master between now and monday. this is just a heads up. Meanwhile (weekend anyways)... please don't make any too heavy changes :) e

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-02 Thread Clebert Suconic
:O. Wow All this perspiration is paying of at least. 1% inspiration (the idea to use messages directly is quite simple). But changing the amount of dependencies to it. Required some work. I ran the test suite yesterday. Some failures but I know what are they. That means I am almost there t

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-02 Thread nigro_franz
the hw/os configuration is: - Intel® Xeon® Processor E3-1505M v5 - Linux 4.9.6 x86_64 - 32 GB RAM - openjdk version "1.8.0_121" test configuration (1 producer vs 1 consumer): - protocol = amqp - delivery = NonPersistent - destination type = Queue - message bytes = 100 - runs = 5 - warmup ite

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-02 Thread nigro_franz
Sure! ASAP I'll post the results! :) -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-ARTEMIS-1009-Pure-Messaging-Encoding-Refactoring-Artemis-2-0-tp4722638p4722688.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-02 Thread Clebert Suconic
The format is supposed to be protocol free. Are you really being required to use the CoreMessage between for the conversion of the body? if you really need it, we could definitely add a protocol on the XML format. We would of course need to implement OpenWireMessage but that's not difficult at al

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-02 Thread Christopher Shannon
Nice work Clebert. I would think the normal use case is that clients are going to produce/consume in the same protocol so this should be a nice performance boost. This got me thinking...The first version of the KahaDB export tool I am working on uses the Artemis XML format because it just uses th

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-01 Thread Clebert Suconic
If you can actually measure AMQP non persistence before and on my branch? :) that would be awesome! On Wed, Mar 1, 2017 at 1:45 PM, nigro_franz wrote: > +100 an awesome job Clebert!! > If you want I will be happy to bench it against the original version...But I > feel a good vibe here > > > > --

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-01 Thread nigro_franz
+100 an awesome job Clebert!! If you want I will be happy to bench it against the original version...But I feel a good vibe here -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-ARTEMIS-1009-Pure-Messaging-Encoding-Refactoring-Artemis-2-0-tp4722638p4722667.html Se

Re: [DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-01 Thread Clebert Suconic
I will actually create a temporary branch upstream... artemis-1009 Beware. I will daily rebase against master, and eventually squash my commits daily. This is just to make it easier for other people to look into the progress until I send a PR soon. On Wed, Mar 1, 2017 at 11:23 AM, Clebert Suconi

[DISCUSS] ARTEMIS-1009 Pure Messaging Encoding Refactoring Artemis 2.0

2017-03-01 Thread Clebert Suconic
I have been working hard on this one... and it's getting into a nice shape. I should probably send a PR later this week... Meanwhile if you want to see my progress before I send the PR, I am doing my work on this branch: https://github.com/clebertsuconic/activemq-artemis/tree/artemis-1009 if you