Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Robbie Gemmell
I think removing it is a good idea and dont expect removing it now would actually be a big issue, however given it has been there for so long I also dont see that it urgently needs to go away now. Anyone that doesnt want it there already has simple ways to prevent it being there, so I'd probably ju

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Justin Bertram
I think we're arguing different points here. I agree with basically everything you're saying. Is it a waste? Yes. Is there anybody who actually uses it? Probably not (although we don't know for sure). Can folks change their stuff to adjust if necessary? Almost certainly. All things being equal, sh

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Clebert Suconic
I think it's a total waste of resources to keep adding hornetq after 9 years since Artemis 1.0.0 release. We are making *everybody* to have a default hornetq acceptor for the hypothetical one user that is still using it and keeps upgrading every release we make. So, that's a total inexistent case..

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Justin Bertram
It seems pretty black & white to me. Forcing application clients to change their code or configuration for an upgrade is the definition of a breaking change. Forcing admins to change their commands or scripts to get the same configuration as before is also a breaking change. Am I missing something?

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Clebert Suconic
@Justin Bertram I will agree to disagree with you on that one :) If we stick with that policy, we wouldn't be able to do anything.. we have the versions.adoc for that particular reason... and we always have specific instructions in there. the 61616 acceptor will still accept hornetQ connections,

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Justin Bertram
As far as I can tell, the fact that one would need to change what one was doing previously to get the same behavior technically makes this a "breaking change." We really don't know how folks are using the "create" command and how that relates to their migration or upgrade processes. Also, the fact

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Domenico Francesco Bruscino
+1 on deprecating HornetQ protocol and having it off by default On Wed, 7 Aug 2024 at 16:02, Clebert Suconic wrote: > it's not a breaking change.. they can always do : > > ./artemis create --enable-hornetq-adapter... > > that will only affect new servers... new configurations created from > now

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Clebert Suconic
it's not a breaking change.. they can always do : ./artemis create --enable-hornetq-adapter... that will only affect new servers... new configurations created from now on will not have hornetQ. if you migrate a previous configuration with upgrade, it will still be there. it's been 37 versions s

Re: [DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-07 Thread Justin Bertram
Generally speaking I agree, but I'm not sure we can make that change in a minor release since it changed the default behavior and it's not technically a bug. Maybe wait until 3.0? Justin On Tue, Aug 6, 2024 at 11:01 PM Clebert Suconic wrote: > I just realized we still create the following acce

[DISCUSS] HornetQ Acceptor on default acceptor for ActiveMQ Artemis

2024-08-06 Thread Clebert Suconic
I just realized we still create the following acceptor on every server we start: tcp://0.0.0.0:5445?anycastPrefix=jms.queue.;multicastPrefix=jms.topic.;protocols=HORNETQ,STOMP;useEpoll=truehttps://activemq.apache.org/contact