Re: [DISCUSSION] Error prone plugin on codebase

2015-05-29 Thread Lazar Bankovic
unsubscribe 2015-05-29 4:33 GMT+02:00 Clebert Suconic : > Thiago Kronig has recently added error prone to the Artemis codebase, > so any mistakes would be noticed at compilation time. > > I actually liked it quite a lot... Liking even more now as I realize > what is doing :) > > > > I'm now clean

Re: [DISCUSSION] Error prone plugin on codebase

2015-05-29 Thread Christopher Shannon
+1 for adding Error Prone and for adding those 4 mistakes. It should probably be enabled by default since it is compile time and it will help catch problems early. On Fri, May 29, 2015 at 1:47 AM, Thiago Kronig wrote: > It can be very helpful* > > On Fri, May 29, 2015, 02:46 Thiago Kronig wrote

Re: [DISCUSSION] Error prone plugin on codebase

2015-05-28 Thread Thiago Kronig
It can be very helpful* On Fri, May 29, 2015, 02:46 Thiago Kronig wrote: > Just explaining a bit: Error Prone differs on Pmd and FindBugs as it works > at compile time, leveraging the AST to do the work. Or can be very helpful > as it emits compile warnings and errors. > > We could, of course, j

Re: [DISCUSSION] Error prone plugin on codebase

2015-05-28 Thread Thiago Kronig
Just explaining a bit: Error Prone differs on Pmd and FindBugs as it works at compile time, leveraging the AST to do the work. Or can be very helpful as it emits compile warnings and errors. We could, of course, just limit to a specific profile, as it is plugged as a build maven plugin. On Thu, M

[DISCUSSION] Error prone plugin on codebase

2015-05-28 Thread Clebert Suconic
Thiago Kronig has recently added error prone to the Artemis codebase, so any mistakes would be noticed at compilation time. I actually liked it quite a lot... Liking even more now as I realize what is doing :) I'm now cleaning up all the warnings we had on the codebase based on the plugin and I